From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B431C433F5 for ; Sun, 28 Nov 2021 21:07:43 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4J2LfP473Sz3cZN for ; Mon, 29 Nov 2021 08:07:41 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.160.177; helo=mail-qt1-f177.google.com; envelope-from=dennisszhou@gmail.com; receiver=) Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4J2GM62KZBz2xXs for ; Mon, 29 Nov 2021 04:54:08 +1100 (AEDT) Received: by mail-qt1-f177.google.com with SMTP id t34so14081251qtc.7 for ; Sun, 28 Nov 2021 09:54:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CTle792AODDh5EJBSlHCgdnz2AP0iG3Ix/URPyjXa5E=; b=uxISaEdZ/slzQFwZ1mTGO4AZxObxHUGRSmKGiuYxHG3h4e8w3aa7zb7rXcgsUb6/WO yOTg0VYCaOdG4q4kG7zZ+X4kX5Jj/RZ+AY5A6ekRGvprsnYeSMmldeF7Ga+tuS+pAFsz j+Xy9E0zKEGVysZO3/+V/3EWJYhrw01JIu1r2vv1hJGxD01DMTkoMYb7p//NldQK7RNJ 6B1mjGFXBkU24cAGXA5YvPBlCZdU8XIYKk3gNQUfzC+HxW8FxLtGfkdCSPoy/l37wcdS xTzGLYA7JIt6Bg85TO8w56mvqtlOR+/TDXoSo11+DwtwLeJFY53PfPqK+HoA+WmCk8Od hBEQ== X-Gm-Message-State: AOAM530zaM2lLOleiBqxsETVzQVHBWNZ3xc9RjoqWtHb8B9c8K24mUr4 rQQRPdankf/ToZrNJauh7eA= X-Google-Smtp-Source: ABdhPJx25AEVnfH0h4sZET5x0dxImad0u4ySfFGiKfI+WvQd75qCTeFgZjdPUL+9cNE2+e8o/NeT8g== X-Received: by 2002:ac8:5b87:: with SMTP id a7mr38253502qta.196.1638122044539; Sun, 28 Nov 2021 09:54:04 -0800 (PST) Received: from fedora (pool-173-68-57-129.nycmny.fios.verizon.net. [173.68.57.129]) by smtp.gmail.com with ESMTPSA id r16sm7298126qta.46.2021.11.28.09.54.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Nov 2021 09:54:03 -0800 (PST) Date: Sun, 28 Nov 2021 12:54:00 -0500 From: Dennis Zhou To: Yury Norov Subject: Re: [PATCH 7/9] lib/cpumask: add num_{possible,present,active}_cpus_{eq,gt,le} Message-ID: References: <20211128035704.270739-1-yury.norov@gmail.com> <20211128035704.270739-8-yury.norov@gmail.com> <8f389151c39a8a5b6b31d5238cb680305225d9f2.camel@perches.com> <20211128174320.GA304543@lapt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211128174320.GA304543@lapt> X-Mailman-Approved-At: Mon, 29 Nov 2021 08:05:03 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juri Lelli , Andrew Lunn , "Rafael J. Wysocki" , Catalin Marinas , Guo Ren , Christoph Lameter , Christoph Hellwig , Andi Kleen , Vincent Guittot , Ingo Molnar , Geert Uytterhoeven , Mel Gorman , Viresh Kumar , Petr Mladek , Arnaldo Carvalho de Melo , Jens Axboe , Andy Lutomirski , Lee Jones , Greg Kroah-Hartman , Randy Dunlap , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Sergey Senozhatsky , Thomas Gleixner , linux-crypto@vger.kernel.org, Joe Perches , Andrew Morton , Mark Rutland , Anup Patel , linux-ia64@vger.kernel.org, David Airlie , Roy Pledge , Dave Hansen , Solomon Peachy , Stephen Rothwell , Krzysztof Kozlowski , Dennis Zhou , Matti Vaittinen , linux-alpha@vger.kernel.org, Tejun Heo , Kalle Valo , Stephen Boyd , Tariq Toukan , Dinh Nguyen , Jonathan Cameron , Ulf Hansson , Alexander Shishkin , Mike Marciniszyn , Rasmus Villemoes , Subbaraya Sundeep , Will Deacon , Sagi Grimberg , linux-csky@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-snps-arc@lists.infradead.org, Kees Cook , Arnd Bergmann , "James E.J. Bottomley" , Vineet Gupta , Steven Rostedt , Mark Gross , Borislav Petkov , Mauro Carvalho Chehab , Thomas Bogendoerfer , "Martin K. Petersen" , David Laight , Sudeep Holla , Geetha sowjanya , Ian Rogers , kvm@vger.kernel.org, Peter Zijlstra , Amitkumar Karwar , linux-mm@kvack.org, linux-riscv@lists.infradead.org, Jiri Olsa , Ard Biesheuvel , Marc Zyngier , Russell King , Andy Gross , Jakub Kicinski , Vivien Didelot , Sunil Goutham , "Paul E. McKenney" , linux-s390@vger.kernel.org, Alexey Klimov , Heiko Carstens , Hans de Goede , Nicholas Piggin , Marcin Wojtas , Vlastimil Babka , linuxppc-dev@lists.ozlabs.org, linux-mips@vger.kernel.org, Palmer Dabbelt , Daniel Vetter , Jason Wessel , Saeed Mahameed , Andy Shevchenko Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hello, On Sun, Nov 28, 2021 at 09:43:20AM -0800, Yury Norov wrote: > On Sun, Nov 28, 2021 at 09:07:52AM -0800, Joe Perches wrote: > > On Sat, 2021-11-27 at 19:57 -0800, Yury Norov wrote: > > > Add num_{possible,present,active}_cpus_{eq,gt,le} and replace num_*_cpus() > > > with one of new functions where appropriate. This allows num_*_cpus_*() > > > to return earlier depending on the condition. > > [] > > > diff --git a/arch/arc/kernel/smp.c b/arch/arc/kernel/smp.c > > [] > > > @@ -103,7 +103,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus) > > > * if platform didn't set the present map already, do it now > > > * boot cpu is set to present already by init/main.c > > > */ > > > - if (num_present_cpus() <= 1) > > > + if (num_present_cpus_le(2)) > > > init_cpu_present(cpu_possible_mask); > > > > ? is this supposed to be 2 or 1 > > X <= 1 is the equivalent of X < 2. > > > > diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c > > [] > > > @@ -593,7 +593,7 @@ static int __init pcc_cpufreq_init(void) > > > return ret; > > > } > > > > > > - if (num_present_cpus() > 4) { > > > + if (num_present_cpus_gt(4)) { > > > pcc_cpufreq_driver.flags |= CPUFREQ_NO_AUTO_DYNAMIC_SWITCHING; > > > pr_err("%s: Too many CPUs, dynamic performance scaling disabled\n", > > > __func__); > > > > It looks as if the present variants should be using the same values > > so the _le test above with 1 changed to 2 looks odd. > I think the confusion comes from le meaning less than rather than lt. Given the general convention of: lt (<), le (<=), eg (=), ge (>=), gt (>), I'd consider renaming your le to lt. Thanks, Dennis