From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 694A4C433EF for ; Wed, 12 Jan 2022 17:21:32 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4JYvVf6Kx3z3bcT for ; Thu, 13 Jan 2022 04:21:30 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=iD4ax0W/; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::630; helo=mail-pl1-x630.google.com; envelope-from=seanjc@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=iD4ax0W/; dkim-atps=neutral Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4JYvTy5MF8z2xsG for ; Thu, 13 Jan 2022 04:20:53 +1100 (AEDT) Received: by mail-pl1-x630.google.com with SMTP id g5so4884086plo.12 for ; Wed, 12 Jan 2022 09:20:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QRCI1RlLdVZvt5lKUzeK60PXJ4E91izm9CxbrCuYWiw=; b=iD4ax0W/ZQejkpiTV+wC/BTGkgvydCG1+oy9k4x41xcYsxdOIrYBD3Jg5pNLFotLn3 4lS1DP/A5h5rWv9t8jIgjAfIWRHyWSXlvlM7IaIgxX7hDAUmIgxXIoU5b+8CgT0R9dt0 iCbsvCcrQj4kpbl/NpitUUKIbg7rTypIFxqdxfB2feMrGc8niiEgwy4Jncc/4d2meNQg hKQ5yFTrProqxoFW6AG+GqRq3CQHFwiDeSswlB6x17ayzfA94e4NsXmAcxNN0/DUQR5b DQXQiXIgM3bNMe/5PUo8aj95UIBHAUjKy79FkjU/HbhRpV61hkglUgnEV5dHn1QxLypF YTdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QRCI1RlLdVZvt5lKUzeK60PXJ4E91izm9CxbrCuYWiw=; b=s9TFKM5PFMSPGth9GcXMu7rTBLhn2+tOMK9RfIMQfin15jzK2TuttPFrswUUn1lazY SmqsVb+9rMLeciSrjpWc5f/lVK+2454ROYG0w9eF4OKdNQLjvV8NsUkLpSH6aRryByqz lZyE6YFwdVXniG98yRC4ED1qX/+o+T80W2BzQ+2hZ5ABvSTR+YVJu7TSZOx6QpVbsgGY 8uio+m01VS1E4SuCzoHvgLNe1KMtuZ8MfYaGZ+SJ8yLdnl2rZHdOq8i8gZHDHTFMt9Tq LfhLfS6qYb20XoAkAXqbQFMVIiwKxOmXuS2v87EPYJBvFBhO5P4eP7h+LrZmfLXwlr8q 67qQ== X-Gm-Message-State: AOAM530AVOiWYWG1x6/RauPHtxVaa+Bj/mL0noyU6j0lGFMafFvru1OB 35/EJlhIen4kZtP7iTtpsM4meA== X-Google-Smtp-Source: ABdhPJzSQE5HuAs9ufGKv8GVZpWcgq8Jooiv84LWQSj+pdxhdpdaB4H7DHBA1IqNFc1FS00InVj1vA== X-Received: by 2002:a05:6a00:2442:b0:4bc:e7ac:b5aa with SMTP id d2-20020a056a00244200b004bce7acb5aamr553091pfj.56.1642008049112; Wed, 12 Jan 2022 09:20:49 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id kb1sm266614pjb.45.2022.01.12.09.20.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jan 2022 09:20:48 -0800 (PST) Date: Wed, 12 Jan 2022 17:20:44 +0000 From: Sean Christopherson To: Chao Gao Subject: Re: [PATCH 3/6] KVM: Remove opaque from kvm_arch_check_processor_compat Message-ID: References: <20211227081515.2088920-1-chao.gao@intel.com> <20211227081515.2088920-4-chao.gao@intel.com> <20220111031933.GB2175@gao-cwp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220111031933.GB2175@gao-cwp> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, Wanpeng Li , kvm@vger.kernel.org, David Hildenbrand , Dave Hansen , linux-mips@vger.kernel.org, Atish Patra , Paul Mackerras , "H. Peter Anvin" , Alexander Gordeev , Claudio Imbrenda , Will Deacon , "Maciej S. Szmigiero" , linux-s390@vger.kernel.org, Janosch Frank , Marc Zyngier , Joerg Roedel , Huacai Chen , linux-riscv@lists.infradead.org, kvmarm@lists.cs.columbia.edu, Aleksandar Markovic , Ingo Molnar , Catalin Marinas , Palmer Dabbelt , Christian Borntraeger , Ravi Bangoria , kevin.tian@intel.com, Albert Ou , Vasily Gorbik , Suzuki K Poulose , Heiko Carstens , Nicholas Piggin , Borislav Petkov , =?iso-8859-1?Q?C=E9dric?= Le Goater , Paul Walmsley , tglx@linutronix.de, Alexandru Elisei , linux-arm-kernel@lists.infradead.org, Jim Mattson , Thomas Bogendoerfer , Fabiano Rosas , Anup Patel , linux-kernel@vger.kernel.org, Bharata B Rao , James Morse , kvm-riscv@lists.infradead.org, pbonzini@redhat.com, Vitaly Kuznetsov , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Jan 11, 2022, Chao Gao wrote: > On Mon, Jan 10, 2022 at 11:06:44PM +0000, Sean Christopherson wrote: > >On Mon, Dec 27, 2021, Chao Gao wrote: > >> No arch implementation uses this opaque now. > > > >Except for the RISC-V part, this can be a pure revert of commit b99040853738 ("KVM: > >Pass kvm_init()'s opaque param to additional arch funcs"). I think it makes sense > >to process it as a revert, with a short blurb in the changelog to note that RISC-V > >is manually modified as RISC-V support came along in the interim. > > commit b99040853738 adds opaque param to kvm_arch_hardware_setup(), which isn't > reverted in this patch. I.e., this patch is a partial revert of b99040853738 > plus manual changes to RISC-V. Given that, "process it as a revert" means > clearly say in changelog that this commit contains a partial revert of commit > b99040853738 ("KVM: Pass kvm_init()'s opaque param to additional arch funcs"). > > Right? What I meant is literally do git revert -s b99040853738 and then manually handle RISC-V.