From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70EC9C433EF for ; Tue, 4 Jan 2022 16:10:33 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4JSyJS0dzVz307L for ; Wed, 5 Jan 2022 03:10:32 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=cmarinas@kernel.org; receiver=) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4JSyHw5ShGz2x9M for ; Wed, 5 Jan 2022 03:10:04 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AF5966151A; Tue, 4 Jan 2022 16:10:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1017CC36AED; Tue, 4 Jan 2022 16:09:57 +0000 (UTC) Date: Tue, 4 Jan 2022 16:09:54 +0000 From: Catalin Marinas To: Christophe Leroy Subject: Re: [PATCH v6 03/14] mm: Add len and flags parameters to arch_get_mmap_end() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "alex@ghiti.fr" , Steve Capper , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "will@kernel.org" , Paul Mackerras , "akpm@linux-foundation.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Dec 17, 2021 at 10:27:23AM +0000, Christophe Leroy wrote: > Powerpc needs flags and len to make decision on arch_get_mmap_end(). > > So add them as parameters to arch_get_mmap_end(). > > Signed-off-by: Christophe Leroy > Cc: Steve Capper > Cc: Catalin Marinas > Cc: Will Deacon > --- > arch/arm64/include/asm/processor.h | 4 ++-- > mm/mmap.c | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/include/asm/processor.h b/arch/arm64/include/asm/processor.h > index 6f41b65f9962..88c696350ace 100644 > --- a/arch/arm64/include/asm/processor.h > +++ b/arch/arm64/include/asm/processor.h > @@ -91,8 +91,8 @@ > #endif /* CONFIG_COMPAT */ > > #ifndef CONFIG_ARM64_FORCE_52BIT > -#define arch_get_mmap_end(addr) ((addr > DEFAULT_MAP_WINDOW) ? TASK_SIZE :\ > - DEFAULT_MAP_WINDOW) > +#define arch_get_mmap_end(addr, len, flags) ((addr > DEFAULT_MAP_WINDOW) ? TASK_SIZE :\ > + DEFAULT_MAP_WINDOW) Nitpick, move the "((addr > ...." on the following line. Either way, Acked-by: Catalin Marinas