From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4CFD2C433F5 for ; Mon, 24 Jan 2022 12:33:03 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Jj8XF4lXPz3cFX for ; Mon, 24 Jan 2022 23:33:01 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Vq9EghPr; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=bombadil.srs.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=batv+b18af077b488c69bdec9+6728+infradead.org+hch@bombadil.srs.infradead.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Vq9EghPr; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Jj8WR132Jz2x9Q for ; Mon, 24 Jan 2022 23:32:16 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Z2gGoEVk8Y/k11EEWsaZZW9coZbG9Md8ydPQy8yxQzo=; b=Vq9EghPrqQ1SCPzCGV/Usy8QQ1 irUoY6542/6bq7exJ7BO0wU4Je9ALTjesoyZ27H8Y2HNLj0v3eJCXQDKavRRAGAT2qhyG1ESM3X31 VAvbvol1wOkEx8sXL6kWjL7aKoUXgofoiexsWaCTGNbYy7Eusseno0T7nUAJi0ef98UO8jXVid3DV EhuAg0lTdEgmhTpWnZyey3sZehcKL4b/CxiHim1lq0ThJvVzh8z6mlSJArmJZfC41SKgeeM3z6vI3 dR3dLQ6be5L6Ypu1BAe1oLeC/yHUXJ4J173D29hFAIoyL8y72O2zHLyihqkMBlqAQjiL3CAI4V+2T R7EVJJ4A==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nByW4-003Hmi-5y; Mon, 24 Jan 2022 12:32:12 +0000 Date: Mon, 24 Jan 2022 04:32:12 -0800 From: Christoph Hellwig To: Christophe Leroy Subject: Re: [PATCH 1/7] modules: Refactor within_module_core() and within_module_init() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-arch@vger.kernel.org" , "kgdb-bugreport@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Luis Chamberlain , Jessica Yu , "linuxppc-dev@lists.ozlabs.org" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Jan 24, 2022 at 09:22:15AM +0000, Christophe Leroy wrote: > +static inline bool within_range(unsigned long addr, void *base, unsigned int size) Please avoid the overly long line. .. But given that this function only has a single caller I see no point in factoring it out anyway.