From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76679C433F5 for ; Wed, 25 May 2022 08:32:11 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4L7PST46WRz3bsP for ; Wed, 25 May 2022 18:32:09 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=arm.com (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=mark.rutland@arm.com; receiver=) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lists.ozlabs.org (Postfix) with ESMTP id 4L7PRz4QDNz303k for ; Wed, 25 May 2022 18:31:41 +1000 (AEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 24AEB1FB; Wed, 25 May 2022 01:31:08 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.0.228]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F3E743F73D; Wed, 25 May 2022 01:31:02 -0700 (PDT) Date: Wed, 25 May 2022 09:30:55 +0100 From: Mark Rutland To: Tong Tiangen Subject: Re: [PATCH -next v4 3/7] arm64: add support for machine check error safe Message-ID: References: <20220420030418.3189040-1-tongtiangen@huawei.com> <20220420030418.3189040-4-tongtiangen@huawei.com> <46e5954c-a9a8-f4a8-07cc-de42e2753051@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <46e5954c-a9a8-f4a8-07cc-de42e2753051@huawei.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kefeng Wang , Dave Hansen , linux-mm@kvack.org, Paul Mackerras , Guohanjun , Will Deacon , "H . Peter Anvin" , x86@kernel.org, Ingo Molnar , Catalin Marinas , Xie XiuQi , Borislav Petkov , Alexander Viro , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Robin Murphy , linux-kernel@vger.kernel.org, James Morse , Andrew Morton , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, May 19, 2022 at 02:29:54PM +0800, Tong Tiangen wrote: > > > 在 2022/5/13 23:26, Mark Rutland 写道: > > On Wed, Apr 20, 2022 at 03:04:14AM +0000, Tong Tiangen wrote: > > > During the processing of arm64 kernel hardware memory errors(do_sea()), if > > > the errors is consumed in the kernel, the current processing is panic. > > > However, it is not optimal. > > > > > > Take uaccess for example, if the uaccess operation fails due to memory > > > error, only the user process will be affected, kill the user process > > > and isolate the user page with hardware memory errors is a better choice. > > > > Conceptually, I'm fine with the idea of constraining what we do for a > > true uaccess, but I don't like the implementation of this at all, and I > > think we first need to clean up the arm64 extable usage to clearly > > distinguish a uaccess from another access. > > OK,using EX_TYPE_UACCESS and this extable type could be recover, this is > more reasonable. Great. > For EX_TYPE_UACCESS_ERR_ZERO, today we use it for kernel accesses in a > couple of cases, such as > get_user/futex/__user_cache_maint()/__user_swpX_asm(), Those are all user accesses. However, __get_kernel_nofault() and __put_kernel_nofault() use EX_TYPE_UACCESS_ERR_ZERO by way of __{get,put}_mem_asm(), so we'd need to refactor that code to split the user/kernel cases higher up the callchain. > your suggestion is: > get_user continues to use EX_TYPE_UACCESS_ERR_ZERO and the other cases use > new type EX_TYPE_FIXUP_ERR_ZERO? Yes, that's the rough shape. We could make the latter EX_TYPE_KACCESS_ERR_ZERO to be clearly analogous to EX_TYPE_UACCESS_ERR_ZERO, and with that I susepct we could remove EX_TYPE_FIXUP. Thanks, Mark.