From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linux-ide@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Paul Mackerras <paulus@samba.org>,
linux-i2c@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Jiri Slaby <jirislaby@kernel.org>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
linux-serial@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Anatolij Gustschin <agust@denx.de>,
Wolfgang Grandegger <wg@grandegger.com>,
linux-can@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Sergey Shtylyov <s.shtylyov@omp.ru>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Wolfram Sang <wsa@kernel.org>,
chris.packham@alliedtelesis.co.nz, netdev@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v2 4/4] powerpc/52xx: Convert to use fwnode API
Date: Mon, 16 May 2022 17:10:49 +0300 [thread overview]
Message-ID: <YoJbaTNJFV2A1Etw@smile.fi.intel.com> (raw)
In-Reply-To: <YoJaGGwfoSYhaT13@smile.fi.intel.com>
On Mon, May 16, 2022 at 05:05:12PM +0300, Andy Shevchenko wrote:
> On Mon, May 16, 2022 at 11:48:05PM +1000, Michael Ellerman wrote:
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
> > > We may convert the GPT driver to use fwnode API for the sake
> > > of consistency of the used APIs inside the driver.
> >
> > I'm not sure about this one.
> >
> > It's more consistent to use fwnode in this driver, but it's very
> > inconsistent with the rest of the powerpc code. We have basically no
> > uses of the fwnode APIs at the moment.
>
> Fair point!
>
> > It seems like a pretty straight-forward conversion, but there could
> > easily be a bug in there, I don't have any way to test it. Do you?
>
> Nope, only compile testing. The important part of this series is to
> clean up of_node from GPIO library, so since here it's a user of
> it I want to do that. This patch is just ad-hoc conversion that I
> noticed is possible. But there is no any requirement to do so.
>
> Lemme drop this from v3.
I just realize that there is no point to send a v3. You can just apply
first 3 patches. Or is your comment against entire series?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-05-16 14:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-07 10:01 [PATCH v2 1/4] powerpc/52xx: Remove dead code, i.e. mpc52xx_get_xtal_freq() Andy Shevchenko
2022-05-07 10:01 ` [PATCH v2 2/4] powerpc/mpc5xxx: Switch mpc5xxx_get_bus_frequency() to use fwnode Andy Shevchenko
2022-05-07 10:01 ` [PATCH v2 3/4] powerpc/52xx: Get rid of of_node assignment Andy Shevchenko
2022-05-07 10:01 ` [PATCH v2 4/4] powerpc/52xx: Convert to use fwnode API Andy Shevchenko
2022-05-16 13:48 ` Michael Ellerman
2022-05-16 14:05 ` Andy Shevchenko
2022-05-16 14:10 ` Andy Shevchenko [this message]
2022-05-16 23:38 ` Michael Ellerman
2022-05-17 16:30 ` Andy Shevchenko
2022-06-29 12:15 ` [PATCH v2 1/4] powerpc/52xx: Remove dead code, i.e. mpc52xx_get_xtal_freq() Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoJbaTNJFV2A1Etw@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=agust@denx.de \
--cc=broonie@kernel.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=damien.lemoal@opensource.wdc.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mkl@pengutronix.de \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paulus@samba.org \
--cc=s.shtylyov@omp.ru \
--cc=wg@grandegger.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).