From: Greg KH <gregkh@linuxfoundation.org>
To: Ning Qiang <sohu0106@126.com>
Cc: security@kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] macintosh:fix oob read in do_adb_query function
Date: Wed, 13 Jul 2022 18:43:18 +0200 [thread overview]
Message-ID: <Ys72JqcqGQQa12YS@kroah.com> (raw)
In-Reply-To: <20220713153734.2248-1-sohu0106@126.com>
On Wed, Jul 13, 2022 at 11:37:34PM +0800, Ning Qiang wrote:
> In do_adb_query function of drivers/macintosh/adb.c, req->data is copy
> form userland. the parameter "req->data[2]" is Missing check, the
> array size of adb_handler[] is 16, so "adb_handler[
> req->data[2]].original_address" and "adb_handler[
> req->data[2]].handler_id" will lead to oob read.
>
> Signed-off-by: Ning Qiang <sohu0106@126.com>
Cc: stable <stable@kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2022-07-13 16:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 15:37 [PATCH] macintosh:fix oob read in do_adb_query function Ning Qiang
2022-07-13 16:43 ` Greg KH [this message]
2022-07-13 18:53 ` Kees Cook
2022-07-14 22:33 ` Benjamin Herrenschmidt
2022-07-14 22:33 ` Benjamin Herrenschmidt
2022-07-29 13:01 ` Michael Ellerman
-- strict thread matches above, loose matches on Subject: below --
2022-07-13 13:40 NAME
2022-07-13 14:03 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ys72JqcqGQQa12YS@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=security@kernel.org \
--cc=sohu0106@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox