From: Alan Stern <stern@rowland.harvard.edu>
To: Greg KH <gregkh@linuxfoundation.org>, Rob Herring <robh@kernel.org>
Cc: Darren Stevens <darren@stevens-zone.net>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Linux USB List <linux-usb@vger.kernel.org>,
Yang-Leo Li <leoyang.li@nxp.com>, Scott Wood <oss@buserror.net>,
Christian Zigotzky <chzigotzky@xenosoft.de>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH v3] drivers/usb/host/ehci-fsl: Fix interrupt setup in host mode.
Date: Tue, 5 Jul 2022 14:54:55 -0400 [thread overview]
Message-ID: <YsSI/7uGfRWHps9A@rowland.harvard.edu> (raw)
In-Reply-To: <CAL_Jsq+K7MN6kzMshNtBXYsM=1AKyJFL7OQpsevba2xmKz0=sg@mail.gmail.com>
On Tue, Jul 05, 2022 at 10:29:53AM -0600, Rob Herring wrote:
> On Sat, Jul 2, 2022 at 3:04 PM Darren Stevens <darren@stevens-zone.net> wrote:
> >
> > In patch a1a2b7125e10 (Drop static setup of IRQ resource from DT
> > core) we stopped platform_get_resource() from returning the IRQ, as all
> > drivers were supposed to have switched to platform_get_irq()
> > Unfortunately the Freescale EHCI driver in host mode got missed. Fix
> > it.
> >
> > Fixes: a1a2b7125e10 (Drop static setup of IRQ resource from DT core)
> > Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
> > Suggested-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Darren Stevens <darren@stevens-zone.net>
> > ---
> > v3 - Corrected resource allocation in fsl-mph-dr-of.c
> >
> > v2 - Fixed coding style, removed a couple of unneeded initializations,
> > cc'd Layerscape maintainers.
> >
> > Tested on AmigaOne X5000/20 and X5000/40 Contains code by Rob Herring
> > (in fsl-mph-dr-of.c)
>
> Thanks for fixing.
>
> Acked-by: Rob Herring <robh@kernel.org>
Okay for me too.
Acked-by: Alan Stern <stern@rowland.harvard.edu>
prev parent reply other threads:[~2022-07-05 19:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-02 21:03 [PATCH v3] drivers/usb/host/ehci-fsl: Fix interrupt setup in host mode Darren Stevens
2022-07-05 15:40 ` Christian Zigotzky
2022-07-05 16:29 ` Rob Herring
2022-07-05 18:54 ` Alan Stern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsSI/7uGfRWHps9A@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=chzigotzky@xenosoft.de \
--cc=darren@stevens-zone.net \
--cc=gregkh@linuxfoundation.org \
--cc=leoyang.li@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oss@buserror.net \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).