From: Yury Norov <yury.norov@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"open list:LINUX FOR POWERPC PA SEMI PWRFICIENT"
<linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 1/2] powerpc: drop dependency on <asm/machdep.h> in archrandom.h
Date: Mon, 25 Jul 2022 09:17:42 -0700 [thread overview]
Message-ID: <Yt7CJj8r3eo05pKd@yury-laptop> (raw)
In-Reply-To: <CAHp75VfOmN=cTEs7gbwxZ7W3hXjBo67N4AmHHiDfcVfFzHkMLA@mail.gmail.com>
On Mon, Jul 25, 2022 at 09:28:12AM +0200, Andy Shevchenko wrote:
> On Sun, Jul 24, 2022 at 12:19 AM Yury Norov <yury.norov@gmail.com> wrote:
> >
> > archrandom.h includes <asm/machdep.h> to refer ppc_md. This causes
> > circular header dependency, if generic nodemask.h includes random.h:
> >
> > In file included from include/linux/cred.h:16,
> > from include/linux/seq_file.h:13,
> > from arch/powerpc/include/asm/machdep.h:6,
> > from arch/powerpc/include/asm/archrandom.h:5,
> > from include/linux/random.h:109,
> > from include/linux/nodemask.h:97,
> > from include/linux/list_lru.h:12,
> > from include/linux/fs.h:13,
> > from include/linux/compat.h:17,
> > from arch/powerpc/kernel/asm-offsets.c:12:
> > include/linux/sched.h:1203:9: error: unknown type name 'nodemask_t'
> > 1203 | nodemask_t mems_allowed;
> > | ^~~~~~~~~~
> >
> > Fix it by removing <asm/machdep.h> dependency from archrandom.h
>
> ...
>
> > EXPORT_SYMBOL_GPL(pm_power_off);
>
> ^^^ (Note this and read below)
>
> ...
>
> > +EXPORT_SYMBOL(arch_get_random_seed_long);
>
> It can't be like this. Brief browsing of the callees shows that.
Is my understanding correct that you're suggesting to make it GPL?
ppc_md is exported with EXPORT_SYMBOL(), and the function is in header,
so it's available for non-GPL code now. I don't want to change it.
next prev parent reply other threads:[~2022-07-25 16:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-23 21:45 [PATCH 0/2] lib/nodemask: inline wrappers around bitmap Yury Norov
2022-07-23 21:45 ` [PATCH 1/2] powerpc: drop dependency on <asm/machdep.h> in archrandom.h Yury Norov
2022-07-25 7:28 ` Andy Shevchenko
2022-07-25 16:17 ` Yury Norov [this message]
2022-07-25 21:39 ` Andy Shevchenko
2022-07-25 23:32 ` Yury Norov
2022-07-26 6:13 ` Andy Shevchenko
2022-07-26 6:15 ` Andy Shevchenko
2022-07-26 6:57 ` Michael Ellerman
2022-07-26 15:19 ` Yury Norov
2022-07-25 8:34 ` Michael Ellerman
2022-07-25 12:22 ` Michael Ellerman
2022-07-25 16:28 ` Yury Norov
2022-07-26 2:46 ` Michael Ellerman
2022-07-25 12:22 ` Michael Ellerman
2022-07-23 21:45 ` [RESEND PATCH 2/2] lib/nodemask: inline next_node_in() and node_random() Yury Norov
2022-08-12 5:16 ` Aneesh Kumar K.V
2022-08-12 5:40 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yt7CJj8r3eo05pKd@yury-laptop \
--to=yury.norov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox