From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64995C00140 for ; Sun, 21 Aug 2022 12:40:56 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4M9Zpt4ZvXz3c6S for ; Sun, 21 Aug 2022 22:40:54 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=h2mT+V1f; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=145.40.68.75; helo=ams.source.kernel.org; envelope-from=leon@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=h2mT+V1f; dkim-atps=neutral Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4M9YRh2zrRz3bVt for ; Sun, 21 Aug 2022 21:39:12 +1000 (AEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B806DB80CAD; Sun, 21 Aug 2022 11:39:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16F82C433C1; Sun, 21 Aug 2022 11:39:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661081946; bh=XskdzOo4d6sQ470cDvLPNQUn3vWKINLbams0NyYkyHs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h2mT+V1f1lnbZkkGAhFAY/FsV+M1AF9PcfNeRDvNZKCJy57DaoMtr9s0psqD3Q1mO lbDhmNpKNvV/MR3fm6StN1mxNxpQJUC8tyMYcQcHpyiP/DrWCMjJuOVjw/fDkS+Jbx q48H/NylIMORBfw8L2CaoJxyCseFOceSz7e8e7zajZorpFMEhY5H7KErwdtQ0xCEA5 hvyLFOsrJINBQhAU2H/quZ7hJS+vJsR04M2CqzO5yYMTToisG1GuzCWaEmeBmvQMOw uIVl8tgoxsIPMIJR37nelEvAqkJqxypMLHMFaQaclZNgvWJYRb3CySjpqDkfgWXLC6 zNIdvXH7Xnd5w== Date: Sun, 21 Aug 2022 14:39:01 +0300 From: Leon Romanovsky To: Wolfram Sang Subject: Re: [PATCH] net: move from strlcpy with unused retval to strscpy Message-ID: References: <20220818210050.7108-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220818210050.7108-1-wsa+renesas@sang-engineering.com> X-Mailman-Approved-At: Sun, 21 Aug 2022 22:40:22 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Shyam Sundar S K , Igor Russkikh , Kevin Brace , David Dillow , Somnath Kotur , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , "K. Y. Srinivasan" , linux-stm32@st-md-mailman.stormreply.com, Andy Gospodarek , Wei Liu , Manish Chopra , Samuel Holland , Madalin Bucur , Christian Lamparter , Michal Simek , Jose Abreu , Radhey Shyam Pandey , Franky Lin , Mark Lee , Chris Lee , Nick Child , Jiri Pirko , Jay Vosburgh , Vinay Kumar Yadav , Arend van Spriel , Nicholas Piggin , Igor Mitsyanko , Krzysztof Halasa , Shay Agroskin , linux-omap@vger.kernel.org, Petr Machata , libertas-dev@lists.infradead.org, Rasesh Mody , Ilias Apalodimas , Douglas Miller , Joakim Zhang , Ralf Baechle , Vivien Didelot , Ion Badulescu , Hartley Sweeten , Stanislav Yakovlev , Jon Mason , Vladimir Oltean , Claudiu Beznea , Christian Benvenuti , Samuel Chessman , linux-usb@vger.kernel.org, Ronak Doshi , Kunihiko Hayashi , Chris Snook , Deni s Kirjanov , Prashant Sreedharan , linux-kernel@vger.kernel.org, Daniele Venzano , Eric Dumazet , Zhu Yanjun , Tony Nguyen , Arthur Kiyanovski , "David S. Miller" , Sergey Matyukevich , Jesse Brandeburg , Rain River , Veaceslav Falico , Martin Habets , Yisen Zhuang , Wolfgang Grandegger , Steve Glendinning , Tom Lendacky , Michael Hennerich , Ido Schimmel , Sean Wang , linuxppc-dev@lists.ozlabs.org, linux-can@vger.kernel.org, Siva Reddy Kallam , Claudiu Manoil , Doug Berg er , Simon Kelley , Giuseppe Cavallaro , linux-arm-kernel@lists.infradead.org, Mirko Lindner , Sriharsha Basavapatna , Nicolas Pitre , David Arinzon , Rohit Maheshwari , Tariq Toukan , Sudarsana Kalluru , Taras Chornyi , Maxime Coquelin , linux-mediatek@lists.infradead.org, Heiner Kallweit , linux-wireless@vger.kernel.org, Ajit Khaparde , Petko Manolov , Andreas Larsson , Jason Wang , Kurt Kanzenbach , linux-hyperv@vger.kernel.org, oss-drivers@corigine.com, netdev@vger.kernel.org, Subbaraya Sundeep , Hin-Tak Leung , Jassi Brar , Noam Dagan , Stanislaw Gruszka , Ajay Singh , Florian Fainelli , Dave Jiang , linux-rdma@vger.kernel.org, Guo-Fu Tseng , Dexuan Cui , Jernej Skrabec , Chen-Yu Tsai , Broadcom internal kernel review list , b43-dev@lists.infradead.org, Simon Horman , Paolo Abeni , Allen Hubbe , Shahed Shaikh , Grygorii Strashko , Byungho An , Haiyang Zhang , Francois Romieu , Hante Meuleman , Vladimir Zapolskiy , Don Fry , John Crispin , Michael Chan , virtualization @lists.linux-foundation.org, Salil Mehta , GR-Linux-NIC-Dev@marvell.com, linux-parisc@vger.kernel.org, Geoff Levand , linux-sunxi@lists.linux.dev, Edward Cree , Bryan Whitehead , Saeed Bishara , Mark Einon , Geetha sowjanya , Oliver Neukum , "Michael S. Tsirkin" , VMware PV-Drivers Reviewers , Ioana Ciornei , Alexandre Torgue , Govindarajulu Varadarajan <_govind@gmx.com>, Thomas Petazzoni , Ayush Sawal , UNGLinuxDriver@microchip.com, linux-acenic@sunsite.dk, Herton Ronaldo Krzesinski , Rahul Verma , Russell King , SHA-cyfmac-dev-list@infineon.com, Lino Sanfilippo , intel-wired -lan@lists.osuosl.org, Jakub Kicinski , Steffen Klassert , Sunil Goutham , Sebastian Hesselbarth , Jes Sorensen , nic_swsd@realtek.com, Ariel Elior , Jouni Malinen , Kalle Valo , Marc Kleine-Budde , Matthias Brugger , Marcin Wojtas , brcm80211-dev-list.pdl@broadcom.com, Sridhar Samudrala , David Ahern , linux-mips@vger.kernel.org, Li Yang , Stephen Hemminger , hariprasad , ntb@lists.linux.dev, Raju Rangoju , Larry Finger , Saeed Mahameed , Felix Fietkau Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Aug 18, 2022 at 11:00:34PM +0200, Wolfram Sang wrote: > Follow the advice of the below link and prefer 'strscpy' in this > subsystem. Conversion is 1:1 because the return value is not used. > Generated by a coccinelle script. > > Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ > Signed-off-by: Wolfram Sang > --- <...> > drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 6 +++--- > drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +- > .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 4 ++-- > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +- > .../ethernet/mellanox/mlx5/core/ipoib/ethtool.c | 2 +- Thanks, Reviewed-by: Leon Romanovsky