From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69220C32789 for ; Mon, 22 Aug 2022 11:31:01 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4MB9Cl51fsz3cdx for ; Mon, 22 Aug 2022 21:30:59 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Aed23r0B; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=bombadil.srs.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=batv+4b2a6d3357734ce411bc+6938+infradead.org+hch@bombadil.srs.infradead.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Aed23r0B; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4MB9C242NRz3bl3 for ; Mon, 22 Aug 2022 21:30:17 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5PcSssONmYM3nGWZ6RybkrMzsWV43+5Lu+oPjbsK9zI=; b=Aed23r0BX7Hj140U9k0lKyJGR8 Piw3zgTmPGsDamksZWnfXohz+mJqQOE8Faq0OpNVqaVGRnemNwYYe2HFgFEHn8KfF1Pg9ERojir1x 7V7Tp8SJivsdTaTkWWupTE9k6QnGrFTZikAa7n5N3zptDcEgyq8yXin3HRPlC5pHeyiT3gQoAbVhm qkOhqJlZwlkYwv/RdH4F0fnune1YpcADQ5RwEVTBAFgqqd4GW8q2VzdMhlc00au8nclJHynTpzkDX iKkT1tTOFSHQ+WrIoFyZjEv/eAaEYtog9XIuIaTaeAUNCdjS0fYV6BsQ2Dv1zYH6O59I3zLjZKjhz DdyyUBzA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQ5d7-008FXQ-Tk; Mon, 22 Aug 2022 11:30:05 +0000 Date: Mon, 22 Aug 2022 04:30:05 -0700 From: Christoph Hellwig To: Michael Ellerman Subject: Re: [PATCH] powerpc: export cpu_smallcore_map for modules Message-ID: References: <20220819210112.7924-1-rdunlap@infradead.org> <87o7wdkkt4.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87o7wdkkt4.fsf@mpe.ellerman.id.au> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Gautham R . Shenoy" , amd-gfx@lists.freedesktop.org, "Pan, Xinhui" , Felix Kuehling , Randy Dunlap , Lai Jiangshan , linux-kernel@vger.kernel.org, Tejun Heo , Nicholas Piggin , Alex Deucher , linuxppc-dev@lists.ozlabs.org, Christian =?iso-8859-1?Q?K=F6nig?= Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Aug 22, 2022 at 01:40:23PM +1000, Michael Ellerman wrote: > Randy Dunlap writes: > > drivers/gpu/drm/amd/amdkfd/kfd_device.c calls cpu_smt_mask(). > > This is an inline function on powerpc which references > > cpu_smallcore_map. > > > > Fixes: 425752c63b6f ("powerpc: Detect the presence of big-cores via "ibm, thread-groups"") > > Fixes: 7bc913085765 ("drm/amdkfd: Try to schedule bottom half on same core") > > That 2nd commit is not in mainline, only linux-next. > > I don't mind merging this fix preemptively, but is that SHA stable? I really do not think this has any business being exported at all. kfd_queue_work is not something that should be done in a driver. Something like this belongs into the workqueue core, not in an underdocumented helper in a random driver. Drm guys: once again, please please work with the maintainers instead of just making up random stuff in the drivers.