From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49EBFC0502A for ; Fri, 26 Aug 2022 21:38:08 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4MDtVQ1lZNz3c4c for ; Sat, 27 Aug 2022 07:38:06 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=eDfsmGrE; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=eDfsmGrE; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=peterx@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=eDfsmGrE; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=eDfsmGrE; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4MDtTZ4y4Qz305p for ; Sat, 27 Aug 2022 07:37:19 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661549837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2KrAZmGrG6kDDNuHo11ICMD83hxyjEivX/cg1A87nKw=; b=eDfsmGrEaii37QWWfsz/Vty7cHjlikpKY1TkM3JJhPWrNke2XmpVTwWJIFoTuUtFQjl3yi 8DxsyeyUqki4apAsbOC5DbDi8sbS6OR7vc3RNMZI+VUaBrk17iKvZy1FQNjGPw85t2dV3s 9r/tH7pC2kYumgwYY8MNZWYRK0h3KlI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661549837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2KrAZmGrG6kDDNuHo11ICMD83hxyjEivX/cg1A87nKw=; b=eDfsmGrEaii37QWWfsz/Vty7cHjlikpKY1TkM3JJhPWrNke2XmpVTwWJIFoTuUtFQjl3yi 8DxsyeyUqki4apAsbOC5DbDi8sbS6OR7vc3RNMZI+VUaBrk17iKvZy1FQNjGPw85t2dV3s 9r/tH7pC2kYumgwYY8MNZWYRK0h3KlI= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-168-j3NmtdzaOBKeBZJ0YqyiaQ-1; Fri, 26 Aug 2022 17:37:15 -0400 X-MC-Unique: j3NmtdzaOBKeBZJ0YqyiaQ-1 Received: by mail-qk1-f197.google.com with SMTP id w17-20020a05620a425100b006b97978c693so2189485qko.19 for ; Fri, 26 Aug 2022 14:37:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=2KrAZmGrG6kDDNuHo11ICMD83hxyjEivX/cg1A87nKw=; b=g991GLZVlBLg3siVl0dYdjgpQ+el1rQ1HyfwozyiV7madg690rN/40Jo69u8PwG5O4 Hk5Dt/XowG+xrLFV7UUdEPqt/5cDN3GgO44TwL8TVXTYRda/9FhY2ZDDO5lforcQ0aaF PRsA8HY7iO18Q4VE7k4jLjARoVzhyhLdderLLWbanyDC5D5ODGIFv1N/2sU/NskF6dG/ km0JDBSdzjuRb9Q1m6BZwQIAGGq5pQyvbpfZikrGF+TF6yyrLDekvmrH1CPJNw5R0RF4 2I9sBmz6GzbCdNIaFnrgH+7ii57VzNk/WIKAxSnMcVOq9IxoxugL2bRqRBrVAxfm9+zN 7Tew== X-Gm-Message-State: ACgBeo3Gpg0iEA/wcklgXThVuO1/8t3HGasI7T5OWzctBXzdp24PWbem xfBOetc/feGOarwjoa7IMYGU38rcQiBOYnhHqfmSpFPFhGeMN/Y43vAFzORcPTxrEy/YGU4V6P1 Deu9qy55yoCtwRszJn4VYBWeCKA== X-Received: by 2002:a05:6214:e6c:b0:476:a4bd:2b95 with SMTP id jz12-20020a0562140e6c00b00476a4bd2b95mr1312602qvb.25.1661549835160; Fri, 26 Aug 2022 14:37:15 -0700 (PDT) X-Google-Smtp-Source: AA6agR53is4ixbz7h41Wx5XIm184jiaZL8HsGwhTwAJEHRIbbpDPLRMqX963knWH+clH/uGR3aknhA== X-Received: by 2002:a05:6214:e6c:b0:476:a4bd:2b95 with SMTP id jz12-20020a0562140e6c00b00476a4bd2b95mr1312571qvb.25.1661549834906; Fri, 26 Aug 2022 14:37:14 -0700 (PDT) Received: from xz-m1.local (bras-base-aurron9127w-grc-35-70-27-3-10.dsl.bell.ca. [70.27.3.10]) by smtp.gmail.com with ESMTPSA id h1-20020a05620a400100b006bbe7ded98csm554339qko.112.2022.08.26.14.37.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Aug 2022 14:37:14 -0700 (PDT) Date: Fri, 26 Aug 2022 17:37:12 -0400 From: Peter Xu To: David Hildenbrand Subject: Re: [PATCH v3 2/3] mm/migrate_device.c: Copy pte dirty bit to page Message-ID: References: <3b01af093515ce2960ac39bb16ff77473150d179.1661309831.git-series.apopple@nvidia.com> <8735dkeyyg.fsf@nvdebian.thelocal> <8735dj7qwb.fsf@nvdebian.thelocal> <72146725-3d70-0427-50d4-165283a5a85d@redhat.com> <140e7688-b66d-2f6d-fed8-e39da5045420@redhat.com> MIME-Version: 1.0 In-Reply-To: <140e7688-b66d-2f6d-fed8-e39da5045420@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Sierra Guiza, Alejandro \(Alex\)" , Huang Ying , Ralph Campbell , linuxppc-dev@lists.ozlabs.org, Lyude Paul , Karol Herbst , Nadav Amit , Felix Kuehling , Alistair Popple , LKML , Matthew Wilcox , linux-mm@kvack.org, Logan Gunthorpe , Ben Skeggs , Jason Gunthorpe , John Hubbard , stable@vger.kernel.org, akpm@linux-foundation.org, huang ying Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Aug 26, 2022 at 06:46:02PM +0200, David Hildenbrand wrote: > On 26.08.22 17:55, Peter Xu wrote: > > On Fri, Aug 26, 2022 at 04:47:22PM +0200, David Hildenbrand wrote: > >>> To me anon exclusive only shows this mm exclusively owns this page. I > >>> didn't quickly figure out why that requires different handling on tlb > >>> flushs. Did I perhaps miss something? > >> > >> GUP-fast is the magic bit, we have to make sure that we won't see new > >> GUP pins, thus the TLB flush. > >> > >> include/linux/mm.h:gup_must_unshare() contains documentation. > > > > Hmm.. Shouldn't ptep_get_and_clear() (e.g., xchg() on x86_64) already > > guarantees that no other process/thread will see this pte anymore > > afterwards? > > You could have a GUP-fast thread that just looked up the PTE and is > going to pin the page afterwards, after the ptep_get_and_clear() > returned. You'll have to wait until that thread finished. IIUC the early tlb flush won't protect concurrent fast-gup from happening, but I think it's safe because fast-gup will check pte after pinning, so either: (1) fast-gup runs before ptep_get_and_clear(), then page_try_share_anon_rmap() will fail properly, or, (2) fast-gup runs during or after ptep_get_and_clear(), then fast-gup will see that either the pte is none or changed, then it'll fail the fast-gup itself. > > Another user that relies on this interaction between GUP-fast and TLB > flushing is for example mm/ksm.c:write_protect_page() > > There is a comment in there explaining the interaction a bit more detailed. > > Maybe we'll be able to handle this differently in the future (maybe once > this turns out to be an actual performance problem). Unfortunately, > mm->write_protect_seq isn't easily usable because we'd need have to make > sure we're the exclusive writer. > > > For now, it's not too complicated. For PTEs: > * try_to_migrate_one() already uses ptep_clear_flush(). > * try_to_unmap_one() already conditionally used ptep_clear_flush(). > * migrate_vma_collect_pmd() was the one case that didn't use it already > (and I wonder why it's different than try_to_migrate_one()). I'm not sure whether I fully get the point, but here one major difference is all the rest handles one page, so a tlb flush alongside with the pte clear sounds reasonable. Even if so try_to_unmap_one() was modified to use tlb batching, but then I see that anon exclusive made that batching conditional. I also have question there on whether we can keep using the tlb batching even with anon exclusive pages there. In general, I still don't see how stall tlb could affect anon exclusive pages on racing with fast-gup, because the only side effect of a stall tlb is unwanted page update iiuc, the problem is fast-gup doesn't even use tlb, afaict.. Thanks, -- Peter Xu