* [PATCH][next] powerpc/xmon: Fix -Wswitch-unreachable warning in bpt_cmds
@ 2022-09-16 14:15 Gustavo A. R. Silva
2022-09-16 14:42 ` Kees Cook
2022-11-30 9:23 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2022-09-16 14:15 UTC (permalink / raw)
To: Michael Ellerman, Nicholas Piggin, Christophe Leroy
Cc: linux-hardening, linuxppc-dev, linux-kernel, Gustavo A. R. Silva
When building with automatic stack variable initialization, GCC 12
complains about variables defined outside of switch case statements.
Move the variable into the case that uses it, which silences the warning:
arch/powerpc/xmon/xmon.c: In function ‘bpt_cmds’:
arch/powerpc/xmon/xmon.c:1529:13: warning: statement will never be executed [-Wswitch-unreachable]
1529 | int mode;
| ^~~~
Fixes: 09b6c1129f89 ("powerpc/xmon: Fix compile error with PPC_8xx=y")
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
arch/powerpc/xmon/xmon.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index 26ef3388c24c..df91dfc7ff72 100644
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerpc/xmon/xmon.c
@@ -1525,9 +1525,9 @@ bpt_cmds(void)
cmd = inchar();
switch (cmd) {
- static const char badaddr[] = "Only kernel addresses are permitted for breakpoints\n";
- int mode;
- case 'd': /* bd - hardware data breakpoint */
+ case 'd': { /* bd - hardware data breakpoint */
+ static const char badaddr[] = "Only kernel addresses are permitted for breakpoints\n";
+ int mode;
if (xmon_is_ro) {
printf(xmon_ro_msg);
break;
@@ -1560,6 +1560,7 @@ bpt_cmds(void)
force_enable_xmon();
break;
+ }
case 'i': /* bi - hardware instr breakpoint */
if (xmon_is_ro) {
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] powerpc/xmon: Fix -Wswitch-unreachable warning in bpt_cmds
2022-09-16 14:15 [PATCH][next] powerpc/xmon: Fix -Wswitch-unreachable warning in bpt_cmds Gustavo A. R. Silva
@ 2022-09-16 14:42 ` Kees Cook
2022-11-30 9:23 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Kees Cook @ 2022-09-16 14:42 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Nicholas Piggin, linux-kernel, linux-hardening, linuxppc-dev
On Fri, Sep 16, 2022 at 03:15:04PM +0100, Gustavo A. R. Silva wrote:
> When building with automatic stack variable initialization, GCC 12
> complains about variables defined outside of switch case statements.
> Move the variable into the case that uses it, which silences the warning:
>
> arch/powerpc/xmon/xmon.c: In function ‘bpt_cmds’:
> arch/powerpc/xmon/xmon.c:1529:13: warning: statement will never be executed [-Wswitch-unreachable]
> 1529 | int mode;
> | ^~~~
>
> Fixes: 09b6c1129f89 ("powerpc/xmon: Fix compile error with PPC_8xx=y")
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] powerpc/xmon: Fix -Wswitch-unreachable warning in bpt_cmds
2022-09-16 14:15 [PATCH][next] powerpc/xmon: Fix -Wswitch-unreachable warning in bpt_cmds Gustavo A. R. Silva
2022-09-16 14:42 ` Kees Cook
@ 2022-11-30 9:23 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2022-11-30 9:23 UTC (permalink / raw)
To: Nicholas Piggin, Christophe Leroy, Michael Ellerman,
Gustavo A. R. Silva
Cc: linuxppc-dev, linux-hardening, linux-kernel
On Fri, 16 Sep 2022 15:15:04 +0100, Gustavo A. R. Silva wrote:
> When building with automatic stack variable initialization, GCC 12
> complains about variables defined outside of switch case statements.
> Move the variable into the case that uses it, which silences the warning:
>
> arch/powerpc/xmon/xmon.c: In function ‘bpt_cmds’:
> arch/powerpc/xmon/xmon.c:1529:13: warning: statement will never be executed [-Wswitch-unreachable]
> 1529 | int mode;
> | ^~~~
>
> [...]
Applied to powerpc/next.
[1/1] powerpc/xmon: Fix -Wswitch-unreachable warning in bpt_cmds
https://git.kernel.org/powerpc/c/1c4a4a4c8410be4a231a58b23e7a30923ff954ac
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-30 9:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-16 14:15 [PATCH][next] powerpc/xmon: Fix -Wswitch-unreachable warning in bpt_cmds Gustavo A. R. Silva
2022-09-16 14:42 ` Kees Cook
2022-11-30 9:23 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).