From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: kajoljain <kjain@linux.ibm.com>
Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
jolsa@kernel.org, adrian.hunter@intel.com, irogers@google.com,
namhyung@kernel.org, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
maddy@linux.ibm.com, disgoel@linux.vnet.ibm.com,
mpetlan@redhat.com, vmolnaro@redhat.com
Subject: Re: [PATCH V3] tools/perf/tests/shell/base_probe: Enhance print_overall_results to print summary information
Date: Mon, 16 Dec 2024 14:50:57 -0300 [thread overview]
Message-ID: <Z2BogUY4sx8mqrAg@x1> (raw)
In-Reply-To: <32b19139-27f2-4f39-a2ae-25027acc980e@linux.ibm.com>
On Wed, Dec 11, 2024 at 05:33:50PM +0530, kajoljain wrote:
> On 12/6/24 19:22, Athira Rajeev wrote:
> > Here -a and -d doesn't require DWARF. Similarly there
> > are few other tests requiring DWARF. To hint the user that
> > missing dwarf could be one issue, update print_overall_results
> > to print a comment string along with summary hinting the possible
> > cause. Update test_invalid_options.sh and test_line_semantics.sh
> > to pass the info about dwarf requirement since these tests
> > failed when perf is built without DWARF. Use the check for
> > presence of dwarf with "perf check feature" and append the
> > hint message based on the result.
> Patch looks fine to me.
> Reviewed-by: kjain@linux.ibm.com
Thanks, applied to perf-tools-next,
- Arnaldo
prev parent reply other threads:[~2024-12-16 17:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 13:52 [PATCH V3] tools/perf/tests/shell/base_probe: Enhance print_overall_results to print summary information Athira Rajeev
2024-12-11 12:03 ` kajoljain
2024-12-16 17:50 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2BogUY4sx8mqrAg@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=disgoel@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=vmolnaro@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).