From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8ACB1E7718D for ; Mon, 23 Dec 2024 07:12:55 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4YGq3n3dN6z2xBk; Mon, 23 Dec 2024 18:12:53 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2604:1380:4641:c500::1" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1734937973; cv=none; b=mpa0yCyhGgWVa8D0ojbncgwA5TgApEDsPWRM+V+eng7Wu92dLBanRG/oWg9RXJ7C4L32/Q2PVCMnzUE7/iLeynQtmfEAP3sWHJK6c5vBK/Pd/1d3io3lKrjTDXKIZT9Q5uLyt/ojKQwF2Zjr9+KlOnsrv8xSR1YKIwPzFy5IerSf7adyHCQagd18SUTAx5/TaoQs79tbwZVzxoPwE7aB3dpwxu2l8/+s7fl5ZziTr5RBmzua3+tHl7mXAC5l4CHLE8CgJTou+VOcgvHZ4spQpfC7G6kkXo44Hqbzk62NL0FtyuH1/AD52xTXlqHyJ4d9dqgfdCxHCIaioFKBJz6/Aw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1734937973; c=relaxed/relaxed; bh=tpXH6fpTjEphVQKpFxQ2V5QkwIF19GVaeym7wiAED5s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jo2js97ow8jKTWzj1giTJuXes9he1+4ByH6GVu94D9j/VCmhdnQ7q2az1BoWo4Zia8YMFLeo7MXg+p9m3H5BhMfdFZsr2ywXKft+1eCXQeKnSNTbqgcYavtqZrnyqZxKBEqX1KseHyCdvPdHgWVLwlMRSDOQhQRrQOwUgeqBbF4uOAHLkp3uHWCIh/7apsLl8fDa8Ct+PDDB/JbsrAbdfAZDs73CS31oZreL90u4pBXL+fQvWPaq6Dzm2dBES0R3xrZ8+lof/jgiQxzFWJFQuXhtBI67pYdw2fUgAjF5DtbgNWVtFfnBV2l7dqhhs79l44RgDpyOFg2DcaeQswf/CQ== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=PadoaIur; dkim-atps=neutral; spf=pass (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=rppt@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=PadoaIur; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=rppt@kernel.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4YGq3m2mgXz2xBK for ; Mon, 23 Dec 2024 18:12:52 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C64ED5C4A8D; Mon, 23 Dec 2024 07:12:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2221C4CED4; Mon, 23 Dec 2024 07:12:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734937968; bh=KiW6z79yHKtUcMEX/b8/Sp0F2L3XtvvNObnoy9wnwCI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PadoaIur+Bq/ska4dZ3htQaJQz4uazLSVowJVHucSNC53reVkWxd5YVJWY/8jYQei G/2ikWxztSp4IduffOwXB0a3mVJH23t9Ex7EGVUz/CnbNl3iJwZRxMrSqxsyp7jx0f g/t903ItkhiEVo2DrupFM7faoTX7/DPcXhBh/bkr20Ay+uNKYZumDkMyBSpawM5raK Ut+5vnDGc2C1sPQD75jm/n63pJiamwi58eI2wR3M3lVdk6xTR5vMn3Ur4QTOlkun8B BK41Buv9qow1NTThvM4tSiBT0cMpdhUu2SLkRibN1ROgpuegs2ZYg313l0II/8FbH3 cxXTeCHYfJOYg== Date: Mon, 23 Dec 2024 09:12:14 +0200 From: Mike Rapoport To: Guo Weikang Cc: Andrew Morton , Geert Uytterhoeven , Dennis Zhou , Tejun Heo , Christoph Lameter , Thomas Bogendoerfer , Sam Creasey , Huacai Chen , Will Deacon , Catalin Marinas , Oreoluwa Babatunde , rafael.j.wysocki@intel.com, Palmer Dabbelt , Hanjun Guo , Easwar Hariharan , Johannes Berg , Ingo Molnar , Dave Hansen , Christian Brauner , KP Singh , Richard Henderson , Matt Turner , Russell King , WANG Xuerui , Michael Ellerman , Stefan Kristiansson , Stafford Horne , Helge Deller , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Geoff Levand , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, kasan-dev@googlegroups.com, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, Xi Ruoyao Subject: Re: [PATCH v7] mm/memblock: Add memblock_alloc_or_panic interface Message-ID: References: <20241222111537.2720303-1-guoweikang.kernel@gmail.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241222111537.2720303-1-guoweikang.kernel@gmail.com> On Sun, Dec 22, 2024 at 07:15:37PM +0800, Guo Weikang wrote: > Before SLUB initialization, various subsystems used memblock_alloc to > allocate memory. In most cases, when memory allocation fails, an immediate > panic is required. To simplify this behavior and reduce repetitive checks, > introduce `memblock_alloc_or_panic`. This function ensures that memory > allocation failures result in a panic automatically, improving code > readability and consistency across subsystems that require this behavior. > > Changelog: > ---------- > v1: initial version > v2: add __memblock_alloc_or_panic support panic output caller > v3: panic output phys_addr_t use printk's %pap > v4: make __memblock_alloc_or_panic out-of-line, move to memblock.c > v6: Fix CI compile error > Links to CI: https://lore.kernel.org/oe-kbuild-all/202412221000.r1NzXJUO-lkp@intel.com/ > v6: Fix CI compile warinigs > Links to CI: https://lore.kernel.org/oe-kbuild-all/202412221259.JuGNAUCq-lkp@intel.com/ > v7: add chagelog and adjust function declaration alignment format > ---------- > > Signed-off-by: Guo Weikang > Reviewed-by: Andrew Morton > Reviewed-by: Geert Uytterhoeven > Reviewed-by: Mike Rapoport (Microsoft) > Acked-by: Xi Ruoyao If people commented on your patch it does not mean you should add Reviewed-by or Acked-by tags for them. Wait for explicit tags from the reviewers. And don't respin that often, "Reviewers are busy people and may not get to your patch right away" [1]. [1] https://docs.kernel.org/process/submitting-patches.html -- Sincerely yours, Mike.