From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0B89E77197 for ; Thu, 9 Jan 2025 08:23:15 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4YTHq62DKtz2yN3; Thu, 9 Jan 2025 19:23:14 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2607:7c80:54:3::133" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1736410994; cv=none; b=BgI2e+DM7TFOx6kVNyRSEPOBCemO/dSDEWgy+zljUx1akwi4oAF3CPsrtUTi2QzVoJYD+QvOvyemOZXFJj45AeGQC+g52OJhsBjxFSlXYXZQSZplPC95BCWXocGXoyu9ubVAsTWfaoJ3r5dA5rCzFYG3z7OG5FYEjErgdYydvQtMeqaWRBB5wVknzaSSIpBhPqefSezEnU4ZtkgQmdpQ3OpIU22MsTnVyfMmJhYsLe3V+viVG1n/l70sNyZ5rBmVZenVL1efWRIzILkkEKumO2WbfQQmSMdPjdnQjyVxmWK6aRg5acWvrqHwu3ZSJYd+BnN3aSXkdGi9JLdP5wk41Q== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1736410994; c=relaxed/relaxed; bh=Y+Vh7rfq/7OoaD/IsISKN4B/bJgLMs6nBckWnFw2QEY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ux65EV/a/Y1WwzLjN6aDKtaBYPRxSXqzKMDrXAkdMrt1v7zAt0EHLmRavg/k0SMUw9Cq1BbGNqHmIhYEI7y615VLW29tm4mBcUbtmzSYYUu2Gta3huyJRsfMGQXHW2+M4zeRZ7HQslAnaZh6vIOtPFhQwWQMK5ICSYeR+VoijECkyGnfiNIV+CDN+zz2EMn1SpuzoUC4EUB5v3VP2VVkO9sX3G2yG8CPTds3pSCgG8pRCuQkw/712kHq3xNfSsXuamGrsq7DPc3OyJmXwO7tshNa+ykG7Dt/duMGr/RRBe4KFRSCQoYXSpgWvFstJJ/ibzPc/ugSzT98rVY0VZh20g== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=infradead.org; dkim=pass (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=wwTNL5o2; dkim-atps=neutral; spf=none (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=batv+2e5c2b0d924108c2b4cb+7809+infradead.org+hch@bombadil.srs.infradead.org; receiver=lists.ozlabs.org) smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=wwTNL5o2; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=bombadil.srs.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=batv+2e5c2b0d924108c2b4cb+7809+infradead.org+hch@bombadil.srs.infradead.org; receiver=lists.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4YTHq41hmVz2yFD for ; Thu, 9 Jan 2025 19:23:10 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Y+Vh7rfq/7OoaD/IsISKN4B/bJgLMs6nBckWnFw2QEY=; b=wwTNL5o2PrJNFVNsz/xKhWJmSM ZDxd+ffCCbK0fUJEEGHCLabsv2VV0dOLB+IdTzr4+LJfTi5QvYgwKcWlAz/keEGERfaPYuLzj3dyO a5/N5TPgpmRAAF2CutF/IpXUqTXHjmRnEH6w7jM+XHG6yQpHaAG/KaOde8ZCUDAI5BjqwYpdBA/Vu ZMXdBowhIu4gc2MuBwS165ER8BGQX19a3bh8g4TK9TfvOHbNmwNK4s6KcW9zI5/2mu/jfiP7CXg05 VfF02b1KVHBIqL9w5SY1spNsk2dXG+BY5EOKGjqVGjUIR5rXkFZuwP4YZlD0HEhGzWAfc1eeHQrt4 vdo0i/iw==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tVnoj-0000000BAUc-1uqF; Thu, 09 Jan 2025 08:23:01 +0000 Date: Thu, 9 Jan 2025 00:23:01 -0800 From: Christoph Hellwig To: Greg Kroah-Hartman Cc: Christoph Hellwig , Alexei Starovoitov , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , "Rafael J. Wysocki" , Luis Chamberlain , Petr Pavlu , Sami Tolvanen , Daniel Gomez , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , ppc-dev , LKML , linux-modules@vger.kernel.org, bpf Subject: Re: [PATCH v2 0/3] sysfs: constify bin_attribute argument of sysfs_bin_attr_simple_read() Message-ID: References: <20241228-sysfs-const-bin_attr-simple-v2-0-7c6f3f1767a3@weissschuh.net> <0cbfd352-ee3b-4670-afae-8e56d888e8c3@t-8ch.de> <2025010914-gangly-trodden-aa96@gregkh> <2025010930-resurrect-attest-94c9@gregkh> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2025010930-resurrect-attest-94c9@gregkh> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Thu, Jan 09, 2025 at 09:12:03AM +0100, Greg Kroah-Hartman wrote: > > Hey, when I duplicated the method to convert sysfs over to a proper > > seq_file based approach that avoids buffer overflows you basically > > came up with the same line that Alexei had here. > > I did? Sorry about that, I don't remember that. It's been a while.. > As for seq_file for sysfs, is that for binary attributes only, or for > all? I can't recall that at all. Non-binary ones.