* [PATCH] kbuild: Add missing $(objtree) prefix to powerpc crtsavres.o artifact
@ 2025-01-27 18:47 Kienan Stewart
2025-01-28 15:53 ` Kienan Stewart
0 siblings, 1 reply; 4+ messages in thread
From: Kienan Stewart @ 2025-01-27 18:47 UTC (permalink / raw)
To: Madhavan Srinivasan, Michael Ellerman, Nicholas Piggin,
Christophe Leroy, Naveen N Rao
Cc: linuxppc-dev, linux-kernel, Kienan Stewart
In the upstream commit 214c0eea43b2ea66bcd6467ea57e47ce8874191b
("kbuild: add $(objtree)/ prefix to some in-kernel build artifacts")
artifacts required for building out-of-tree kernel modules had
$(objtree) prepended to them to prepare for building in other
directories.
When building external modules for powerpc,
arch/powerpc/lib/crtsavres.o is required for certain
configurations. This artifact is missing the prepended $(objtree).
External modules may work around this omission for v6.13 by setting MO=$KDIR.
Signed-off-by: Kienan Stewart <kstewart@efficios.com>
---
arch/powerpc/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
index f3804103c56ccfdb16289468397ccaea71bf721e..9933b98df69d7f7b9aaf33d36155cc61ab4460c7 100644
--- a/arch/powerpc/Makefile
+++ b/arch/powerpc/Makefile
@@ -58,7 +58,7 @@ ifeq ($(CONFIG_PPC64)$(CONFIG_LD_IS_BFD),yy)
# There is a corresponding test in arch/powerpc/lib/Makefile
KBUILD_LDFLAGS_MODULE += --save-restore-funcs
else
-KBUILD_LDFLAGS_MODULE += arch/powerpc/lib/crtsavres.o
+KBUILD_LDFLAGS_MODULE += $(objtree)/arch/powerpc/lib/crtsavres.o
endif
ifdef CONFIG_CPU_LITTLE_ENDIAN
---
base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04
change-id: 20250127-buildfix-extmod-powerpc-a744e1331f83
Best regards,
--
Kienan Stewart <kstewart@efficios.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] kbuild: Add missing $(objtree) prefix to powerpc crtsavres.o artifact
2025-01-27 18:47 [PATCH] kbuild: Add missing $(objtree) prefix to powerpc crtsavres.o artifact Kienan Stewart
@ 2025-01-28 15:53 ` Kienan Stewart
2025-01-29 10:12 ` Nicolas Schier
2025-01-29 23:52 ` Masahiro Yamada
0 siblings, 2 replies; 4+ messages in thread
From: Kienan Stewart @ 2025-01-28 15:53 UTC (permalink / raw)
To: Madhavan Srinivasan, Michael Ellerman, Nicholas Piggin,
Christophe Leroy, Naveen N Rao, Masahiro Yamada, Nicolas Schier,
Nathan Chancellor
Cc: linuxppc-dev, linux-kernel, linux-kbuild
Hi,
I missed a few CCs, looping them in now. Apologies for the extra noise.
thanks,
kienan
On 1/27/25 1:47 PM, Kienan Stewart wrote:
> In the upstream commit 214c0eea43b2ea66bcd6467ea57e47ce8874191b
> ("kbuild: add $(objtree)/ prefix to some in-kernel build artifacts")
> artifacts required for building out-of-tree kernel modules had
> $(objtree) prepended to them to prepare for building in other
> directories.
>
> When building external modules for powerpc,
> arch/powerpc/lib/crtsavres.o is required for certain
> configurations. This artifact is missing the prepended $(objtree).
>
> External modules may work around this omission for v6.13 by setting MO=$KDIR.
>
> Signed-off-by: Kienan Stewart <kstewart@efficios.com>
> ---
> arch/powerpc/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
> index f3804103c56ccfdb16289468397ccaea71bf721e..9933b98df69d7f7b9aaf33d36155cc61ab4460c7 100644
> --- a/arch/powerpc/Makefile
> +++ b/arch/powerpc/Makefile
> @@ -58,7 +58,7 @@ ifeq ($(CONFIG_PPC64)$(CONFIG_LD_IS_BFD),yy)
> # There is a corresponding test in arch/powerpc/lib/Makefile
> KBUILD_LDFLAGS_MODULE += --save-restore-funcs
> else
> -KBUILD_LDFLAGS_MODULE += arch/powerpc/lib/crtsavres.o
> +KBUILD_LDFLAGS_MODULE += $(objtree)/arch/powerpc/lib/crtsavres.o
> endif
>
> ifdef CONFIG_CPU_LITTLE_ENDIAN
>
> ---
> base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04
> change-id: 20250127-buildfix-extmod-powerpc-a744e1331f83
>
> Best regards,
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] kbuild: Add missing $(objtree) prefix to powerpc crtsavres.o artifact
2025-01-28 15:53 ` Kienan Stewart
@ 2025-01-29 10:12 ` Nicolas Schier
2025-01-29 23:52 ` Masahiro Yamada
1 sibling, 0 replies; 4+ messages in thread
From: Nicolas Schier @ 2025-01-29 10:12 UTC (permalink / raw)
To: Kienan Stewart
Cc: Madhavan Srinivasan, Michael Ellerman, Nicholas Piggin,
Christophe Leroy, Naveen N Rao, Masahiro Yamada, Nicolas Schier,
Nathan Chancellor, linuxppc-dev, linux-kernel, linux-kbuild,
n.schier
On Tue 28 Jan 2025 10:53:42 GMT, Kienan Stewart wrote:
> Hi,
>
> I missed a few CCs, looping them in now. Apologies for the extra noise.
>
> thanks,
> kienan
>
> On 1/27/25 1:47 PM, Kienan Stewart wrote:
> > In the upstream commit 214c0eea43b2ea66bcd6467ea57e47ce8874191b
> > ("kbuild: add $(objtree)/ prefix to some in-kernel build artifacts")
> > artifacts required for building out-of-tree kernel modules had
> > $(objtree) prepended to them to prepare for building in other
> > directories.
> >
> > When building external modules for powerpc,
> > arch/powerpc/lib/crtsavres.o is required for certain
> > configurations. This artifact is missing the prepended $(objtree).
> >
> > External modules may work around this omission for v6.13 by setting MO=$KDIR.
> >
> > Signed-off-by: Kienan Stewart <kstewart@efficios.com>
> > ---
> > arch/powerpc/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
> > index f3804103c56ccfdb16289468397ccaea71bf721e..9933b98df69d7f7b9aaf33d36155cc61ab4460c7 100644
> > --- a/arch/powerpc/Makefile
> > +++ b/arch/powerpc/Makefile
> > @@ -58,7 +58,7 @@ ifeq ($(CONFIG_PPC64)$(CONFIG_LD_IS_BFD),yy)
> > # There is a corresponding test in arch/powerpc/lib/Makefile
> > KBUILD_LDFLAGS_MODULE += --save-restore-funcs
> > else
> > -KBUILD_LDFLAGS_MODULE += arch/powerpc/lib/crtsavres.o
> > +KBUILD_LDFLAGS_MODULE += $(objtree)/arch/powerpc/lib/crtsavres.o
> > endif
> > ifdef CONFIG_CPU_LITTLE_ENDIAN
> >
> > ---
> > base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04
> > change-id: 20250127-buildfix-extmod-powerpc-a744e1331f83
Thanks!
Reviewed-by: Nicolas Schier <n.schier@avm.de>
Tested-by: Nicolas Schier <n.schier@avm.de>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] kbuild: Add missing $(objtree) prefix to powerpc crtsavres.o artifact
2025-01-28 15:53 ` Kienan Stewart
2025-01-29 10:12 ` Nicolas Schier
@ 2025-01-29 23:52 ` Masahiro Yamada
1 sibling, 0 replies; 4+ messages in thread
From: Masahiro Yamada @ 2025-01-29 23:52 UTC (permalink / raw)
To: Kienan Stewart
Cc: Madhavan Srinivasan, Michael Ellerman, Nicholas Piggin,
Christophe Leroy, Naveen N Rao, Nicolas Schier, Nathan Chancellor,
linuxppc-dev, linux-kernel, linux-kbuild
On Wed, Jan 29, 2025 at 12:53 AM Kienan Stewart <kstewart@efficios.com> wrote:
>
> Hi,
>
> I missed a few CCs, looping them in now. Apologies for the extra noise.
>
> thanks,
> kienan
>
> On 1/27/25 1:47 PM, Kienan Stewart wrote:
> > In the upstream commit 214c0eea43b2ea66bcd6467ea57e47ce8874191b
> > ("kbuild: add $(objtree)/ prefix to some in-kernel build artifacts")
> > artifacts required for building out-of-tree kernel modules had
> > $(objtree) prepended to them to prepare for building in other
> > directories.
> >
> > When building external modules for powerpc,
> > arch/powerpc/lib/crtsavres.o is required for certain
> > configurations. This artifact is missing the prepended $(objtree).
> >
> > External modules may work around this omission for v6.13 by setting MO=$KDIR.
> >
> > Signed-off-by: Kienan Stewart <kstewart@efficios.com>
Good catch, this actually got broken by 13b25489b6f8.
Fixes: 13b25489b6f8 ("kbuild: change working directory to external
module directory with M=")
Acked-by: Masahiro Yamada <masahiroy@kernel.org>
> > ---
> > arch/powerpc/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
> > index f3804103c56ccfdb16289468397ccaea71bf721e..9933b98df69d7f7b9aaf33d36155cc61ab4460c7 100644
> > --- a/arch/powerpc/Makefile
> > +++ b/arch/powerpc/Makefile
> > @@ -58,7 +58,7 @@ ifeq ($(CONFIG_PPC64)$(CONFIG_LD_IS_BFD),yy)
> > # There is a corresponding test in arch/powerpc/lib/Makefile
> > KBUILD_LDFLAGS_MODULE += --save-restore-funcs
> > else
> > -KBUILD_LDFLAGS_MODULE += arch/powerpc/lib/crtsavres.o
> > +KBUILD_LDFLAGS_MODULE += $(objtree)/arch/powerpc/lib/crtsavres.o
> > endif
> >
> > ifdef CONFIG_CPU_LITTLE_ENDIAN
> >
> > ---
> > base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04
> > change-id: 20250127-buildfix-extmod-powerpc-a744e1331f83
> >
> > Best regards,
>
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-01-29 23:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-27 18:47 [PATCH] kbuild: Add missing $(objtree) prefix to powerpc crtsavres.o artifact Kienan Stewart
2025-01-28 15:53 ` Kienan Stewart
2025-01-29 10:12 ` Nicolas Schier
2025-01-29 23:52 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).