From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C4F9C19F32 for ; Wed, 5 Mar 2025 11:07:36 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Z78sM4Plzz3btY; Wed, 5 Mar 2025 22:07:35 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1741170700; cv=none; b=HYMHdptcPOPZWP+2U3UL9S0LGP6OR2vlgDU27lyNv8rQCLK8au3tiTbVpMnT1bQ882Kzd/4FuqjTsdRXWE9HCvpicMrJ03ltPLkfRUiKcY9cyiila5IQaOD9mEhdUDOBVT8bSYntnAC/cU/mdm1sTDbS+UamP3dKBNWozlSBaB6okkSI0nSJC7NNlytA9d0OFB0G42353AIiETW+PVcLHvWXLFl1NJGjmSU681GXf2THxtTOAcdNHhP4wAzDVh1/78kqSTMb51Dw4ncRsfRDVf2TUPie83cFzngHuZlcHDUJQyRvXXBOI8hMCcpSsgu3of8BzQFI8OvZVAgbI2HQ+Q== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1741170700; c=relaxed/relaxed; bh=GixKrI4auj+Jq2I/e3aa9PpIqnSOeuqb6Z1Wgla2k/g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DaVvrex9Tn3e5HIsxEDMCLkxljDdLlC3g8x9hHt/YVBdTFBk75VM9s1ZNqTyxLGD8X2Z4m+MupkkpqMiaUjn25KnWT8ptMAtX1PsmdhTrRyA6ZTXiudAe6P4hfjQRdXJnLZRmDbqthtDrRTipwB/cij9zKriC6DFJESBs51fA/QyDu1/6NfX2QtenEPsd1Y1siDHjk1o4O3OZkJtbORbCsz7vC4OJ4bEZC2OvTPBXTFyRTt52hkFP5cHq1e1vFSMg9YX/DJDxux4XrLCtf69OgE+UVCfwADrZ4Msr3zr1V/7BCnKdoDFrWDLVgP4FOJgIjeEIOuqEiOkOQBN508ajg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=softfail (client-ip=198.175.65.12; helo=mgamail.intel.com; envelope-from=andy@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; spf=softfail (domain owner discourages use of this host) smtp.mailfrom=kernel.org (client-ip=198.175.65.12; helo=mgamail.intel.com; envelope-from=andy@kernel.org; receiver=lists.ozlabs.org) X-Greylist: delayed 60 seconds by postgrey-1.37 at boromir; Wed, 05 Mar 2025 21:31:39 AEDT Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Z783v3q5Qz3bmL; Wed, 5 Mar 2025 21:31:39 +1100 (AEDT) X-CSE-ConnectionGUID: CuF/STzHTe235GLxsgy8HA== X-CSE-MsgGUID: ec4BYwgfTf2ui7/ZKqvVjQ== X-IronPort-AV: E=McAfee;i="6700,10204,11363"; a="53523079" X-IronPort-AV: E=Sophos;i="6.14,222,1736841600"; d="scan'208";a="53523079" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2025 02:31:38 -0800 X-CSE-ConnectionGUID: Z/A8xlFITVmp8Z0twxO01Q== X-CSE-MsgGUID: nLVWQ8vMT/elxbz01T8mpA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,222,1736841600"; d="scan'208";a="149420928" Received: from smile.fi.intel.com ([10.237.72.58]) by orviesa002.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2025 02:31:28 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1tpm27-0000000HNqe-12WE; Wed, 05 Mar 2025 12:31:23 +0200 Date: Wed, 5 Mar 2025 12:31:22 +0200 From: Andy Shevchenko To: George Cherian Cc: linux@roeck-us.net, wim@linux-watchdog.org, jwerner@chromium.org, evanbenn@chromium.org, kabel@kernel.org, krzk@kernel.org, mazziesaccount@gmail.com, thomas.richard@bootlin.com, lma@chromium.org, bleung@chromium.org, support.opensource@diasemi.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, paul@crapouillou.net, alexander.usyskin@intel.com, andreas.werner@men.de, daniel@thingy.jp, romain.perier@gmail.com, avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, naveen@kernel.org, mwalle@kernel.org, xingyu.wu@starfivetech.com, ziv.xu@starfivetech.com, hayashi.kunihiko@socionext.com, mhiramat@kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-mips@vger.kernel.org, openbmc@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org, patches@opensource.cirrus.com Subject: Re: [PATCH v4 0/2] Add stop_on_panic support for watchdog Message-ID: References: <20250305101025.2279951-1-george.cherian@marvell.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250305101025.2279951-1-george.cherian@marvell.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Mar 05, 2025 at 10:10:23AM +0000, George Cherian wrote: > This series adds a new kernel command line option to watchdog core to > stop the watchdog on panic. This is useul in certain systems which prevents > successful loading of kdump kernel due to watchdog reset. > > Some of the watchdog drivers stop function could sleep. For such > drivers the stop_on_panic is not valid as the notifier callback happens > in atomic context. Introduce WDIOF_STOP_MAYSLEEP flag to watchdog_info > options to indicate whether the stop function would sleep. Should you only enable this if the kdump is enabled in the kernel configuration? -- With Best Regards, Andy Shevchenko