linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>,
	Julia Lawall <julia.lawall@inria.fr>,
	Takashi Iwai <tiwai@suse.de>
Cc: "Latchesar Ionkov" <lucho@ionkov.net>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Darrick J. Wong" <djwong@kernel.org>,
	"Anders Larsen" <al@alarsen.net>,
	"Carlos Llamas" <cmllamas@google.com>,
	"Hugh Dickins" <hughd@google.com>,
	"John Johansen" <john.johansen@canonical.com>,
	"Seth Forshee" <sforshee@digitalocean.com>,
	"Alexander Gordeev" <agordeev@linux.ibm.com>,
	"Christoph Hellwig" <hch@lst.de>,
	"Mike Marshall" <hubcap@omnibond.com>,
	"Paulo Alcantara" <pc@manguebit.com>,
	linux-xfs@vger.kernel.org, "Bart Van Assche" <bvanassche@acm.org>,
	"John Keeping" <john@keeping.me.uk>,
	"Zhang Yi" <yi.zhang@huawei.com>,
	"James Morris" <jmorris@namei.org>,
	"Tyler Hicks" <code@tyhicks.com>,
	"Alan Stern" <stern@rowland.harvard.edu>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>,
	devel@lists.orangefs.org,
	"Shyam Prasad N" <sprasad@microsoft.com>,
	"Jan Harkes" <jaharkes@cs.cmu.edu>,
	linux-um@lists.infradead.org,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Alexander Viro" <viro@zeniv.linux.org.uk>,
	"Eric Van Hensbergen" <ericvh@kernel.org>,
	"Suren Baghdasaryan" <surenb@google.com>,
	"Trond Myklebust" <trond.myklebust@hammerspace.com>,
	"Anton Altaparmakov" <anton@tuxera.com>,
	"Christian Brauner" <brauner@kernel.org>,
	"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Stephen Smalley" <stephen.smalley.work@gmail.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Ronnie Sahlberg" <lsahlber@redhat.com>,
	"Sergey Senozhatsky" <senozhatsky@chromium.org>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Chuck Lever" <chuck.lever@oracle.com>,
	"Sven Schnelle" <svens@linux.ibm.com>,
	"Jiri Olsa" <jolsa@kernel.org>, "Jan Kara" <jack@suse.com>,
	"Tejun Heo" <tj@kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	linux-trace-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org,
	"Dave Kleikamp" <shaggy@kernel.org>,
	"Sandeep Dhavale" <dhavale@google.com>,
	"Tetsuo Handa" <penguin-kernel@i-love.sakura.ne.jp>,
	samba-technical@lists.samba.org,
	"Mimi Zohar" <zohar@linux.ibm.com>,
	linux-mm@kvack.org, "Joel Fernandes" <joel@joelfernandes.org>,
	"Eric Dumazet" <edumazet@google.com>,
	"Stanislav Fomichev" <sdf@google.com>,
	"Andrzej Pietrasiewicz" <andrzej.p@collabora.com>,
	"Hangyu Hua" <hbh25y@gmail.com>,
	linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
	"Paul Moore" <paul@paul-moore.com>,
	"Leon Romanovsky" <leon@kernel.org>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"Andrii Nakryiko" <andrii@kernel.org>,
	"Minghao Chi" <chi.minghao@zte.com.cn>,
	codalist@coda.cs.cmu.edu, selinux@vger.kernel.org,
	ZhangPeng <zhangpeng362@huawei.com>,
	"Udipto Goswami" <quic_ugoswami@quicinc.com>,
	"Yonghong Song" <yhs@fb.com>, "Iurii Zaikin" <yzaikin@google.com>,
	"Namjae Jeon" <linkinjeon@kernel.org>,
	"Masami Hiramatsu" <mhiramat@kernel.org>,
	ecryptfs@vger.kernel.org, "Todd Kjos" <tkjos@android.com>,
	"Vasily Gorbik" <gor@linux.ibm.com>,
	"Yu Zhe" <yuzhe@nfschina.com>,
	linuxppc-dev@lists.ozlabs.org, reiserfs-devel@vger.kernel.org,
	"Miklos Szeredi" <miklos@szeredi.hu>,
	"Yue Hu" <huyue2@coolpad.com>, "Jaegeuk Kim" <jaegeuk@kernel.org>,
	"Adit ya Garg" <gargaditya08@live.com>,
	"Martijn Coenen" <maco@android.com>,
	"OGAWA Hirofumi" <hirofumi@mail.parknet.co.jp>,
	"Hao Luo" <haoluo@google.com>, "Tony Luck" <tony.luck@intel.com>,
	"Theodore Ts'o" <tytso@mit.edu>,
	"Nicolas Pitre" <nico@fluxnic.net>,
	linux-ntfs-dev@lists.sourceforge.net,
	"Muchun Song" <muchun.song@linux.dev>,
	"Roberto Sassu" <roberto.sassu@huawei.com>,
	linux-f2fs-devel@lists.sourceforge.net,
	"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
	"Jozef Martiniak" <jomajm@gmail.com>,
	"Eric Biederman" <ebiederm@xmission.com>,
	"Anna Schumaker" <anna@kernel.org>, "xu xin" <cgel.zte@gmail.com>,
	"Brad Warrum" <bwarrum@linux.ibm.com>,
	"Mike Kravetz" <mike.kravetz@oracle.com>,
	"Jingyu Wang" <jingyuwang_vip@163.com>,
	linux-efi@vger.kernel.org, "Dan Carpenter" <error27@gmail.com>,
	"Martin Brandenburg" <martin@omnibond.com>,
	"Tom Rix" <trix@redhat.com>,
	"Alexei Starovoitov" <ast@kernel.org>, "Chris Mason" <clm@fb.com>,
	linux-mtd@lists.infradead.org,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>
Subject: Re: [PATCH 00/79] fs: new accessors for inode->i_ctime
Date: Fri, 30 Jun 2023 15:11:42 -0700	[thread overview]
Message-ID: <ZJ9THiUlOUmm0xpD@bombadil.infradead.org> (raw)
In-Reply-To: <20230621152141.5961cf5f@gandalf.local.home>

On Wed, Jun 21, 2023 at 03:21:41PM -0400, Steven Rostedt wrote:
> On Wed, 21 Jun 2023 10:45:05 -0400
> Jeff Layton <jlayton@kernel.org> wrote:
> 
> > Most of this conversion was done via coccinelle, with a few of the more
> > non-standard accesses done by hand. There should be no behavioral
> > changes with this set. That will come later, as we convert individual
> > filesystems to use multigrain timestamps.
> 
> BTW, Linus has suggested to me that whenever a conccinelle script is used,
> it should be included in the change log.

Sometimes people like the coccinelle included in the commit, sometimes
people don't [0], it really ends up being up to a subjective maintainer
preference. A compromise could be to use git notes as these are
optional, however if we want to go down that path we should try to make
a general consensus on it so we can send a consistent message.

[0] https://lore.kernel.org/all/20230512073100.GC32559@twin.jikos.cz/

  Luis

      parent reply	other threads:[~2023-07-01  3:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21 14:45 [PATCH 00/79] fs: new accessors for inode->i_ctime Jeff Layton
2023-06-21 14:45 ` [PATCH 01/79] fs: add ctime accessors infrastructure Jeff Layton
2023-06-21 16:34   ` Jan Kara
2023-06-21 17:29   ` Tom Talpey
2023-06-21 18:01     ` Jeff Layton
2023-06-21 18:19       ` Tom Talpey
2023-06-21 18:48         ` Jeff Layton
2023-06-22  0:46   ` Damien Le Moal
2023-06-22 10:14     ` Jeff Layton
2023-06-30 22:12   ` Luis Chamberlain
2023-07-12 15:31   ` Randy Dunlap
2023-06-21 14:45 ` [PATCH 02/79] spufs: switch to new ctime accessors Jeff Layton
2023-06-21 16:34   ` Jan Kara
2023-06-22  0:19   ` Jeremy Kerr
2023-06-21 14:49 ` [PATCH 79/79] fs: rename i_ctime field to __i_ctime Jeff Layton
2023-06-21 19:21 ` [PATCH 00/79] fs: new accessors for inode->i_ctime Steven Rostedt
2023-06-21 19:52   ` Jeff Layton
2023-06-23 12:41     ` Christian Brauner
2023-06-30 22:11   ` Luis Chamberlain [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZJ9THiUlOUmm0xpD@bombadil.infradead.org \
    --to=mcgrof@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=al@alarsen.net \
    --cc=andrii@kernel.org \
    --cc=andrzej.p@collabora.com \
    --cc=anna@kernel.org \
    --cc=anton@tuxera.com \
    --cc=arve@android.com \
    --cc=ast@kernel.org \
    --cc=borntraeger@linux.ibm.com \
    --cc=brauner@kernel.org \
    --cc=bvanassche@acm.org \
    --cc=bwarrum@linux.ibm.com \
    --cc=cgel.zte@gmail.com \
    --cc=chi.minghao@zte.com.cn \
    --cc=chuck.lever@oracle.com \
    --cc=clm@fb.com \
    --cc=cmllamas@google.com \
    --cc=codalist@coda.cs.cmu.edu \
    --cc=code@tyhicks.com \
    --cc=devel@lists.orangefs.org \
    --cc=dhavale@google.com \
    --cc=djwong@kernel.org \
    --cc=ebiederm@xmission.com \
    --cc=ecryptfs@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=ericvh@kernel.org \
    --cc=error27@gmail.com \
    --cc=gargaditya08@live.com \
    --cc=gor@linux.ibm.com \
    --cc=gpiccoli@igalia.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=haoluo@google.com \
    --cc=hbh25y@gmail.com \
    --cc=hch@lst.de \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=hubcap@omnibond.com \
    --cc=hughd@google.com \
    --cc=huyue2@coolpad.com \
    --cc=jack@suse.com \
    --cc=jaegeuk@kernel.org \
    --cc=jaharkes@cs.cmu.edu \
    --cc=jingyuwang_vip@163.com \
    --cc=jmorris@namei.org \
    --cc=joel@joelfernandes.org \
    --cc=john.fastabend@gmail.com \
    --cc=john.johansen@canonical.com \
    --cc=john@keeping.me.uk \
    --cc=jolsa@kernel.org \
    --cc=jomajm@gmail.com \
    --cc=julia.lawall@inria.fr \
    --cc=leon@kernel.org \
    --cc=linkinjeon@kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-nilfs@vger.kernel.org \
    --cc=linux-ntfs-dev@lists.sourceforge.net \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lsahlber@redhat.com \
    --cc=lucho@ionkov.net \
    --cc=maco@android.com \
    --cc=martin@omnibond.com \
    --cc=mhiramat@kernel.org \
    --cc=mike.kravetz@oracle.com \
    --cc=miklos@szeredi.hu \
    --cc=muchun.song@linux.dev \
    --cc=nico@fluxnic.net \
    --cc=npiggin@gmail.com \
    --cc=paul@paul-moore.com \
    --cc=pc@manguebit.com \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=quic_ugoswami@quicinc.com \
    --cc=rafael@kernel.org \
    --cc=reiserfs-devel@vger.kernel.org \
    --cc=roberto.sassu@huawei.com \
    --cc=rostedt@goodmis.org \
    --cc=samba-technical@lists.samba.org \
    --cc=sdf@google.com \
    --cc=selinux@vger.kernel.org \
    --cc=senozhatsky@chromium.org \
    --cc=sforshee@digitalocean.com \
    --cc=shaggy@kernel.org \
    --cc=sprasad@microsoft.com \
    --cc=stephen.smalley.work@gmail.com \
    --cc=stern@rowland.harvard.edu \
    --cc=surenb@google.com \
    --cc=svens@linux.ibm.com \
    --cc=tiwai@suse.de \
    --cc=tj@kernel.org \
    --cc=tkjos@android.com \
    --cc=tony.luck@intel.com \
    --cc=trix@redhat.com \
    --cc=trond.myklebust@hammerspace.com \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=yhs@fb.com \
    --cc=yi.zhang@huawei.com \
    --cc=yuzhe@nfschina.com \
    --cc=yzaikin@google.com \
    --cc=zhangpeng362@huawei.com \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).