From: Frank Li <Frank.li@nxp.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: "Rob Herring" <robh@kernel.org>,
imx@lists.linux.dev, "Xiaowei Bao" <xiaowei.bao@nxp.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
linux-pci@vger.kernel.org, "Hou Zhiqiang" <Zhiqiang.Hou@nxp.com>,
"Manivannan Sadhasivam" <mani@kernel.org>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
"Minghuan Lian" <minghuan.Lian@nxp.com>,
"Mingkai Hu" <mingkai.hu@nxp.com>, "Roy Zang" <roy.zang@nxp.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linuxppc-dev@lists.ozlabs.org,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [v3 1/2] PCI: layerscape: Add support for Link down notification
Date: Wed, 19 Jul 2023 17:14:52 -0400 [thread overview]
Message-ID: <ZLhSTH6M3XWgxMFy@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <065b12d7-d46f-adf9-e806-40802fe888cf@web.de>
On Wed, Jul 19, 2023 at 10:08:16PM +0200, Markus Elfring wrote:
> > Cover letter just annoise people here.
>
> How do you think about advices from another information source?
>
> See also:
> https://kernelnewbies.org/PatchSeries
"You may like to include a cover letter with your patch series."
Generally, I think cover letter will be needed only if it really
help reviewer to get main idea about patches.
Such as my on going pathes(with cover letter):
https://lore.kernel.org/imx/ZLglBiSz0meJm5os@lizhi-Precision-Tower-5810/T/#t
Similar case without(cover leter) and accepted.
https://lore.kernel.org/imx/20230719063425.GE151430@dragon/T/#t
I don't think cover letter real help reviewer to review these two patches.
I more like to get "real problem"(such as comments about "typo").
It is just waste time to discuss if need add cover letter here.
Frank
>
> Regards,
> Markus
prev parent reply other threads:[~2023-07-19 21:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 15:57 [PATCH v3 1/2] PCI: layerscape: Add support for Link down notification Frank Li
2023-07-19 15:57 ` [PATCH v3 2/2] PCI: layerscape: Add the workaround for lost link capabilities during reset Frank Li
2023-07-19 22:23 ` Frank Li
2023-07-19 19:27 ` [PATCH v3 1/2] PCI: layerscape: Add support for Link down notification Markus Elfring
2023-07-19 19:44 ` Frank Li
2023-07-19 20:08 ` [v3 " Markus Elfring
2023-07-19 21:14 ` Frank Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLhSTH6M3XWgxMFy@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=Markus.Elfring@web.de \
--cc=Zhiqiang.Hou@nxp.com \
--cc=bhelgaas@google.com \
--cc=imx@lists.linux.dev \
--cc=kernel-janitors@vger.kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=minghuan.Lian@nxp.com \
--cc=mingkai.hu@nxp.com \
--cc=robh@kernel.org \
--cc=roy.zang@nxp.com \
--cc=xiaowei.bao@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).