From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE3BBC001DF for ; Tue, 1 Aug 2023 00:03:46 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=alub0lGp; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RFFh06jKQz3cVT for ; Tue, 1 Aug 2023 10:03:44 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=alub0lGp; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::a2a; helo=mail-vk1-xa2a.google.com; envelope-from=gsomlo@gmail.com; receiver=lists.ozlabs.org) Received: from mail-vk1-xa2a.google.com (mail-vk1-xa2a.google.com [IPv6:2607:f8b0:4864:20::a2a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4RF8Fp4hYYz2ywL for ; Tue, 1 Aug 2023 05:59:08 +1000 (AEST) Received: by mail-vk1-xa2a.google.com with SMTP id 71dfb90a1353d-48645045826so1804408e0c.2 for ; Mon, 31 Jul 2023 12:59:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690833545; x=1691438345; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3ZUTLiq4ztiz7isOwicgVn1yrySYaXh6uY6SY2kyAgc=; b=alub0lGpoNrEu8OhfNnTDBvCPSj1fLLYheu1NSkrdZBpAQF2064AvbHKWmUzslufOt YLbmv/TcCGYjgrvq4FRS6M9Devdql3Q2P/9rAVoRybjgi+kffYQQcVZMV2WEYizsOr2j BpXNHtgVetIAcGNhWkkx03vGGYpzA9ZHMcvgmI3ZOe9kQRjymhlNgRuOilfBt3UBsdLl 7kW4WBonGTFZhUn6/mlIWDl6LSRqENUo0fbkIW9lN3zqVFnZ6fDFQSK0eFG8BS8nJDme CuPuGTgehfNxRLyhKRbEAW+Bg56YyqY+gh0K04pfKLwmKFpNb4K28NQR1KJZ8WogUkSd NjQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690833545; x=1691438345; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3ZUTLiq4ztiz7isOwicgVn1yrySYaXh6uY6SY2kyAgc=; b=jqnlfWOSbieEauDOMG3enAZN3WeGD0OCAUYXisfam4KQHErQIMw8h7IRgff+KM7n41 vZct7RDDqOoZgbVcGadGvExVVkQRc5fJW6wSEc6lV6qGTXugCLXJAh4loL9ifPDlSgaD rZldN650iUvZqKaww/KhtN82q7ni3zwWXunpuoMCMj5yPJ3j4FtMu2tDd+ZtrFh/XwK/ kYCrfKRESrl9QLczSH/ujxxe5RbvDMfEzByI38RU5ajzD2i25KbyLdoT9VXauiOpk7gx tTNkEVcj3z2lkC4QCXlW63Noa9DeX1S/AwlEwGkOoMkCa3fEmoXE8fuazM7F9byjbtK9 dT4w== X-Gm-Message-State: ABy/qLaXXE5bks6Uw16tT4ooCS8imoJ3RH4ugXRwBM6U7GlAKE+4tSvL GGUKxumqJ1n3WmRfg/s3D7w= X-Google-Smtp-Source: APBJJlHSqrneeA6ywQrgc7CJdlArRC0LDzjpwpRAo2sgvPLInS00+l5lLpxZfcAOQnXT689xDRSr7w== X-Received: by 2002:a1f:5fd7:0:b0:47e:1105:1f5e with SMTP id t206-20020a1f5fd7000000b0047e11051f5emr984710vkb.1.1690833544731; Mon, 31 Jul 2023 12:59:04 -0700 (PDT) Received: from errol.ini.cmu.edu ([72.95.245.133]) by smtp.gmail.com with ESMTPSA id g22-20020a0caad6000000b006365b23b5dfsm4046264qvb.23.2023.07.31.12.59.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 12:59:04 -0700 (PDT) Date: Mon, 31 Jul 2023 15:59:01 -0400 From: "Gabriel L. Somlo" To: Rob Herring Subject: Re: [PATCH v2] tty: Explicitly include correct DT includes Message-ID: References: <20230724205440.767071-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230724205440.767071-1-robh@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailman-Approved-At: Tue, 01 Aug 2023 10:02:05 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Mateusz Holenko , Lorenzo Pieralisi , Liviu Dudau , linux-kernel@vger.kernel.org, Paul Cercueil , linux-tegra@vger.kernel.org, Laxman Dewangan , Shan-Chun Hung , Peter Korsgaard , Fabio Estevam , Karol Gugala , sparclinux@vger.kernel.org, Russell King , Jonathan Hunter , Andy Gross , Joel Stanley , linux-serial@vger.kernel.org, linux-mips@vger.kernel.org, NXP Linux Team , Jacky Huang , linux-arm-msm@vger.kernel.org, Sascha Hauer , linuxppc-dev@lists.ozlabs.org, Nicholas Piggin , Jiri Slaby , linux-arm-kernel@lists.infradead.org, Timur Tabi , Richard Genoud , Greg Kroah-Hartman , Bjorn Andersson , Nicolas Ferre , "David S. Miller" , Konrad Dybcio , Thierry Reding , Pengutronix Kernel Team , Sudeep Holla , Shawn Guo , Claudiu Beznea Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Jul 24, 2023 at 02:54:38PM -0600, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring > --- Acked-by: Gabriel Somlo # for liteuart Thanks much, --Gabriel > v2: > - Add mpc52xx_uart > --- > drivers/tty/hvc/hvc_opal.c | 2 +- > drivers/tty/serial/8250/8250_early.c | 1 - > drivers/tty/serial/8250/8250_ingenic.c | 1 - > drivers/tty/serial/8250/8250_omap.c | 1 - > drivers/tty/serial/amba-pl011.c | 2 +- > drivers/tty/serial/apbuart.c | 3 --- > drivers/tty/serial/atmel_serial.c | 1 - > drivers/tty/serial/fsl_linflexuart.c | 2 +- > drivers/tty/serial/fsl_lpuart.c | 2 +- > drivers/tty/serial/imx.c | 1 - > drivers/tty/serial/lantiq.c | 3 ++- > drivers/tty/serial/liteuart.c | 3 +-- > drivers/tty/serial/ma35d1_serial.c | 2 +- > drivers/tty/serial/mpc52xx_uart.c | 2 +- > drivers/tty/serial/mps2-uart.c | 1 - > drivers/tty/serial/mxs-auart.c | 2 +- > drivers/tty/serial/pic32_uart.c | 1 - > drivers/tty/serial/qcom_geni_serial.c | 1 - > drivers/tty/serial/serial-tegra.c | 1 - > drivers/tty/serial/sh-sci.c | 1 - > drivers/tty/serial/sunhv.c | 4 ++-- > drivers/tty/serial/sunsab.c | 3 ++- > drivers/tty/serial/sunsu.c | 4 ++-- > drivers/tty/serial/sunzilog.c | 4 ++-- > drivers/tty/serial/tegra-tcu.c | 1 - > drivers/tty/serial/uartlite.c | 3 --- > drivers/tty/serial/ucc_uart.c | 3 ++- > drivers/tty/serial/vt8500_serial.c | 2 +- > 28 files changed, 21 insertions(+), 36 deletions(-) > > diff --git a/drivers/tty/hvc/hvc_opal.c b/drivers/tty/hvc/hvc_opal.c > index 794c7b18aa06..992e199e0ea8 100644 > --- a/drivers/tty/hvc/hvc_opal.c > +++ b/drivers/tty/hvc/hvc_opal.c > @@ -14,7 +14,7 @@ > #include > #include > #include > -#include > +#include > #include > #include > > diff --git a/drivers/tty/serial/8250/8250_early.c b/drivers/tty/serial/8250/8250_early.c > index 4299a8bd83d9..9837a27739fd 100644 > --- a/drivers/tty/serial/8250/8250_early.c > +++ b/drivers/tty/serial/8250/8250_early.c > @@ -27,7 +27,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/tty/serial/8250/8250_ingenic.c b/drivers/tty/serial/8250/8250_ingenic.c > index 617b8ce60d6b..4c4c4da73ad0 100644 > --- a/drivers/tty/serial/8250/8250_ingenic.c > +++ b/drivers/tty/serial/8250/8250_ingenic.c > @@ -13,7 +13,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c > index d48a82f1634e..26dd089d8e82 100644 > --- a/drivers/tty/serial/8250/8250_omap.c > +++ b/drivers/tty/serial/8250/8250_omap.c > @@ -18,7 +18,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c > index c5c3f4674459..a1e594b79890 100644 > --- a/drivers/tty/serial/amba-pl011.c > +++ b/drivers/tty/serial/amba-pl011.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -36,7 +37,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/tty/serial/apbuart.c b/drivers/tty/serial/apbuart.c > index 915ee4b0d594..f3defc6da3df 100644 > --- a/drivers/tty/serial/apbuart.c > +++ b/drivers/tty/serial/apbuart.c > @@ -22,9 +22,6 @@ > #include > #include > #include > -#include > -#include > -#include > #include > #include > #include > diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c > index 3467a875641a..7ac477344aa3 100644 > --- a/drivers/tty/serial/atmel_serial.c > +++ b/drivers/tty/serial/atmel_serial.c > @@ -21,7 +21,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/tty/serial/fsl_linflexuart.c b/drivers/tty/serial/fsl_linflexuart.c > index 6fc21b6684e6..f697751c2ad5 100644 > --- a/drivers/tty/serial/fsl_linflexuart.c > +++ b/drivers/tty/serial/fsl_linflexuart.c > @@ -11,7 +11,7 @@ > #include > #include > #include > -#include > +#include > #include > #include > #include > diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c > index 4d80fae20177..e1a8d5415718 100644 > --- a/drivers/tty/serial/fsl_lpuart.c > +++ b/drivers/tty/serial/fsl_lpuart.c > @@ -18,9 +18,9 @@ > #include > #include > #include > -#include > #include > #include > +#include > #include > #include > #include > diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c > index 7341d060f85c..3ed5083a7108 100644 > --- a/drivers/tty/serial/imx.c > +++ b/drivers/tty/serial/imx.c > @@ -25,7 +25,6 @@ > #include > #include > #include > -#include > #include > #include > > diff --git a/drivers/tty/serial/lantiq.c b/drivers/tty/serial/lantiq.c > index bcaa479608d8..3adb60c683f7 100644 > --- a/drivers/tty/serial/lantiq.c > +++ b/drivers/tty/serial/lantiq.c > @@ -17,7 +17,8 @@ > #include > #include > #include > -#include > +#include > +#include > #include > #include > #include > diff --git a/drivers/tty/serial/liteuart.c b/drivers/tty/serial/liteuart.c > index 80de3a42b67b..d881cdd2a58f 100644 > --- a/drivers/tty/serial/liteuart.c > +++ b/drivers/tty/serial/liteuart.c > @@ -11,8 +11,7 @@ > #include > #include > #include > -#include > -#include > +#include > #include > #include > #include > diff --git a/drivers/tty/serial/ma35d1_serial.c b/drivers/tty/serial/ma35d1_serial.c > index 2604b4d9fb78..789593495a80 100644 > --- a/drivers/tty/serial/ma35d1_serial.c > +++ b/drivers/tty/serial/ma35d1_serial.c > @@ -8,7 +8,7 @@ > #include > #include > #include > -#include > +#include > #include > #include > #include > diff --git a/drivers/tty/serial/mpc52xx_uart.c b/drivers/tty/serial/mpc52xx_uart.c > index 384ca195e3d5..916507b8f31d 100644 > --- a/drivers/tty/serial/mpc52xx_uart.c > +++ b/drivers/tty/serial/mpc52xx_uart.c > @@ -40,7 +40,7 @@ > #include > #include > #include > -#include > +#include > #include > > #include > diff --git a/drivers/tty/serial/mps2-uart.c b/drivers/tty/serial/mps2-uart.c > index 860d161fa594..5da88cbeec73 100644 > --- a/drivers/tty/serial/mps2-uart.c > +++ b/drivers/tty/serial/mps2-uart.c > @@ -16,7 +16,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c > index a368f4293967..3974ca6ad86c 100644 > --- a/drivers/tty/serial/mxs-auart.c > +++ b/drivers/tty/serial/mxs-auart.c > @@ -30,7 +30,7 @@ > #include > #include > #include > -#include > +#include > #include > #include > > diff --git a/drivers/tty/serial/pic32_uart.c b/drivers/tty/serial/pic32_uart.c > index 196a4e678451..e308d5022b3f 100644 > --- a/drivers/tty/serial/pic32_uart.c > +++ b/drivers/tty/serial/pic32_uart.c > @@ -11,7 +11,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c > index 444c74eeab7d..5607b668588b 100644 > --- a/drivers/tty/serial/qcom_geni_serial.c > +++ b/drivers/tty/serial/qcom_geni_serial.c > @@ -11,7 +11,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/tty/serial/serial-tegra.c b/drivers/tty/serial/serial-tegra.c > index 1cf08b33456c..cbe641727f2a 100644 > --- a/drivers/tty/serial/serial-tegra.c > +++ b/drivers/tty/serial/serial-tegra.c > @@ -20,7 +20,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c > index 7c9457962a3d..115271d2f82d 100644 > --- a/drivers/tty/serial/sh-sci.c > +++ b/drivers/tty/serial/sh-sci.c > @@ -35,7 +35,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/tty/serial/sunhv.c b/drivers/tty/serial/sunhv.c > index 7d38c33ef506..c671d674bce4 100644 > --- a/drivers/tty/serial/sunhv.c > +++ b/drivers/tty/serial/sunhv.c > @@ -17,11 +17,11 @@ > #include > #include > #include > -#include > +#include > +#include > > #include > #include > -#include > #include > #include > > diff --git a/drivers/tty/serial/sunsab.c b/drivers/tty/serial/sunsab.c > index 48b39fdb0397..40eeaf835bba 100644 > --- a/drivers/tty/serial/sunsab.c > +++ b/drivers/tty/serial/sunsab.c > @@ -33,7 +33,8 @@ > #include > #include > #include > -#include > +#include > +#include > > #include > #include > diff --git a/drivers/tty/serial/sunsu.c b/drivers/tty/serial/sunsu.c > index fed052a0b931..58a4342ad0f9 100644 > --- a/drivers/tty/serial/sunsu.c > +++ b/drivers/tty/serial/sunsu.c > @@ -37,11 +37,11 @@ > #include > #include > #include > -#include > +#include > +#include > > #include > #include > -#include > #include > > #include > diff --git a/drivers/tty/serial/sunzilog.c b/drivers/tty/serial/sunzilog.c > index 0fbeb3dbd843..c8c71c56264c 100644 > --- a/drivers/tty/serial/sunzilog.c > +++ b/drivers/tty/serial/sunzilog.c > @@ -33,11 +33,11 @@ > #include > #endif > #include > -#include > +#include > +#include > > #include > #include > -#include > #include > > #include > diff --git a/drivers/tty/serial/tegra-tcu.c b/drivers/tty/serial/tegra-tcu.c > index 23500b342da7..65069daf36ec 100644 > --- a/drivers/tty/serial/tegra-tcu.c > +++ b/drivers/tty/serial/tegra-tcu.c > @@ -7,7 +7,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c > index 679574893ebe..b225a78f6175 100644 > --- a/drivers/tty/serial/uartlite.c > +++ b/drivers/tty/serial/uartlite.c > @@ -20,9 +20,6 @@ > #include > #include > #include > -#include > -#include > -#include > #include > #include > > diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c > index 404230c1ebb2..284b293fade6 100644 > --- a/drivers/tty/serial/ucc_uart.c > +++ b/drivers/tty/serial/ucc_uart.c > @@ -17,15 +17,16 @@ > */ > > #include > +#include > #include > #include > #include > #include > #include > #include > +#include > #include > #include > -#include > #include > > #include > diff --git a/drivers/tty/serial/vt8500_serial.c b/drivers/tty/serial/vt8500_serial.c > index cc9157df732f..32433e9b3e5f 100644 > --- a/drivers/tty/serial/vt8500_serial.c > +++ b/drivers/tty/serial/vt8500_serial.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -21,7 +22,6 @@ > #include > #include > #include > -#include > #include > > /* > -- > 2.40.1 >