From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F3DCC001DE for ; Tue, 8 Aug 2023 17:29:46 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=treblig.org header.i=@treblig.org header.a=rsa-sha256 header.s=bytemarkmx header.b=Vq2SMmKs; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RL0Yh5RRkz3bVG for ; Wed, 9 Aug 2023 03:29:44 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=treblig.org header.i=@treblig.org header.a=rsa-sha256 header.s=bytemarkmx header.b=Vq2SMmKs; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=treblig.org (client-ip=2a00:1098:5b::1; helo=mx.treblig.org; envelope-from=dg@treblig.org; receiver=lists.ozlabs.org) Received: from mx.treblig.org (unknown [IPv6:2a00:1098:5b::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4RL0Xg0YrLz2yhP for ; Wed, 9 Aug 2023 03:28:49 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID :Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=5O2J3ZOvO2rHCsErDQjcGUfCgAaBbnfOM3Ddj2mjhyk=; b=Vq2SMmKsiIQ4V2d0R0GIxbtD8t rhzaB4rM41FepLLQIOy6dCcivND3z7YakVxQok02wev6LbOrgElrlslBW9gX67WJHPItY+wmmRcxy zTWgI1QjxDuaZGa/X0N22s//Pf+77jSahC/pk55krmXTac+IvjB0V6cpmi6Vw3eJ6+xCEsnmjresP qzUhMlNuCxtqzEEJNHiHK9U0hh5itD6iDWHVu8ZQKiKDr+Mv1sM02dz3jE3TksPm2CnUWyQc+/KrT ulP2OqYxb6IyTGMS4zSh+L7Gql2+dUoDFzuaKmPeqW/jc4BJDKB6DMq/2EX1riIEXTsPqQOOaY7PT MGH8+bZw==; Received: from dg by mx.treblig.org with local (Exim 4.94.2) (envelope-from ) id 1qTQVX-005lCt-AT; Tue, 08 Aug 2023 17:28:35 +0000 Date: Tue, 8 Aug 2023 17:28:35 +0000 From: "Dr. David Alan Gilbert" To: Randy Dunlap Subject: Re: [PATCH v2] powerpc: Use shared font data Message-ID: References: <20230807010721.799613-1-linux@treblig.org> <828497a6-80c2-329f-8b47-2311bf08943d@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <828497a6-80c2-329f-8b47-2311bf08943d@infradead.org> X-Chocolate: 70 percent or better cocoa solids preferably X-Operating-System: Linux/5.10.0-23-amd64 (x86_64) X-Uptime: 17:25:06 up 33 days, 2:56, 1 user, load average: 0.06, 0.05, 0.07 User-Agent: Mutt/2.0.5 (2021-01-21) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sam@ravnborg.org, linux-kernel@vger.kernel.org, npiggin@gmail.com, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" * Randy Dunlap (rdunlap@infradead.org) wrote: > Hi-- > > On 8/6/23 18:07, linux@treblig.org wrote: > > From: "Dr. David Alan Gilbert" > > > > PowerPC has a 'btext' font used for the console which is almost identical > > to the shared font_sun8x16, so use it rather than duplicating the data. > > > > They were actually identical until about a decade ago when > > commit bcfbeecea11c ("drivers: console: font_: Change a glyph from > > "broken bar" to "vertical line"") > > > > which changed the | in the shared font to be a solid > > bar rather than a broken bar. That's the only difference. > > > > This was originally spotted by PMD which noticed that sparc does > > the same thing with the same data, and they also share a bunch > > of functions to manipulate the data. I've previously posted a near > > identical patch for sparc. > > > > One difference I notice in PowerPC is that there are a bunch of compile > > options for the .c files for the early code to avoid a bunch of security > > compilation features; it's not clear to me if this is a problem for > > this font data. > > > > Tested very lightly with a boot without FS in qemu. > > > > v2 > > Added 'select FONT_SUPPORT' (to stop modconfig causing the font to be > > linked into a module rather than the main kernel) > > Added 'select FONTS' to satisfy requirements in lib/fonts > > > > Signed-off-by: Dr. David Alan Gilbert > > --- > > arch/powerpc/Kconfig.debug | 3 + > > arch/powerpc/kernel/btext.c | 360 +----------------------------------- > > 2 files changed, 9 insertions(+), 354 deletions(-) > > > > diff --git a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug > > index 2a54fadbeaf51..521c4baf30e88 100644 > > --- a/arch/powerpc/Kconfig.debug > > +++ b/arch/powerpc/Kconfig.debug > > @@ -147,6 +147,9 @@ config BDI_SWITCH > > config BOOTX_TEXT > > bool "Support for early boot text console (BootX or OpenFirmware only)" > > depends on PPC_BOOK3S > > + select FONT_SUN8x16 > > + select FONT_SUPPORT > > + select FONTS > > help > > Say Y here to see progress messages from the boot firmware in text > > mode. Requires either BootX or Open Firmware. > > kconfig tells me: > > WARNING: unmet direct dependencies detected for FONTS > Depends on [n]: FONT_SUPPORT [=y] && (FRAMEBUFFER_CONSOLE [=n] || STI_CONSOLE [=n]) > Selected by [y]: > - BOOTX_TEXT [=y] && PPC_BOOK3S [=y] > > WARNING: unmet direct dependencies detected for FONT_SUN8x16 > Depends on [n]: FONT_SUPPORT [=y] && FRAMEBUFFER_CONSOLE [=n] && (!SPARC && FONTS [=y] || SPARC) > Selected by [y]: > - BOOTX_TEXT [=y] && PPC_BOOK3S [=y] > > because FONTS depends on FRAMEBUFFER_CONSOLE || STI_CONSOLE and neither of those is set. I'm not getting the warnings in the v2, with a few configs; what command are using? I'm tempted to change the FONT_SUN8x16 dependency line to have SPARC||BOOTX_TEXT or SPARC||POWERPC and drop the 'select FONTS' I added. Dave > > -- > ~Randy -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/