From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9C5AEE14A9 for ; Wed, 6 Sep 2023 21:59:59 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=m2yx96YV; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RgxB53g7yz3c5V for ; Thu, 7 Sep 2023 07:59:57 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=m2yx96YV; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::430; helo=mail-wr1-x430.google.com; envelope-from=mingo.kernel.org@gmail.com; receiver=lists.ozlabs.org) Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Rgx935bfDz2xpx for ; Thu, 7 Sep 2023 07:59:02 +1000 (AEST) Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-31c65820134so311758f8f.1 for ; Wed, 06 Sep 2023 14:59:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694037535; x=1694642335; darn=lists.ozlabs.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=fUEsUDVRFl9we3IvMz1iDQ5wrm80qIsR/HrhiCU8qwU=; b=m2yx96YVQYXR8Usg7d0Ql48NNLMDRNyfD3Wjclx2EolO83lr3BofKIdSR6mTAy/ths DW3hOTOef3E4UIMLo2wfs+iy5mhPXY9Z3dOmBhmgRnSM4j2Ts5OdxyJP/edJW+InvSR4 KtUYfJKWSbGCghto0Fa3b06yV8bMn+jDdq+ygTZUR6xpGoNehegBUQDYvT3HhUUHv26Y Max0XEpiw9UR6+rQwRscfMx9x0qDwkgtdY6e8MzJBRZU4AGqs+4wn+p9Qa7CfoYS5yst vSqCq0fgYagLY9RA400zCsFGjBQRZj5vE5LtnuscsXNDkBiMC3j6toc0tS1vLhH5epSr +7dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694037535; x=1694642335; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fUEsUDVRFl9we3IvMz1iDQ5wrm80qIsR/HrhiCU8qwU=; b=Sf0ZjK2hLOSjj2/gzNrEjUn1Nsqz/fN/3h18QSNlVWRrj7WTMm5xpd8g/GmDPwCHkL ZLkoHoE96nauQHZwsZA3YOs3xovB9uBcHAdE7p81LW3/6llehoOpj+P8CLJvZ0zWL4op zo7+uzr3lP+47UFvfMPoLaxPNG0hzL3gqom13Vc7/I7cAXfNmvz39geZ8xlqa0bDdi7f C/xfQHb++iYUFGENPynHVZXHht4juqzGFIuR01E/waht1IptHw3CjUYbxKBJotRkHHUp kSt2JQvtLUYSI8cdBbenVeAdlpmp+qTyVFLjLbxt8A4NraEBIbDKVEvTt6Tcf6WitscJ HGlA== X-Gm-Message-State: AOJu0YwGUWOg1GfYM3FLYvwbOJfM9qNqvSkx22W5HYTm3CxXe8EywyI2 89NXJAiEvTMQFg9H9Q0wks8= X-Google-Smtp-Source: AGHT+IG5nMeuL/VoGmcwCLwFLhOfCIhRsiIb9391lHp1yY958vfciaCR4r3uuUZhhDYYQHGkLNQJgQ== X-Received: by 2002:a5d:604b:0:b0:30e:3da5:46e5 with SMTP id j11-20020a5d604b000000b0030e3da546e5mr3830642wrt.59.1694037535283; Wed, 06 Sep 2023 14:58:55 -0700 (PDT) Received: from gmail.com (1F2EF6A2.nat.pool.telekom.hu. [31.46.246.162]) by smtp.gmail.com with ESMTPSA id n10-20020adffe0a000000b003140f47224csm21447397wrr.15.2023.09.06.14.58.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 14:58:50 -0700 (PDT) Date: Wed, 6 Sep 2023 23:58:47 +0200 From: Ingo Molnar To: Dave Hansen Subject: Re: [PATCH 3/8] arch/x86: Remove sentinel elem from ctl_table arrays Message-ID: References: <20230906-jag-sysctl_remove_empty_elem_arch-v1-0-3935d4854248@samsung.com> <20230906-jag-sysctl_remove_empty_elem_arch-v1-3-3935d4854248@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: j.granados@samsung.com, Mark Rutland , linux-ia64@vger.kernel.org, Catalin Marinas , Dave Hansen , Guo Ren , "H. Peter Anvin" , Alexander Gordeev , Will Deacon , linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, x86@kernel.org, Russell King , willy@infradead.org, Ingo Molnar , Gerald Schaefer , Christian Borntraeger , Albert Ou , Kees Cook , Vasily Gorbik , Heiko Carstens , josh@joshtriplett.org, Nicholas Piggin , linux-csky@vger.kernel.org, Borislav Petkov , Andy Lutomirski , Paul Walmsley , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Iurii Zaikin , linux-kernel@vger.kernel.org, Luis Chamberlain , Palmer Dabbelt , Sven Schnelle , linux-fsdevel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" * Dave Hansen wrote: > On 9/6/23 03:03, Joel Granados via B4 Relay wrote: > > This commit comes at the tail end of a greater effort to remove the > > empty elements at the end of the ctl_table arrays (sentinels) which > > will reduce the overall build time size of the kernel and run time > > memory bloat by ~64 bytes per sentinel (further information Link : > > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/) > > > > Remove sentinel element from sld_sysctl and itmt_kern_table. > > There's a *LOT* of content to read for a reviewer to figure out what's > going on here between all the links. I would have appreciated one more > sentence here, maybe: > > This is now safe because the sysctl registration code > (register_sysctl()) implicitly uses ARRAY_SIZE() in addition > to checking for a sentinel. > > That needs to be more prominent _somewhere_. Maybe here, or maybe in > the cover letter, but _somewhere_. > > That said, feel free to add this to the two x86 patches: > > Acked-by: Dave Hansen # for x86 Absolutely needs to be in the title as well, something like: arch/x86: Remove now superfluous sentinel elem from ctl_table arrays With that propagated into the whole series: Reviewed-by: Ingo Molnar Thanks, Ingo