From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8986C41513 for ; Mon, 16 Oct 2023 16:27:07 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=oGI3ch/H; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4S8MvZ3shzz3vZ3 for ; Tue, 17 Oct 2023 03:27:06 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=oGI3ch/H; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=145.40.68.75; helo=ams.source.kernel.org; envelope-from=lpieralisi@kernel.org; receiver=lists.ozlabs.org) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4S8MtS3GhFz3cRF for ; Tue, 17 Oct 2023 03:26:08 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 561ECB816AD; Mon, 16 Oct 2023 16:26:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F83FC433C8; Mon, 16 Oct 2023 16:26:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697473564; bh=vHm90cKOkSetxJUdQaefCuS8V7G0nuWKrTxOWNKF9Z8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oGI3ch/HDtNcpizMAy6Bwh4RF7FGdU8zyd9ZK9yNWueL0wb1XG/3K1n1Sxot3ovM8 lXanfq6ZuvlavWJLDB6kxQ8kVYfK7r6085UD3Fo0rCPhuKm1ffRILuYnT9K/S1Kvpg VunZ89D7sjOLZdvawnvjtuNaMntMECuhd1m3BbyDWEKYq7xLp50CU8cplQjsvt+5ue sazFS5K5Qy7w5B0kKkiBfPiBzSsTRnP/OfZXruucC68x5+k0qBEb0zDRGJeyfRrigI LOQcDHSyRmripo8yAREgDjp7JndIOLmqowu9RaVRsjVyg04wuR/aBFK6C/4zvzwo+0 NkE32kNkNZ3nA== Date: Mon, 16 Oct 2023 18:25:58 +0200 From: Lorenzo Pieralisi To: Frank Li Subject: Re: [PATCH 2/3] PCI: layerscape: add suspend/resume for ls1021a Message-ID: References: <20231016152211.GA1209639@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , imx@lists.linux.dev, Rob Herring , "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , open list , Minghuan Lian , Bjorn Helgaas , "moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , Roy Zang , Bjorn Helgaas , "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , Mingkai Hu Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Oct 16, 2023 at 12:11:04PM -0400, Frank Li wrote: > On Mon, Oct 16, 2023 at 10:22:11AM -0500, Bjorn Helgaas wrote: > > On Mon, Oct 16, 2023 at 10:45:25AM -0400, Frank Li wrote: > > > On Tue, Oct 10, 2023 at 06:02:36PM +0200, Lorenzo Pieralisi wrote: > > > > On Tue, Oct 10, 2023 at 10:20:12AM -0400, Frank Li wrote: > > > > > > > Ping > > > > > > > > Read and follow please (and then ping us): > > > > https://lore.kernel.org/linux-pci/20171026223701.GA25649@bhelgaas-glaptop.roam.corp.google.com > > > > > > Could you please help point which specic one was not follow aboved guide? > > > Then I can update my code. I think that's efficial communication method. I > > > think I have read it serial times. But not sure which one violate the > > > guide? > > > > > > @Bjorn Helgaas. How do you think so? > > > > Since Lorenzo didn't point out anything specific in the patch itself, > > I think he was probably referring to the subject line and this advice: > > > > - Follow the existing convention, i.e., run "git log --oneline > > " and make yours match in format, capitalization, and > > sentence structure. For example, native host bridge driver patch > > titles look like this: > > > > PCI: altera: Fix platform_get_irq() error handling > > PCI: vmd: Remove IRQ affinity so we can allocate more IRQs > > PCI: mediatek: Add MSI support for MT2712 and MT7622 > > PCI: rockchip: Remove IRQ domain if probe fails > > > > In this case, your subject line was: > > > > PCI: layerscape: add suspend/resume for ls1021a > > > > The advice was to run this: > > > > $ git log --oneline drivers/pci/controller/dwc/pci-layerscape.c > > 83c088148c8e PCI: Use PCI_HEADER_TYPE_* instead of literals > > 9fda4d09905d PCI: layerscape: Add power management support for ls1028a > > 277004d7a4a3 PCI: Remove unnecessary includes > > 60b3c27fb9b9 PCI: dwc: Rename struct pcie_port to dw_pcie_rp > > d23f0c11aca2 PCI: layerscape: Change to use the DWC common link-up check function > > 7007b745a508 PCI: layerscape: Convert to builtin_platform_driver() > > 60f5b73fa0f2 PCI: dwc: Remove unnecessary wrappers around dw_pcie_host_init() > > b9ac0f9dc8ea PCI: dwc: Move dw_pcie_setup_rc() to DWC common code > > f78f02638af5 PCI: dwc: Rework MSI initialization > > > > Note that these summaries are all complete sentences that start with a > > capital letter: > > > > Use PCI_HEADER_TYPE_* instead of literals > > Add power management support for ls1028a > > Remove unnecessary includes > > ... > > > > So yours could be this: > > > > PCI: layerscape: Add suspend/resume for ls1021a > > ^ > > > > This is trivial, obviously. But the uppercase/lowercase distinction > > carries information, and it's an unnecessary distraction to notice > > that "oh, this is different from the rest; is the difference > > important or should I ignore it?" > > Thanks. Not everyone think it is trivial. Especially for the one, who > English are not native language. > > > > > Obviously Lorenzo *could* edit all your subject lines on your behalf, > > but it makes everybody's life easier if people look at the existing > > code and follow the style when making changes. > > Understand, but simple mark 'a' and 'A' to me. I will update patches and > take care for next time instead search whole docuemnt to guess which one > violated. I know I make some mistakes at here. But I am working on many > difference kernel subsystems, some require upper case, some require low > case, someone doesn't care. > > I respected all reviewer's and maintaner's time, but I hope respected > the contributor's time also. I do respect your time, please respect ours by following the guidelines I provided you with multiple times already. Thank you for resending the series. Lorenzo