* [PATCH 1/4] kbuild: remove ARCH_POSTLINK from module builds
@ 2023-10-17 10:37 Masahiro Yamada
2023-10-17 12:09 ` Nicolas Schier
2023-11-12 0:55 ` patchwork-bot+linux-riscv
0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2023-10-17 10:37 UTC (permalink / raw)
To: linux-kbuild
Cc: x86, Albert Ou, Nicolas Schier, Masahiro Yamada, Dave Hansen,
Nick Desaulniers, linux-kernel, linux-mips, Nathan Chancellor,
Ingo Molnar, Borislav Petkov, Nicholas Piggin, Paul Walmsley,
H. Peter Anvin, Palmer Dabbelt, Thomas Gleixner,
Thomas Bogendoerfer, linuxppc-dev, linux-riscv
The '%.ko' rule in arch/*/Makefile.postlink does nothing but call the
'true' command.
Remove the meaningless code.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
arch/mips/Makefile.postlink | 3 ---
arch/powerpc/Makefile.postlink | 3 ---
arch/riscv/Makefile.postlink | 3 ---
arch/x86/Makefile.postlink | 3 ---
scripts/Makefile.modfinal | 5 +----
5 files changed, 1 insertion(+), 16 deletions(-)
diff --git a/arch/mips/Makefile.postlink b/arch/mips/Makefile.postlink
index 34e3bd71f3b0..6cfdc149d3bc 100644
--- a/arch/mips/Makefile.postlink
+++ b/arch/mips/Makefile.postlink
@@ -31,9 +31,6 @@ ifeq ($(CONFIG_RELOCATABLE),y)
$(call if_changed,relocs)
endif
-%.ko: FORCE
- @true
-
clean:
@true
diff --git a/arch/powerpc/Makefile.postlink b/arch/powerpc/Makefile.postlink
index 1f860b3c9bec..ae5a4256b03d 100644
--- a/arch/powerpc/Makefile.postlink
+++ b/arch/powerpc/Makefile.postlink
@@ -35,9 +35,6 @@ ifdef CONFIG_RELOCATABLE
$(call if_changed,relocs_check)
endif
-%.ko: FORCE
- @true
-
clean:
rm -f .tmp_symbols.txt
diff --git a/arch/riscv/Makefile.postlink b/arch/riscv/Makefile.postlink
index a46fc578b30b..829b9abc91f6 100644
--- a/arch/riscv/Makefile.postlink
+++ b/arch/riscv/Makefile.postlink
@@ -36,9 +36,6 @@ ifdef CONFIG_RELOCATABLE
$(call if_changed,relocs_strip)
endif
-%.ko: FORCE
- @true
-
clean:
@true
diff --git a/arch/x86/Makefile.postlink b/arch/x86/Makefile.postlink
index 936093d29160..fef2e977cc7d 100644
--- a/arch/x86/Makefile.postlink
+++ b/arch/x86/Makefile.postlink
@@ -34,9 +34,6 @@ ifeq ($(CONFIG_X86_NEED_RELOCS),y)
$(call cmd,strip_relocs)
endif
-%.ko: FORCE
- @true
-
clean:
@rm -f $(OUT_RELOCS)/vmlinux.relocs
diff --git a/scripts/Makefile.modfinal b/scripts/Makefile.modfinal
index b3a6aa8fbe8c..8568d256d6fb 100644
--- a/scripts/Makefile.modfinal
+++ b/scripts/Makefile.modfinal
@@ -28,14 +28,11 @@ quiet_cmd_cc_o_c = CC [M] $@
%.mod.o: %.mod.c FORCE
$(call if_changed_dep,cc_o_c)
-ARCH_POSTLINK := $(wildcard $(srctree)/arch/$(SRCARCH)/Makefile.postlink)
-
quiet_cmd_ld_ko_o = LD [M] $@
cmd_ld_ko_o += \
$(LD) -r $(KBUILD_LDFLAGS) \
$(KBUILD_LDFLAGS_MODULE) $(LDFLAGS_MODULE) \
- -T scripts/module.lds -o $@ $(filter %.o, $^); \
- $(if $(ARCH_POSTLINK), $(MAKE) -f $(ARCH_POSTLINK) $@, true)
+ -T scripts/module.lds -o $@ $(filter %.o, $^)
quiet_cmd_btf_ko = BTF [M] $@
cmd_btf_ko = \
--
2.40.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/4] kbuild: remove ARCH_POSTLINK from module builds
2023-10-17 10:37 [PATCH 1/4] kbuild: remove ARCH_POSTLINK from module builds Masahiro Yamada
@ 2023-10-17 12:09 ` Nicolas Schier
2023-11-12 0:55 ` patchwork-bot+linux-riscv
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Schier @ 2023-10-17 12:09 UTC (permalink / raw)
To: Masahiro Yamada
Cc: x86, Albert Ou, Nicolas Schier, linux-kbuild, Dave Hansen,
Nick Desaulniers, linux-kernel, linux-mips, Nathan Chancellor,
Ingo Molnar, Borislav Petkov, Nicholas Piggin, Paul Walmsley,
H. Peter Anvin, Palmer Dabbelt, Thomas Gleixner,
Thomas Bogendoerfer, linuxppc-dev, linux-riscv
On Tue, Oct 17, 2023 at 07:37:39PM +0900, Masahiro Yamada wrote:
> The '%.ko' rule in arch/*/Makefile.postlink does nothing but call the
> 'true' command.
>
> Remove the meaningless code.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> arch/mips/Makefile.postlink | 3 ---
> arch/powerpc/Makefile.postlink | 3 ---
> arch/riscv/Makefile.postlink | 3 ---
> arch/x86/Makefile.postlink | 3 ---
> scripts/Makefile.modfinal | 5 +----
> 5 files changed, 1 insertion(+), 16 deletions(-)
Reviewed-by: Nicolas Schier <n.schier@avm.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/4] kbuild: remove ARCH_POSTLINK from module builds
2023-10-17 10:37 [PATCH 1/4] kbuild: remove ARCH_POSTLINK from module builds Masahiro Yamada
2023-10-17 12:09 ` Nicolas Schier
@ 2023-11-12 0:55 ` patchwork-bot+linux-riscv
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+linux-riscv @ 2023-11-12 0:55 UTC (permalink / raw)
To: Masahiro Yamada
Cc: x86, aou, nicolas, linux-kbuild, dave.hansen, ndesaulniers,
linux-kernel, linux-mips, nathan, mingo, bp, npiggin,
paul.walmsley, hpa, palmer, linux-riscv, tsbogend, linuxppc-dev,
tglx
Hello:
This patch was applied to riscv/linux.git (fixes)
by Masahiro Yamada <masahiroy@kernel.org>:
On Tue, 17 Oct 2023 19:37:39 +0900 you wrote:
> The '%.ko' rule in arch/*/Makefile.postlink does nothing but call the
> 'true' command.
>
> Remove the meaningless code.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
>
> [...]
Here is the summary with links:
- [1/4] kbuild: remove ARCH_POSTLINK from module builds
https://git.kernel.org/riscv/c/7f6d8f7e43fb
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-12 0:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-17 10:37 [PATCH 1/4] kbuild: remove ARCH_POSTLINK from module builds Masahiro Yamada
2023-10-17 12:09 ` Nicolas Schier
2023-11-12 0:55 ` patchwork-bot+linux-riscv
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).