From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 340A3CD6918 for ; Tue, 10 Oct 2023 09:39:59 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4S4W8Z1GvWz3dhY for ; Tue, 10 Oct 2023 20:39:58 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=cmarinas@kernel.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4S4W7z448Vz3c1C for ; Tue, 10 Oct 2023 20:39:27 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 760466159D; Tue, 10 Oct 2023 09:39:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC772C433C7; Tue, 10 Oct 2023 09:39:15 +0000 (UTC) Date: Tue, 10 Oct 2023 10:39:13 +0100 From: Catalin Marinas To: Arnd Bergmann Subject: Re: [PATCH v3 9/9] efi: move screen_info into efi init code Message-ID: References: <20231009211845.3136536-1-arnd@kernel.org> <20231009211845.3136536-10-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231009211845.3136536-10-arnd@kernel.org> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, x86@kernel.org, linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Linus Walleij , Dave Hansen , linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org, Russell King , Max Filippov , Will Deacon , linux-efi@vger.kernel.org, Guo Ren , linux-csky@vger.kernel.org, sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org, WANG Xuerui , "K. Y. Srinivasan" , David Airlie , Ard Biesheuvel , Wei Liu , Helge Deller , Huacai Chen , Dexuan Cui , Javier Martinez Canillas , Deepak Rawat , Ingo Molnar , Matt Turner , linux-mips@vger.kernel.org, Thomas Zimmermann , Arnd Be rgmann , Haiyang Zhang , Nicholas Piggin , Borislav Petkov , loongarch@lists.linux.dev, John Paul Adrian Glaubitz , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Khalid Aziz , Brian Cain , Thomas Bogendoerfer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Dinh Nguyen , linux-riscv@lists.infradead.org, Palmer Dabbelt , Daniel Vetter , linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Oct 09, 2023 at 11:18:45PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > After the vga console no longer relies on global screen_info, there are > only two remaining use cases: > > - on the x86 architecture, it is used for multiple boot methods > (bzImage, EFI, Xen, kexec) to commucate the initial VGA or framebuffer > settings to a number of device drivers. > > - on other architectures, it is only used as part of the EFI stub, > and only for the three sysfb framebuffers (simpledrm, simplefb, efifb). > > Remove the duplicate data structure definitions by moving it into the > efi-init.c file that sets it up initially for the EFI case, leaving x86 > as an exception that retains its own definition for non-EFI boots. > > The added #ifdefs here are optional, I added them to further limit the > reach of screen_info to configurations that have at least one of the > users enabled. > > Reviewed-by: Ard Biesheuvel > Reviewed-by: Javier Martinez Canillas > Acked-by: Helge Deller > Signed-off-by: Arnd Bergmann > --- > arch/arm/kernel/setup.c | 4 ---- > arch/arm64/kernel/efi.c | 4 ---- > arch/arm64/kernel/image-vars.h | 2 ++ It's more Ard's thing and he reviewed it already but if you need another ack: Acked-by: Catalin Marinas