From: "Daniel Walker (danielwa)" <danielwa@cisco.com>
To: Rob Herring <robh@kernel.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Tomas Mudrunka <tomas.mudrunka@gmail.com>,
Daniel Gimpelevich <daniel@gimpelevich.san-francisco.ca.us>,
Frank Rowand <frowand.list@gmail.com>,
Sean Anderson <sean.anderson@seco.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"x86@kernel.org" <x86@kernel.org>,
Pratyush Brahma <quic_pbrahma@quicinc.com>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
"xe-linux-external\(mailer list\)" <xe-linux-external@cisco.com>,
Andrew Morton <akpm@linux-foundation.org>,
Will Deacon <will@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 7/8] of: replace command line handling
Date: Thu, 16 Nov 2023 16:33:30 +0000 [thread overview]
Message-ID: <ZVZEWrUKh8N/a7SL@goliath> (raw)
In-Reply-To: <20231116160936.GA2376455-robh@kernel.org>
On Thu, Nov 16, 2023 at 10:09:36AM -0600, Rob Herring wrote:
> On Thu, Nov 09, 2023 at 05:38:11PM -0800, Daniel Walker wrote:
> > Rob Herring has complained about this section of code. I removed the
> > command line handling code to the cmdline.h header. This hopefully makes
> > it easier for Rob to maintain it (at least he doesn't have to look at it
> > directly anymore).
>
> Well, my goal is to eliminate drivers/of/, but no.
>
> > I would like to add a Kconfig option called
> > OF_DEPRECATED_CMDLINE which an architecture would set if it uses this code.
>
> Which architecture needs this code? Do we wait and see who complains
> their platform broke and then go set this option? In the meantime, new
> platforms started depending on the new behavior and setting the option
> may break them. So we can't have a kconfig option.
I think you misunderstood the comments. The objective is,
1) Remove the code in drivers/of/
2) Remove platform specific command line handling
> > This would allow a platform to use the cmdline.h and the added function
> > directly and remove the Kconfig option. This change would be in a subsequent
> > patch.
>
> Per platform code handling the cmdline is completely the wrong
> direction. Per arch behavior is bad enough.
This code unifies the handling into generic code outside drivers/of/ .
Daniel
next prev parent reply other threads:[~2023-11-16 16:35 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 1:38 [PATCH 0/8] generic command line v6 Daniel Walker
2023-11-10 1:38 ` [PATCH 1/8] CMDLINE: add generic builtin command line Daniel Walker
2023-11-10 16:12 ` kernel test robot
2023-11-23 6:32 ` Christophe Leroy
2023-12-04 11:11 ` Jaskaran Singh
2023-11-10 1:38 ` [PATCH 2/8] scripts: insert-sys-cert: add command line insert capability Daniel Walker
2023-11-23 6:33 ` Christophe Leroy
2023-11-10 1:38 ` [PATCH 3/8] scripts: insert-sys-cert: change name to insert-symbol Daniel Walker
2023-11-23 6:34 ` Christophe Leroy
2023-11-10 1:38 ` [PATCH 4/8] CMDLINE: mips: convert to generic builtin command line Daniel Walker
2023-11-23 6:36 ` Christophe Leroy
2023-11-10 1:38 ` [PATCH 5/8] drivers: firmware: efi: libstub: enable generic commandline Daniel Walker
2023-11-10 4:23 ` kernel test robot
2023-11-23 6:37 ` Christophe Leroy
2023-12-12 9:55 ` Ard Biesheuvel
2023-12-12 17:25 ` Daniel Walker (danielwa)
2023-11-10 1:38 ` [PATCH 6/8] CMDLINE: x86: convert to generic builtin command line Daniel Walker
2023-11-10 7:17 ` kernel test robot
2025-10-02 20:49 ` Dave Hansen
2025-10-02 21:00 ` Daniel Walker (danielwa)
2025-10-02 21:10 ` Dave Hansen
2025-10-02 21:31 ` Daniel Walker (danielwa)
2025-10-02 21:55 ` Dave Hansen
2025-10-02 22:38 ` Daniel Gimpelevich
2025-10-02 23:10 ` Dave Hansen
2025-10-02 23:20 ` Daniel Gimpelevich
2025-10-02 23:39 ` Daniel Walker (danielwa)
2025-10-02 23:48 ` Dave Hansen
2023-11-10 1:38 ` [PATCH 7/8] of: replace command line handling Daniel Walker
2023-11-16 16:09 ` Rob Herring
2023-11-16 16:33 ` Daniel Walker (danielwa) [this message]
2023-11-23 6:39 ` Christophe Leroy
2023-11-10 1:38 ` [PATCH 8/8] CMDLINE: arm64: convert to generic builtin command line Daniel Walker
2023-11-23 6:39 ` Christophe Leroy
2023-11-10 1:51 ` [PATCH 0/8] generic command line v6 Andrew Morton
2023-11-10 2:22 ` Daniel Walker (danielwa)
2023-11-10 2:40 ` Andrew Morton
2023-11-23 6:23 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVZEWrUKh8N/a7SL@goliath \
--to=danielwa@cisco.com \
--cc=akpm@linux-foundation.org \
--cc=daniel@gimpelevich.san-francisco.ca.us \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=quic_pbrahma@quicinc.com \
--cc=robh@kernel.org \
--cc=sean.anderson@seco.com \
--cc=tomas.mudrunka@gmail.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).