From: Baoquan He <bhe@redhat.com>
To: Hari Bathini <hbathini@linux.ibm.com>
Cc: Dave Young <dyoung@redhat.com>,
Kexec-ml <kexec@lists.infradead.org>,
lkml <linux-kernel@vger.kernel.org>,
Sourabh Jain <sourabhjain@linux.ibm.com>,
Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
Nicholas Piggin <npiggin@gmail.com>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH linux-next v2 0/3] powerpc/kexec: split CONFIG_CRASH_DUMP out from CONFIG_KEXEC_CORE
Date: Wed, 28 Feb 2024 21:27:24 +0800 [thread overview]
Message-ID: <Zd80vHHS2Jrobvtq@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20240226103010.589537-1-hbathini@linux.ibm.com>
On 02/26/24 at 04:00pm, Hari Bathini wrote:
> This patch series is a follow-up to [1] based on discussions at [2]
> about additional work needed to get it working on powerpc.
>
> The first patch in the series makes struct crash_mem available with or
> without CONFIG_CRASH_DUMP enabled. The next patch moves kdump specific
> code for kexec_file_load syscall under CONFIG_CRASH_DUMP and the last
> patch splits other kdump specific code under CONFIG_CRASH_DUMP and
> removes dependency with CONFIG_CRASH_DUMP for CONFIG_KEXEC_CORE.
>
> [1] https://lore.kernel.org/all/20240124051254.67105-1-bhe@redhat.com/
> [2] https://lore.kernel.org/all/9101bb07-70f1-476c-bec9-ec67e9899744@linux.ibm.com/
>
> Changes in v2:
> * Fixed a compile error for POWERNV build reported by Sourabh.
>
> Hari Bathini (3):
> kexec/kdump: make struct crash_mem available without CONFIG_CRASH_DUMP
> powerpc/kexec: split CONFIG_KEXEC_FILE and CONFIG_CRASH_DUMP
> powerpc/kdump: Split KEXEC_CORE and CRASH_DUMP dependency
I have acked patch 1. And patch 2 and 3 looks good to me, leave these
two to powerpc experts to have a careful reviewing. Thanks for these
great work.
>
> arch/powerpc/Kconfig | 9 +-
> arch/powerpc/include/asm/kexec.h | 98 +++++-----
> arch/powerpc/kernel/prom.c | 2 +-
> arch/powerpc/kernel/setup-common.c | 2 +-
> arch/powerpc/kernel/smp.c | 4 +-
> arch/powerpc/kexec/Makefile | 3 +-
> arch/powerpc/kexec/core.c | 4 +
> arch/powerpc/kexec/elf_64.c | 4 +-
> arch/powerpc/kexec/file_load_64.c | 269 ++++++++++++++-------------
> arch/powerpc/platforms/powernv/smp.c | 2 +-
> include/linux/crash_core.h | 12 +-
> 11 files changed, 209 insertions(+), 200 deletions(-)
>
> --
> 2.43.2
>
next prev parent reply other threads:[~2024-02-28 13:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 10:30 [PATCH linux-next v2 0/3] powerpc/kexec: split CONFIG_CRASH_DUMP out from CONFIG_KEXEC_CORE Hari Bathini
2024-02-26 10:30 ` [PATCH linux-next v2 1/3] kexec/kdump: make struct crash_mem available without CONFIG_CRASH_DUMP Hari Bathini
2024-02-27 10:52 ` Baoquan He
2024-02-26 10:30 ` [PATCH linux-next v2 2/3] powerpc/kexec: split CONFIG_KEXEC_FILE and CONFIG_CRASH_DUMP Hari Bathini
2024-02-26 10:30 ` [PATCH linux-next v2 3/3] powerpc/kdump: Split KEXEC_CORE and CRASH_DUMP dependency Hari Bathini
2024-02-28 13:27 ` Baoquan He [this message]
2024-03-23 0:45 ` [PATCH linux-next v2 0/3] powerpc/kexec: split CONFIG_CRASH_DUMP out from CONFIG_KEXEC_CORE Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zd80vHHS2Jrobvtq@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dyoung@redhat.com \
--cc=hbathini@linux.ibm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=sourabhjain@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).