From: Peter Xu <peterx@redhat.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Muchun Song <muchun.song@linux.dev>,
Yang Shi <shy828301@gmail.com>, "x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Jason Gunthorpe <jgg@nvidia.com>,
"Kirill A . Shutemov" <kirill@shutemov.name>,
Andrew Morton <akpm@linux-foundation.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 0/5] mm/treewide: Replace pXd_large() with pXd_leaf()
Date: Wed, 28 Feb 2024 18:23:59 +0800 [thread overview]
Message-ID: <Zd8Jv8hQdXejTnbU@x1n> (raw)
In-Reply-To: <93954095-4515-46ff-bdad-ad08439b4471@csgroup.eu>
On Wed, Feb 28, 2024 at 09:50:52AM +0000, Christophe Leroy wrote:
> Le 28/02/2024 à 09:53, peterx@redhat.com a écrit :
> > From: Peter Xu <peterx@redhat.com>
> >
> > [based on latest akpm/mm-unstable, commit 1274e7646240]
> >
> > These two APIs are mostly always the same. It's confusing to have both of
> > them. Merge them into one. Here I used pXd_leaf() only because pXd_leaf()
> > is a global API which is always defined, while pXd_large() is not.
> >
> > We have yet one more API that is similar which is pXd_huge(), but that's
> > even trickier, so let's do it step by step.
> >
> > Some cautions are needed on either x86 or ppc: x86 is currently the only
> > user of p4d_large(), while ppc used to define pXd_large() only with THP,
> > while it is not the case for pXd_leaf(). For the rest archs, afaict
> > they're 100% identical.
>
> Maybe would also be a good opportunity to replace pmd_is_leaf() by
> pmd_leaf() and the same for pud_is_leaf()
Sure, while I'll wait for some more comments, I can add one on top when
repost. Thanks,
--
Peter Xu
prev parent reply other threads:[~2024-02-28 10:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 8:53 [PATCH 0/5] mm/treewide: Replace pXd_large() with pXd_leaf() peterx
2024-02-28 8:53 ` [PATCH 1/5] mm/ppc: Define " peterx
2024-02-28 8:53 ` [PATCH 2/5] mm/x86: Replace p4d_large() with p4d_leaf() peterx
2024-02-28 8:53 ` [PATCH 3/5] mm/treewide: Replace pmd_large() with pmd_leaf() peterx
2024-02-28 8:53 ` [PATCH 4/5] mm/treewide: Replace pud_large() with pud_leaf() peterx
2024-02-28 8:53 ` [PATCH 5/5] mm/treewide: Drop pXd_large() peterx
2024-02-29 5:17 ` kernel test robot
2024-02-29 7:56 ` Peter Xu
2024-02-28 9:50 ` [PATCH 0/5] mm/treewide: Replace pXd_large() with pXd_leaf() Christophe Leroy
2024-02-28 10:23 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zd8Jv8hQdXejTnbU@x1n \
--to=peterx@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=christophe.leroy@csgroup.eu \
--cc=jgg@nvidia.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=muchun.song@linux.dev \
--cc=shy828301@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).