From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D61CC5478C for ; Tue, 5 Mar 2024 03:26:07 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=K6KKfWDG; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=K6KKfWDG; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TpgvL3x4Cz3vXD for ; Tue, 5 Mar 2024 14:26:06 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=K6KKfWDG; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=K6KKfWDG; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=peterx@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TpgtX4G7Fz3cgJ for ; Tue, 5 Mar 2024 14:25:23 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709609120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eXTTezTItt5z2XMw6Q17X/iZd/LoWGe+NHrzVPyEt0Q=; b=K6KKfWDGkKObITOikS/Ah9Kfh6yBUb3ZhIW0v7QAhLuEYrAgS3IvnwjM1YClzkLS2su/S7 cDe9chR/WXmss0pVMIJ5eBz/81qC1wAjxphW3a6gnAHZBekd+cXpu0EE+pnCRE+JEuv0KP /H2bz1QdxGHzZbMmFm0RGGRQk4qBEjk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709609120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eXTTezTItt5z2XMw6Q17X/iZd/LoWGe+NHrzVPyEt0Q=; b=K6KKfWDGkKObITOikS/Ah9Kfh6yBUb3ZhIW0v7QAhLuEYrAgS3IvnwjM1YClzkLS2su/S7 cDe9chR/WXmss0pVMIJ5eBz/81qC1wAjxphW3a6gnAHZBekd+cXpu0EE+pnCRE+JEuv0KP /H2bz1QdxGHzZbMmFm0RGGRQk4qBEjk= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-258-N_8QIwxpOSS_v9sJ3q0ASw-1; Mon, 04 Mar 2024 22:25:18 -0500 X-MC-Unique: N_8QIwxpOSS_v9sJ3q0ASw-1 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-1dc2d4c7310so10424215ad.0 for ; Mon, 04 Mar 2024 19:25:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709609118; x=1710213918; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eXTTezTItt5z2XMw6Q17X/iZd/LoWGe+NHrzVPyEt0Q=; b=IFYh3gkAmTeEYc/X+c5FzWFQoEXR/OffrA8UcMXHeach9DKJao4uRjxwRezJLi5+tL 1Jd84k6PTntjNPcuAZFTM7JlWDhYeaZlUZcCGfJ5mUbtIHs7KUyG94zvEECTH9GH9SN5 hUDC6QW7WLNgAQZ4N2SDSGoHI1x9FbBd5LlE7coZoJ1n2M78ygtwuRGlwCtQZkhwqpsD DVytdZD+/3mBUJM/81mraRxKpPTfb9iagz+nCm781UF9WFidooects7vuyBLgBVVMdIs CQl9kP9Qqpe1bGWbUYQYznzlOtSuS7vbhRC+a0IuxLey5teuHZoOZZzWijub+9x5XB9n ChsA== X-Forwarded-Encrypted: i=1; AJvYcCVvL069sK3QVajldQt5hyPG/MdbCPXT9iwQrvx0j0z/x9So2nGFxzX9mSKQBcXKxkXvt0z51fep1fUniW7UONlrMpklUrPOppNNBgr26Q== X-Gm-Message-State: AOJu0Yznd66+x7W8TMrxZiU4PicILZzkvr1p1ispKQHnvdRFTRowW3dS Mgey1/mkUGeu5so6hyDU2ZDwEGBJFyRaWXhV8amnMBPQk3fDMRLhzLok8w30z0fz/JVfwP8wYin U8eNhEB7+j6MBTthP8YRsImeaIiAp76rRpoDdQc30rh2KB+ZOWYGpzi2Rg2F8syE= X-Received: by 2002:a17:902:c246:b0:1db:94a9:f9f0 with SMTP id 6-20020a170902c24600b001db94a9f9f0mr11472348plg.2.1709609117810; Mon, 04 Mar 2024 19:25:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IGIT6J3aH98CJa99vypNuCkuIr31GHtAWR9nzM3gesoAnf9BMJ50CuNlEcikNQPLHQwQIsAoQ== X-Received: by 2002:a17:902:c246:b0:1db:94a9:f9f0 with SMTP id 6-20020a170902c24600b001db94a9f9f0mr11472335plg.2.1709609117503; Mon, 04 Mar 2024 19:25:17 -0800 (PST) Received: from x1n ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id p1-20020a170902e74100b001dd0a41447fsm3620111plf.233.2024.03.04.19.25.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 19:25:17 -0800 (PST) Date: Tue, 5 Mar 2024 11:25:08 +0800 From: Peter Xu To: Jason Gunthorpe Subject: Re: [PATCH v2 4/7] mm/x86: Drop two unnecessary pud_leaf() definitions Message-ID: References: <20240229084258.599774-1-peterx@redhat.com> <20240229084258.599774-5-peterx@redhat.com> <20240304130334.GR9179@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20240304130334.GR9179@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, Yang Shi , Muchun Song , linux-kernel@vger.kernel.org, Dave Hansen , linux-mm@kvack.org, Ingo Molnar , Borislav Petkov , "Kirill A . Shutemov" , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Thomas Gleixner Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Mar 04, 2024 at 09:03:34AM -0400, Jason Gunthorpe wrote: > On Thu, Feb 29, 2024 at 04:42:55PM +0800, peterx@redhat.com wrote: > > From: Peter Xu > > > > pud_leaf() has a fallback macro defined in include/linux/pgtable.h already. > > Drop the extra two for x86. > > > > Cc: Thomas Gleixner > > Cc: Ingo Molnar > > Cc: Borislav Petkov > > Cc: Dave Hansen > > Cc: x86@kernel.org > > Signed-off-by: Peter Xu > > --- > > arch/x86/include/asm/pgtable.h | 1 - > > include/asm-generic/pgtable-nopmd.h | 1 - > > 2 files changed, 2 deletions(-) > > Reviewed-by: Jason Gunthorpe > > > @@ -31,7 +31,6 @@ static inline int pud_none(pud_t pud) { return 0; } > > static inline int pud_bad(pud_t pud) { return 0; } > > static inline int pud_present(pud_t pud) { return 1; } > > static inline int pud_user(pud_t pud) { return 0; } > > -static inline int pud_leaf(pud_t pud) { return 0; } > > It would be nice to have a final patch making the signatures > consistent on all the arch inlines, it should return bool not int. Makes sense, will do, thanks. -- Peter Xu