From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57D94C5475B for ; Wed, 6 Mar 2024 06:25:32 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=PJzwl3aD; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TqMqt70Kqz3vcT for ; Wed, 6 Mar 2024 17:25:30 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=PJzwl3aD; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=rppt@kernel.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TqMq407RWz3vdr for ; Wed, 6 Mar 2024 17:24:47 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BC5616170B; Wed, 6 Mar 2024 06:24:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90084C433F1; Wed, 6 Mar 2024 06:24:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709706284; bh=Ul9xyIM/xyWLYImXlcZ+ekHRz3h/sTxONmN5nrLAWX0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PJzwl3aDmw2R/PvwbEBvPZ3u+NLY0fqRSSGQgKs2InVezXhX/9DQWsIrHIhu6BbPu lgBAiYFIW15YCX3uOOubXQRSCklHU0tR1/Wnu1iyHq5KnLswQs0CahMqIfxtbisXtq o+T42dG+q7+R2aeWH0os80Ht3TAr1gN7h+7a4H9djzp65CmezNaMO/BHAz0PwmAW7E 7n/IBVf10MWU7PGd5fTqa+TdvYH8Xr+kr8N8PPUfHnmMCXFCxS3kLQE06IWLreXIeE z2km+RVZaY98fb9Wc0TVXUnk09iQW67QBULk7oHkE0cuQRikKMqfSIuqO8YrFtBMGh NjwIRRPzm4buw== Date: Wed, 6 Mar 2024 08:23:50 +0200 From: Mike Rapoport To: peterx@redhat.com Subject: Re: [PATCH v3 04/10] mm/x86: Replace pgd_large() with pgd_leaf() Message-ID: References: <20240305043750.93762-1-peterx@redhat.com> <20240305043750.93762-5-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240305043750.93762-5-peterx@redhat.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Muchun Song , Yang Shi , x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ingo Molnar , Borislav Petkov , Dave Hansen , Jason Gunthorpe , "Kirill A . Shutemov" , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Thomas Gleixner Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Mar 05, 2024 at 12:37:44PM +0800, peterx@redhat.com wrote: > From: Peter Xu > > pgd_leaf() is a global API while pgd_large() is not. Always use > the global pgd_leaf(), then drop pgd_large(). > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: x86@kernel.org > Signed-off-by: Peter Xu Reviewed-by: Mike Rapoport (IBM) > --- > arch/x86/include/asm/pgtable.h | 4 ++-- > arch/x86/mm/pti.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h > index 69ed0ea0641b..d6e993a5659f 100644 > --- a/arch/x86/include/asm/pgtable.h > +++ b/arch/x86/include/asm/pgtable.h > @@ -1418,8 +1418,8 @@ static inline bool pgdp_maps_userspace(void *__ptr) > return (((ptr & ~PAGE_MASK) / sizeof(pgd_t)) < PGD_KERNEL_START); > } > > -#define pgd_leaf pgd_large > -static inline int pgd_large(pgd_t pgd) { return 0; } > +#define pgd_leaf pgd_leaf > +static inline int pgd_leaf(pgd_t pgd) { return 0; } > > #ifdef CONFIG_PAGE_TABLE_ISOLATION > /* > diff --git a/arch/x86/mm/pti.c b/arch/x86/mm/pti.c > index dc0a81f5f60e..c17aab24c1b3 100644 > --- a/arch/x86/mm/pti.c > +++ b/arch/x86/mm/pti.c > @@ -185,7 +185,7 @@ static p4d_t *pti_user_pagetable_walk_p4d(unsigned long address) > > set_pgd(pgd, __pgd(_KERNPG_TABLE | __pa(new_p4d_page))); > } > - BUILD_BUG_ON(pgd_large(*pgd) != 0); > + BUILD_BUG_ON(pgd_leaf(*pgd) != 0); > > return p4d_offset(pgd, address); > } > -- > 2.44.0 > > -- Sincerely yours, Mike.