From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE7E3C54E4A for ; Fri, 8 Mar 2024 10:23:46 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=eMTB0dxI; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Trj1s3F30z3vbP for ; Fri, 8 Mar 2024 21:23:45 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=eMTB0dxI; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=cassel@kernel.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Trj145qjQz3blb for ; Fri, 8 Mar 2024 21:23:04 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id F047261DC3; Fri, 8 Mar 2024 10:23:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E1BFC433C7; Fri, 8 Mar 2024 10:22:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709893382; bh=lHycvlNl7OVIrzQI78hPFaTIMft0lPdksi6rDoX3W/g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eMTB0dxIOS+2itv74DP87TT3a7S3lfZoD0+2Ls0iMrgdCcuIV4TZHR8C/py3lEoLM rGXHcOX82vv7YXrL1/xhf67lvGXpZQbd+56lYq8J4pfE1vSC4Z9QmS9P8uZkL4AnaS UE+ngGFia7kmUXjyWDby8Q4Cd9pZqA2t88xVQTlABBPsGJEFng7d1B4ndq/wO4Spkp nhGLBhuH+r3uinoM2tful9m8gThPphuZ2QPQ8mte4TEAThEeCy4ovpQm1GN6JR0HEX mCHXeItsOiBq9vlmwyPHb0GtJgonfjHk4SSF350AxdKeECKF73Js76nM3nPgm2jTIn 10tpVfabCXnxQ== Date: Fri, 8 Mar 2024 11:22:52 +0100 From: Niklas Cassel To: Manivannan Sadhasivam Subject: Re: [PATCH v9 06/10] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers Message-ID: References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-6-29d433d99cda@linaro.org> <20240308053624.GB3789@thinkpad> <20240308094947.GH3789@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240308094947.GH3789@thinkpad> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Vignesh Raghavendra , Kunihiko Hayashi , linux-pci@vger.kernel.org, Lorenzo Pieralisi , Minghuan Lian , Thierry Reding , Kishon Vijay Abraham I , Fabio Estevam , Marek Vasut , Kishon Vijay Abraham I , Rob Herring , Jesper Nilsson , linux-tegra@vger.kernel.org, linux-arm-kernel@axis.com, Jonathan Hunter , NXP Linux Team , Richard Zhu , Srikanth Thokala , linux-arm-msm@vger.kernel.org, Sascha Hauer , linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas , linux-omap@vger.kernel.org, Mingkai Hu , linux-arm-kernel@lists.infradead.org, Roy Zang , Jingoo Han , Yoshihiro Shimoda , linux-kernel@vger.kernel.org, Vidya Sagar , linux-renesas-soc@vger.kernel.org, Masami Hiramatsu , Pengutronix Kernel Team , Gustavo Pimentel , Shawn Guo , Lucas Stach Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Mar 08, 2024 at 03:19:47PM +0530, Manivannan Sadhasivam wrote: > > > > > @@ -467,6 +467,13 @@ static int dra7xx_add_pcie_ep(struct dra7xx_pcie *dra7xx, > > > > > return ret; > > > > > } > > > > > > > > > > + ret = dw_pcie_ep_init_registers(ep); > > > > > + if (ret) { > > > > > > > > Here you are using if (ret) to error check the return from > > > > dw_pcie_ep_init_registers(). > > > > > > > > > > > > > index c0c62533a3f1..8392894ed286 100644 > > > > > --- a/drivers/pci/controller/dwc/pci-keystone.c > > > > > +++ b/drivers/pci/controller/dwc/pci-keystone.c > > > > > @@ -1286,6 +1286,13 @@ static int ks_pcie_probe(struct platform_device *pdev) > > > > > ret = dw_pcie_ep_init(&pci->ep); > > > > > if (ret < 0) > > > > > goto err_get_sync; > > > > > + > > > > > + ret = dw_pcie_ep_init_registers(&pci->ep); > > > > > + if (ret < 0) { > > > > > > > > Here you are using if (ret < 0) to error check the return from > > > > dw_pcie_ep_init_registers(). Please be consistent. > > > > > > > > > > I maintained the consistency w.r.t individual drivers. Please check them > > > individually. > > > > > > If I maintain consistency w.r.t this patch, then the style will change within > > > the drivers. > > > > Personally, I disagree with that. > > > > All glue drivers should use the same way of checking dw_pcie_ep_init(), > > depending on the kdoc of dw_pcie_ep_init(). > > > > If the kdoc for dw_pcie_ep_init() says returns 0 on success, > > then I think that it is strictly more correct to do: > > > > ret = dw_pcie_ep_init() > > if (ret) { > > > > } > > > > And if a glue driver doesn't look like that, then I think we should change > > them. (Same reasoning for dw_pcie_ep_init_registers().) > > > > > > If you read code that looks like: > > ret = dw_pcie_ep_init() > > if (ret < 0) { > > > > } > > > > then you assume that is is a function with a kdoc that says it can return 0 > > or a positive value on success, e.g. a function that returns an index in an > > array. > > > > But if you read the same function from the individual drivers, it could present > a different opinion because the samantics is different than others. Is there any glue driver where a positive result from dw_pcie_ep_init() is considered valid? > > I'm not opposed to keeping the API semantics consistent, but we have to take > account of the drivers style as well. kdoc > "driver style" IMO, but you are the maintainer, I just offered my 50 cents :) Kind regards, Niklas