From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org, Andi Shyti <andi.shyti@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-arm-kernel@lists.infradead.org,
chrome-platform@lists.linux.dev,
linux-samsung-soc@vger.kernel.org, imx@lists.linux.dev,
linux-mips@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-mediatek@lists.infradead.org, openbmc@lists.ozlabs.org,
linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
asahi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-tegra@vger.kernel.org, virtualization@lists.linux.dev
Subject: Re: [PATCH 64/64] i2c: reword i2c_algorithm in drivers according to newest specification
Date: Fri, 22 Mar 2024 19:00:15 +0200 [thread overview]
Message-ID: <Zf25H-LlAFmfuyYT@smile.fi.intel.com> (raw)
In-Reply-To: <Zf22dmwBpN7Ctk3v@shikoro>
On Fri, Mar 22, 2024 at 05:48:54PM +0100, Wolfram Sang wrote:
>
> > > static const struct i2c_algorithm at91_twi_algorithm = {
> > > - .master_xfer = at91_twi_xfer,
> > > + .xfer = at91_twi_xfer,
> >
> > Seems you made this by a script, can you check the indentations afterwards?
>
> Yes, I noticed as well. But other (not converted) drivers have issues
> there as well, so this will be a seperate patch.
The problem is that you add to a technical debt. We don't want that.
If you have not introduced a new indentation issue, it obviously is
not needed to be fixed in a separate patch. So, please consider this.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-03-22 17:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 13:24 [PATCH 00/64] i2c: reword i2c_algorithm according to newest specification Wolfram Sang
2024-03-22 13:25 ` [PATCH 14/64] i2c: cpm: reword " Wolfram Sang
2024-03-26 19:09 ` Andi Shyti
2024-04-08 9:04 ` Wolfram Sang
2024-04-10 15:25 ` Andi Shyti
2024-04-12 6:32 ` Jochen Friedrich
2024-03-22 13:25 ` [PATCH 42/64] i2c: powermac: " Wolfram Sang
2024-03-22 13:25 ` [PATCH 64/64] i2c: reword i2c_algorithm in drivers " Wolfram Sang
2024-03-22 14:34 ` Bjorn Andersson
2024-03-22 15:11 ` Nicolas Ferre
2024-03-22 16:47 ` Wolfram Sang
2024-03-22 17:05 ` Guenter Roeck
2024-03-22 17:09 ` Wolfram Sang
2024-03-22 16:09 ` Andy Shevchenko
2024-03-22 16:48 ` Wolfram Sang
2024-03-22 17:00 ` Andy Shevchenko [this message]
2024-03-25 7:45 ` Oleksij Rempel
2024-03-25 7:53 ` Jarkko Nikula
2024-04-02 12:35 ` Linus Walleij
2024-03-23 9:20 ` [PATCH 00/64] i2c: reword i2c_algorithm " Andi Shyti
2024-03-26 0:36 ` Andi Shyti
2024-04-05 8:48 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zf25H-LlAFmfuyYT@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=asahi@lists.linux.dev \
--cc=chrome-platform@lists.linux.dev \
--cc=imx@lists.linux.dev \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-tegra@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=openbmc@lists.ozlabs.org \
--cc=virtualization@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).