From: Tobias Huschle <huschle@linux.ibm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: juri.lelli@redhat.com, vschneid@redhat.com,
srikar@linux.vnet.ibm.com, Luis Machado <luis.machado@arm.com>,
peterz@infradead.org, sshegde@linux.vnet.ibm.com,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
rostedt@goodmis.org, bsegall@google.com, mingo@redhat.com,
mgorman@suse.de, nd <nd@arm.com>,
bristot@redhat.com, dietmar.eggemann@arm.com
Subject: Re: [RFC] sched/eevdf: sched feature to dismiss lag on wakeup
Date: Thu, 21 Mar 2024 13:18:38 +0100 [thread overview]
Message-ID: <ZfwlnqGsICGc1fOr@DESKTOP-2CCOB1S.> (raw)
In-Reply-To: <CAKfTPtBA7ECeYJYdzL9ybeXLbpEudLfB6V9s+DZiJUmpnPf_kQ@mail.gmail.com>
On Wed, Mar 20, 2024 at 02:51:00PM +0100, Vincent Guittot wrote:
> On Wed, 20 Mar 2024 at 08:04, Tobias Huschle <huschle@linux.ibm.com> wrote:
> > There was no guarantee of course. place_entity was reducing the vruntime of
> > woken up tasks though, giving it a slight boost, right?. For the scenario
>
> It was rather the opposite, It was ensuring that long sleeping tasks
> will not get too much bonus because of vruntime too far in the past.
> This is similar although not exactly the same intent as the lag. The
> bonus was up to 24ms previously whereas it's not more than a slice now
>
I might have gotten this quite wrong then. I was looking at place_entity
and saw that non-initial placements get their vruntime reduced via
vruntime -= thresh;
which would mean that the placed task would have a vruntime smaller than
cfs_rq->min_vruntime, based on pre-EEVDF behavior, last seen at:
af4cf40470c2 sched/fair: Add cfs_rq::avg_vruntime
If there was no such benefit for woken up tasks. Then the scenario I observed
is just conincidentally worse with EEVDF, which can happen when exchanging an
algorithm I suppose. Or EEVDF just exposes a so far hidden problem in that
scenario.
next prev parent reply other threads:[~2024-03-21 12:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 16:10 [RFC] sched/eevdf: sched feature to dismiss lag on wakeup Tobias Huschle
2024-02-29 3:36 ` K Prateek Nayak
2024-03-06 11:31 ` Tobias Huschle
2024-03-08 15:11 ` Luis Machado
2024-03-14 13:45 ` Tobias Huschle
2024-03-18 14:45 ` Luis Machado
2024-03-19 9:08 ` Tobias Huschle
2024-03-19 13:41 ` Vincent Guittot
2024-03-20 7:04 ` Tobias Huschle
2024-03-20 8:12 ` Luis Machado
[not found] ` <65fa8a7c.050a0220.c8ec5.0278SMTPIN_ADDED_BROKEN@mx.google.com>
2024-03-20 13:51 ` Vincent Guittot
2024-03-21 12:18 ` Tobias Huschle [this message]
[not found] ` <65fc25ae.810a0220.f705f.4cdbSMTPIN_ADDED_BROKEN@mx.google.com>
2024-03-22 17:02 ` Vincent Guittot
2024-04-09 7:35 ` Tobias Huschle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfwlnqGsICGc1fOr@DESKTOP-2CCOB1S. \
--to=huschle@linux.ibm.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luis.machado@arm.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=nd@arm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=sshegde@linux.vnet.ibm.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).