From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4AFDC41513 for ; Mon, 17 Jun 2024 07:56:48 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=citrix.com header.i=@citrix.com header.a=rsa-sha256 header.s=google header.b=wbgOeXB7; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4W2hzf3cfBz3fnd for ; Mon, 17 Jun 2024 17:56:46 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=citrix.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=citrix.com header.i=@citrix.com header.a=rsa-sha256 header.s=google header.b=wbgOeXB7; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=cloud.com (client-ip=2607:f8b0:4864:20::831; helo=mail-qt1-x831.google.com; envelope-from=roger.pau@cloud.com; receiver=lists.ozlabs.org) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4W2hyp14y4z3dWk for ; Mon, 17 Jun 2024 17:55:59 +1000 (AEST) Received: by mail-qt1-x831.google.com with SMTP id d75a77b69052e-4415e623653so37857841cf.1 for ; Mon, 17 Jun 2024 00:56:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1718610952; x=1719215752; darn=lists.ozlabs.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=6I7HjTVD0FYGpGJyzdWr9lYyHGbtAeqv6wNa85E5Tlk=; b=wbgOeXB7u2pdv6hpjV4Av6+JWmvxEawOUWKeWyJd5M1JrKDT5m9Z8Y/2LAd+ZmpV6b tAqbUWP0i/NbvxNZ/APOqm8rijuAKEeMAUdWrhhWeRe9XphY/f1fLy9xzNjZ5aI5YbeS /EK9WIHcUqN7ntGn1UVLuxgDxf9oTpzOc9Lmo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718610952; x=1719215752; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6I7HjTVD0FYGpGJyzdWr9lYyHGbtAeqv6wNa85E5Tlk=; b=Za7LFbgietL3tcwt2Y4aCQU7K8dMWB/qdVIY2/9XVJDwQKH0MUyDqxPBXeScit0q4/ +4rNZ0boVIoMQ3ecsVYVYaFFNAFKRdANvZilY+Pdwk+nMf1ukxNHBRNoXED6jlSi4hTK smSFSLN5j9PZnjSVcQBEH2IfImKkvqsC2bQozXdJkWuCZ2/uTpfttDF69Svnb7dcnhek z/otILEEsA7botXPzMRwrQLjTl3zn1sV3VlDjAD7ocXHatBuQ7KsD9d8pHUs1y37bRVh jlPk2mWcoSkRbxxBuEx6y/biTTZ9CoweblrHhIfs0CIK9nYN3Os5ilMQQo+VTyosrKWL EF1w== X-Forwarded-Encrypted: i=1; AJvYcCUXqf2gVZRaLeIF0bBWO9rxUb3EZpTDwKcGKs/FChXQkYpVwYk8WtqAH+84lyYW87d7msvbm8HOMU/vjJE9oPZBbcXUeOTFhAbYnRmrCg== X-Gm-Message-State: AOJu0YwrNVnZekLWalJ/1tWjibJXXpJPL2JFeQmwzRVMW2uuH6Ej4GPY V+hodNYeVm0FfRNOxCsNizcHfdh+Wl3zHnxfMUB4ss/JtjlsuzF0Zeqbt961O+A= X-Google-Smtp-Source: AGHT+IFxBb+fxu+zFP9/mPYH5nZSCdE6S/NGqQ55TdkfvSsNQ6okiuS1Itv2iysUUW0wZGmJIGDYbg== X-Received: by 2002:ac8:5e11:0:b0:440:10be:3ecf with SMTP id d75a77b69052e-4417ac402c0mr199666251cf.22.1718610952095; Mon, 17 Jun 2024 00:55:52 -0700 (PDT) Received: from localhost ([213.195.124.163]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-441ef4eefaesm44094171cf.21.2024.06.17.00.55.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 00:55:51 -0700 (PDT) Date: Mon, 17 Jun 2024 09:55:48 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Christoph Hellwig Subject: Re: [PATCH 01/26] xen-blkfront: don't disable cache flushes when they fail Message-ID: References: <20240617060532.127975-1-hch@lst.de> <20240617060532.127975-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240617060532.127975-2-hch@lst.de> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nvdimm@lists.linux.dev, "Michael S. Tsirkin" , Jason Wang , linux-nvme@lists.infradead.org, Song Liu , linux-mtd@lists.infradead.org, Vineeth Vijayan , linux-bcache@vger.kernel.org, Alasdair Kergon , drbd-dev@lists.linbit.com, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Richard Weinberger , Geert Uytterhoeven , Yu Kuai , dm-devel@lists.linux.dev, linux-um@lists.infradead.org, Mike Snitzer , Josef Bacik , Ming Lei , linux-raid@vger.kernel.org, linux-m68k@lists.linux-m68k.org, Mikulas Patocka , xen-devel@lists.xenproject.org, ceph-devel@vger.kernel.org, nbd@other.debian.org, Jens Axboe , linux-block@vger.kernel.org, "Martin K. Petersen" , linux-mmc@vger.kernel.org, Philipp Reisner , Christoph =?utf-8?Q?B=C3=B6hmwalder?= , virtualization@lists.linux.dev, Lars Ellenberg , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Jun 17, 2024 at 08:04:28AM +0200, Christoph Hellwig wrote: > blkfront always had a robust negotiation protocol for detecting a write > cache. Stop simply disabling cache flushes in the block layer as the > flags handling is moving to the atomic queue limits API that needs > user context to freeze the queue for that. Instead handle the case > of the feature flags cleared inside of blkfront. This removes old > debug code to check for such a mismatch which was previously impossible > to hit, including the check for passthrough requests that blkfront > never used to start with. > > Signed-off-by: Christoph Hellwig Acked-by: Roger Pau Monné Thanks, Roger.