From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D601C30653 for ; Wed, 3 Jul 2024 08:13:45 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=Z7vr4N5w; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4WDXbq4szWz3cmC for ; Wed, 3 Jul 2024 18:13:43 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=Z7vr4N5w; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=permerror (SPF Permanent Error: Too many DNS lookups) smtp.mailfrom=suse.com (client-ip=2a00:1450:4864:20::231; helo=mail-lj1-x231.google.com; envelope-from=pmladek@suse.com; receiver=lists.ozlabs.org) Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4WDXb12QQYz3c5W for ; Wed, 3 Jul 2024 18:13:00 +1000 (AEST) Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2ee7885aa5fso16480631fa.1 for ; Wed, 03 Jul 2024 01:12:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1719994372; x=1720599172; darn=lists.ozlabs.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bdyT6ioPy1VNeKmL4j3XjcoiZwneAHmBRTL0mGefOq4=; b=Z7vr4N5wK+PfsmDoosEdi+DaRH73JwLFlPEV0Txd5IAup9sdGnHIjSLqzMiJqQSPjs aYRIaYPZ5J9V8IHHEpbYuugL3wOUUU1ucYB0QCaf4iZTcnA2LsxRAIvdq6K/17WmuETs Sitb8MEpETBMr2Aj5b4A44ugHnvmw69/SG43UGKvryiFRSEdCaQtoqlRHmExaQ38Eect h9wFfJ+O8X1pJKTa8eZMjIUn7LJEVtRie3dWmM6QpQBepMBMS/UhAL87xWE1NOyxl4fi SKPADxswY33CIuMJtVUZONbBvfy8v6VwFaVhW5ogl6IMaXtg1JKq6gTDVjUlIHaPzQQ0 kpag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719994372; x=1720599172; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bdyT6ioPy1VNeKmL4j3XjcoiZwneAHmBRTL0mGefOq4=; b=vQpDUrqLus9Uu6g7se47LSvIAZFl2Z6VCzoq3WzqExSU7WOuPUp1bRu2nwCzGli0rS E/KqKBcA+zKF5bVCt5GpZN3E1DRN1qFLnNLTJHEGmm6OBhqOxMXr5Ue0TC79HRPtqIQJ asxrIY/olOAsp1CQ0PiF7/kJHxgkJCs89hnEcpsPi8WqJaVS1sdTB2fFZmT3qUjhEzUY zfcOQ64ztx8Uy5ic7xEl68McuWv/P5NDOJ211Elw+b06uYxxpK3RN52kbCv6dEwi34fQ nmyWvQe1ExWlTv7MDBhG2nE2tHcFgW3vzMHjIX0CuppkB3lqYk/p74RUajae2aE7+dWT NqSQ== X-Forwarded-Encrypted: i=1; AJvYcCWy5iSUilF181XjnVF+AS8J1H8lfCqlpghO1GOmTCM9jFMdt5pW0QRXLa/4+q9ojmf2GmJtRJjB3YOXzuhJNuNdgpUAfuRQPB+jiG0/nA== X-Gm-Message-State: AOJu0YynS8HLOZdWLJTZgvQoGQDkZUymmsiqjPxbkoRYFhUz8Bz3KDkR zEcxLvU8UtihN3puRNCRqOfRjg3hdawHcqXLFh/FI1ziRk4kx9BwS+20tMgCw/U= X-Google-Smtp-Source: AGHT+IFCrx5O8SyoDb7pv8NJaiksMiDUk0MIzdtkS+naCkfqpA17Gjg/ppieWiNLDo4J+A42AblrZQ== X-Received: by 2002:a05:651c:2010:b0:2ec:550e:24f3 with SMTP id 38308e7fff4ca-2ee5e337c3emr70900071fa.10.1719994372235; Wed, 03 Jul 2024 01:12:52 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fb0c2e10dasm15659175ad.223.2024.07.03.01.12.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jul 2024 01:12:51 -0700 (PDT) Date: Wed, 3 Jul 2024 10:12:33 +0200 From: Petr Mladek To: Jocelyn Falempe Subject: Re: [PATCH v2] printk: Add a short description string to kmsg_dump() Message-ID: References: <20240702122639.248110-1-jfalempe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240702122639.248110-1-jfalempe@redhat.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kefeng Wang , Vignesh Raghavendra , Kees Cook , Uros Bizjak , linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mtd@lists.infradead.org, linux-hardening@vger.kernel.org, Miquel Raynal , "K. Y. Srinivasan" , David Airlie , Wei Liu , Sergey Senozhatsky , Dexuan Cui , Christophe Leroy , "Naveen N. Rao" , Thomas Zimmermann , John Ogness , Jani Nikula , Haiyang Zhang , Maarten Lankhorst , Maxime Ripard , Steven Rostedt , Thomas Gleixner , Tony Luck , Greg Kroah-Hartman , Nicholas Piggin , linux-kernel@vger.kernel.org, "Guilherme G. Piccoli" , Daniel Vetter , Richard Weinberger , Andrew Morton , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue 2024-07-02 14:26:04, Jocelyn Falempe wrote: > kmsg_dump doesn't forward the panic reason string to the kmsg_dumper > callback. > This patch adds a new struct kmsg_dump_detail, that will hold the > reason and description, and pass it to the dump() callback. > > To avoid updating all kmsg_dump() call, it adds a kmsg_dump_desc() > function and a macro for backward compatibility. > > I've written this for drm_panic, but it can be useful for other > kmsg_dumper. > It allows to see the panic reason, like "sysrq triggered crash" > or "VFS: Unable to mount root fs on xxxx" on the drm panic screen. > > v2: > * Use a struct kmsg_dump_detail to hold the reason and description > pointer, for more flexibility if we want to add other parameters. > (Kees Cook) > * Fix powerpc/nvram_64 build, as I didn't update the forward > declaration of oops_to_nvram() > > Signed-off-by: Jocelyn Falempe Looks good to me. With the minor fixes suggested by Kees: Acked-by: Petr Mladek Best Regards, Petr