From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59CF0C3065C for ; Thu, 4 Jul 2024 09:27:33 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4WFBBW61zCz3fmB for ; Thu, 4 Jul 2024 19:27:31 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=arm.com (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=sudeep.holla@arm.com; receiver=lists.ozlabs.org) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lists.ozlabs.org (Postfix) with ESMTP id 4WFBB42ZL7z3cZs for ; Thu, 4 Jul 2024 19:27:05 +1000 (AEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D2C4C367; Thu, 4 Jul 2024 02:26:57 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E27D83F766; Thu, 4 Jul 2024 02:26:27 -0700 (PDT) Date: Thu, 4 Jul 2024 10:26:25 +0100 From: Sudeep Holla To: Viresh Kumar Subject: Re: [PATCH 4/4] cpufreq: Make cpufreq_driver->exit() return void Message-ID: References: <3f73fda736818128558b61ad5fe2bed5dce3ddc4.1720075640.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f73fda736818128558b61ad5fe2bed5dce3ddc4.1720075640.git.viresh.kumar@linaro.org> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Rafael J. Wysocki" , linux-tegra@vger.kernel.org, Perry Yuan , Huang Rui , Mario Limonciello , Srinivas Pandruvada , Alyssa Rosenzweig , Vincent Guittot , Kevin Hilman , linux-pm@vger.kernel.org, Christophe Leroy , Jonathan Hunter , Broadcom internal kernel review list , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, "Naveen N. Rao" , Len Brown , Sven Peter , Lizhe , Nicholas Piggin , linux-mediatek@lists.infradead.org, Markus Mayer , Matthias Brugger , linux-omap@vger.kernel.org, Cristian Marussi , AngeloGioacchino Del Regno , Hector Martin , linux-kernel@vger.kernel.org, Thierry Reding , asahi@lists.linux.dev, "Gautham R. Shenoy" , Sudeep Holla , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Jul 04, 2024 at 12:23:55PM +0530, Viresh Kumar wrote: > From: Lizhe > > The cpufreq core doesn't check the return type of the exit() callback > and there is not much the core can do on failures at that point. Just > drop the returned value and make it return void. > > Signed-off-by: Lizhe > [ Viresh: Reworked the patches to fix all missing changes together. ] > Signed-off-by: Viresh Kumar > --- [...] > drivers/cpufreq/scmi-cpufreq.c | 4 +--- > drivers/cpufreq/scpi-cpufreq.c | 4 +--- > drivers/cpufreq/vexpress-spc-cpufreq.c | 5 ++--- (For the above 3 files) Acked-by: Sudeep Holla -- Regards, Sudeep