* [PATCH] crypto: ppc/curve25519 - add missing MODULE_DESCRIPTION() macro
@ 2024-07-19 1:14 Jeff Johnson
2024-08-02 13:15 ` Herbert Xu
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Johnson @ 2024-07-19 1:14 UTC (permalink / raw)
To: Herbert Xu, David S. Miller, Michael Ellerman, Nicholas Piggin,
Christophe Leroy, Naveen N. Rao, Danny Tsen
Cc: kernel-janitors, linuxppc-dev, linux-crypto, Jeff Johnson,
linux-kernel
Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
description is missing"), a module without a MODULE_DESCRIPTION() will
result in a warning with make W=1. The following warning is being
observed when building ppc64le with CRYPTO_CURVE25519_PPC64=m:
WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/crypto/curve25519-ppc64le.o
Add the missing invocation of the MODULE_DESCRIPTION() macro.
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
arch/powerpc/crypto/curve25519-ppc64le-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/crypto/curve25519-ppc64le-core.c b/arch/powerpc/crypto/curve25519-ppc64le-core.c
index 4e3e44ea4484..f7810be0b292 100644
--- a/arch/powerpc/crypto/curve25519-ppc64le-core.c
+++ b/arch/powerpc/crypto/curve25519-ppc64le-core.c
@@ -295,5 +295,6 @@ module_exit(curve25519_mod_exit);
MODULE_ALIAS_CRYPTO("curve25519");
MODULE_ALIAS_CRYPTO("curve25519-ppc64le");
+MODULE_DESCRIPTION("PPC64le Curve25519 scalar multiplication with 51 bits limbs");
MODULE_LICENSE("GPL v2");
MODULE_AUTHOR("Danny Tsen <dtsen@us.ibm.com>");
---
base-commit: df1e9791998a92fe9f1e7d3f031b34daaad39e2f
change-id: 20240718-md-powerpc-arch-powerpc-crypto-2c96382d0eaf
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] crypto: ppc/curve25519 - add missing MODULE_DESCRIPTION() macro
2024-07-19 1:14 [PATCH] crypto: ppc/curve25519 - add missing MODULE_DESCRIPTION() macro Jeff Johnson
@ 2024-08-02 13:15 ` Herbert Xu
2024-08-02 14:27 ` Jeff Johnson
0 siblings, 1 reply; 6+ messages in thread
From: Herbert Xu @ 2024-08-02 13:15 UTC (permalink / raw)
To: Jeff Johnson
Cc: kernel-janitors, Nicholas Piggin, linux-kernel, Danny Tsen,
Christophe Leroy, Naveen N. Rao, linuxppc-dev, David S. Miller,
linux-crypto
On Thu, Jul 18, 2024 at 06:14:18PM -0700, Jeff Johnson wrote:
> Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
> description is missing"), a module without a MODULE_DESCRIPTION() will
> result in a warning with make W=1. The following warning is being
> observed when building ppc64le with CRYPTO_CURVE25519_PPC64=m:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/crypto/curve25519-ppc64le.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> arch/powerpc/crypto/curve25519-ppc64le-core.c | 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] crypto: ppc/curve25519 - add missing MODULE_DESCRIPTION() macro
2024-08-02 13:15 ` Herbert Xu
@ 2024-08-02 14:27 ` Jeff Johnson
2024-08-02 15:10 ` Dan Carpenter
2024-08-02 15:16 ` Arnd Bergmann
0 siblings, 2 replies; 6+ messages in thread
From: Jeff Johnson @ 2024-08-02 14:27 UTC (permalink / raw)
To: Herbert Xu
Cc: Arnd Bergmann, kernel-janitors, Nicholas Piggin, linux-kernel,
Danny Tsen, Christophe Leroy, Greg KH, Naveen N. Rao,
Andrew Morton, linuxppc-dev, David S. Miller, linux-crypto
On 8/2/2024 6:15 AM, Herbert Xu wrote:
> On Thu, Jul 18, 2024 at 06:14:18PM -0700, Jeff Johnson wrote:
>> Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
>> description is missing"), a module without a MODULE_DESCRIPTION() will
>> result in a warning with make W=1. The following warning is being
>> observed when building ppc64le with CRYPTO_CURVE25519_PPC64=m:
>>
>> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/crypto/curve25519-ppc64le.o
>>
>> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>> ---
>> arch/powerpc/crypto/curve25519-ppc64le-core.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> Patch applied. Thanks.
Great, that was the last of my MODULE_DESCRIPTION patches!!!
There are a few more instances of the warning that Arnd has patches for,
covering issues that appear in randconfigs that I didn't test.
/jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] crypto: ppc/curve25519 - add missing MODULE_DESCRIPTION() macro
2024-08-02 14:27 ` Jeff Johnson
@ 2024-08-02 15:10 ` Dan Carpenter
2024-08-02 15:16 ` Arnd Bergmann
1 sibling, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2024-08-02 15:10 UTC (permalink / raw)
To: Jeff Johnson
Cc: Arnd Bergmann, Herbert Xu, kernel-janitors, linux-kernel,
Christophe Leroy, Nicholas Piggin, Greg KH, Naveen N. Rao,
Andrew Morton, linuxppc-dev, David S. Miller, Danny Tsen,
linux-crypto
On Fri, Aug 02, 2024 at 07:27:09AM -0700, Jeff Johnson wrote:
> On 8/2/2024 6:15 AM, Herbert Xu wrote:
> > On Thu, Jul 18, 2024 at 06:14:18PM -0700, Jeff Johnson wrote:
> >> Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
> >> description is missing"), a module without a MODULE_DESCRIPTION() will
> >> result in a warning with make W=1. The following warning is being
> >> observed when building ppc64le with CRYPTO_CURVE25519_PPC64=m:
> >>
> >> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/crypto/curve25519-ppc64le.o
> >>
> >> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> >>
> >> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> >> ---
> >> arch/powerpc/crypto/curve25519-ppc64le-core.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >
> > Patch applied. Thanks.
>
> Great, that was the last of my MODULE_DESCRIPTION patches!!!
>
Horray! Congratulations. :)
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] crypto: ppc/curve25519 - add missing MODULE_DESCRIPTION() macro
2024-08-02 14:27 ` Jeff Johnson
2024-08-02 15:10 ` Dan Carpenter
@ 2024-08-02 15:16 ` Arnd Bergmann
2024-08-02 16:13 ` Jeff Johnson
1 sibling, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2024-08-02 15:16 UTC (permalink / raw)
To: Jeff Johnson, Herbert Xu
Cc: Greg Kroah-Hartman, kernel-janitors, linux-kernel, Danny Tsen,
Christophe Leroy, Nicholas Piggin, Naveen N. Rao, Andrew Morton,
linuxppc-dev, David S . Miller, linux-crypto
On Fri, Aug 2, 2024, at 16:27, Jeff Johnson wrote:
> On 8/2/2024 6:15 AM, Herbert Xu wrote:
>> On Thu, Jul 18, 2024 at 06:14:18PM -0700, Jeff Johnson wrote:
>>> Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
>>> description is missing"), a module without a MODULE_DESCRIPTION() will
>>> result in a warning with make W=1. The following warning is being
>>> observed when building ppc64le with CRYPTO_CURVE25519_PPC64=m:
>>>
>>> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/crypto/curve25519-ppc64le.o
>>>
>>> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>>>
>>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>>> ---
>>> arch/powerpc/crypto/curve25519-ppc64le-core.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>
>> Patch applied. Thanks.
>
> Great, that was the last of my MODULE_DESCRIPTION patches!!!
>
> There are a few more instances of the warning that Arnd has patches for,
> covering issues that appear in randconfigs that I didn't test.
Are all of your patches in linux-next now, or is there a another
git tree that has them all?
I can send the ones I have left, but I want to avoid duplication.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] crypto: ppc/curve25519 - add missing MODULE_DESCRIPTION() macro
2024-08-02 15:16 ` Arnd Bergmann
@ 2024-08-02 16:13 ` Jeff Johnson
0 siblings, 0 replies; 6+ messages in thread
From: Jeff Johnson @ 2024-08-02 16:13 UTC (permalink / raw)
To: Arnd Bergmann, Herbert Xu
Cc: Greg Kroah-Hartman, kernel-janitors, linux-kernel, Danny Tsen,
Christophe Leroy, Nicholas Piggin, Naveen N. Rao, Andrew Morton,
linuxppc-dev, David S . Miller, linux-crypto
On 8/2/2024 8:16 AM, Arnd Bergmann wrote:
> On Fri, Aug 2, 2024, at 16:27, Jeff Johnson wrote:
>> On 8/2/2024 6:15 AM, Herbert Xu wrote:
>>> On Thu, Jul 18, 2024 at 06:14:18PM -0700, Jeff Johnson wrote:
>>>> Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
>>>> description is missing"), a module without a MODULE_DESCRIPTION() will
>>>> result in a warning with make W=1. The following warning is being
>>>> observed when building ppc64le with CRYPTO_CURVE25519_PPC64=m:
>>>>
>>>> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/crypto/curve25519-ppc64le.o
>>>>
>>>> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>>>>
>>>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>>>> ---
>>>> arch/powerpc/crypto/curve25519-ppc64le-core.c | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>
>>> Patch applied. Thanks.
>>
>> Great, that was the last of my MODULE_DESCRIPTION patches!!!
>>
>> There are a few more instances of the warning that Arnd has patches for,
>> covering issues that appear in randconfigs that I didn't test.
>
> Are all of your patches in linux-next now, or is there a another
> git tree that has them all?
>
> I can send the ones I have left, but I want to avoid duplication.
>
> Arnd
When this one lands they'll all be in linux-next
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-08-02 16:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-19 1:14 [PATCH] crypto: ppc/curve25519 - add missing MODULE_DESCRIPTION() macro Jeff Johnson
2024-08-02 13:15 ` Herbert Xu
2024-08-02 14:27 ` Jeff Johnson
2024-08-02 15:10 ` Dan Carpenter
2024-08-02 15:16 ` Arnd Bergmann
2024-08-02 16:13 ` Jeff Johnson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).