From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E972FC636F0 for ; Wed, 28 Aug 2024 17:30:07 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4WvBHy2fCmz2xfb; Thu, 29 Aug 2024 03:30:06 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2607:f8b0:4864:20::429" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1724866206; cv=none; b=J6DaDRiLTTeNxQ7Xyd9EokCABFJjbBciK87TQv/90jMYt3VliUakXK6YvHkKHZ763qZsIpZW0lSPO/8RdkiiJyt5BXkt2WEu1ycrlF1qVBak3VPGSz4SaDhtyXhuA4ZO1Dq/0mrANU2FzvC0NEZrJKBuFFz69tOVLhDZlqxzei51q5UfklWcW8bl32YPNIVcpetne7T4+gOdLsn9sHWZutQf+yPt+Zk27nHeQpSiXFWWz0pveiPkl1pDTJHiolXIcGSpByIjnb7eTlS7XFOH6qSKbrO0SciBltObmtamSa+wYIIoA4lAf02wY3SegJOGNQfE1TbRrVZxldNndl3+OQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1724866206; c=relaxed/relaxed; bh=izEx2iGerEnX7WB/2Mpvv+y1MVG/tbs1FdX9CKEIcSg=; h=Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Google-Smtp-Source: X-Received:Received:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:Content-Disposition: Content-Transfer-Encoding:In-Reply-To; b=frP0rc0xbfpQafX6yt/uUFtY9muk4J2jqNh7CWLdHHSKezfpdrp+dLVfIXPrhquuYU4K5rjdd/iafPYCnXNIcS0VJG/jpNMTazcZsfHCWrTWkc+nr9ZT09il7yX4w/M03ETzPEXL4H+OQwNgvVPIbzVwNXF1WhucIRCXRvGS4fVaGJI06YEHwBjrCjJNOdWw8u9ed5Xfy8xBwjIbyr2glgSTifkTB8OARZGd2iYLMqx0N4YKP6r4/jp7C3z8DeS/xr+suIFeeh/jM7RYNYoFb6mqFYHdfk4qcmx8eaQlz6EMRWY77YBPIL3NpTG6PpCjfqB3zj2mG3DoElOolRGvLQ== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; dkim=pass (2048-bit key; unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=du/4A3F1; dkim-atps=neutral; spf=pass (client-ip=2607:f8b0:4864:20::429; helo=mail-pf1-x429.google.com; envelope-from=charlie@rivosinc.com; receiver=lists.ozlabs.org) smtp.mailfrom=rivosinc.com Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=du/4A3F1; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=rivosinc.com (client-ip=2607:f8b0:4864:20::429; helo=mail-pf1-x429.google.com; envelope-from=charlie@rivosinc.com; receiver=lists.ozlabs.org) Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4WvBHx5ZYdz2xck for ; Thu, 29 Aug 2024 03:30:04 +1000 (AEST) Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-7142a30e3bdso690896b3a.0 for ; Wed, 28 Aug 2024 10:30:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1724866201; x=1725471001; darn=lists.ozlabs.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=izEx2iGerEnX7WB/2Mpvv+y1MVG/tbs1FdX9CKEIcSg=; b=du/4A3F1p592ED5KzxlWq9oLmPAh+JtLDfZyHOAwWPn7FmHHLjTNiMaeSSgJbfFY7/ e9PG/zkxQHR5GzMetWOlOQTViMQ8KQitUJHA3IP1lZNxIKCfpiPr6LfKJKNN3S2uVwKN vFMlv9UpoCnoRjZk2YonKBZI4CmsYFj+o22zKe+OGeZ1XM8eGWWzxJbhWo9cHLvVtokt Gws5bYQiZaszBl9qZiLT3v6CuL7lblZuV4yno0zBvnvwUBoZL1J0PNMNb4D99nZy8xHl bgXCGu0ExSIa3ebgd5V/zUbLTVSbOBxqcAYTPC0Goa/l2dHZaybeXZCoRN2OkWrS+L9J zTgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724866201; x=1725471001; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=izEx2iGerEnX7WB/2Mpvv+y1MVG/tbs1FdX9CKEIcSg=; b=uUWHocLs0N6GTqEAwE4AWYPv4Dhky+M/7w9dwwzmbvIeUKM90TWO0s7h7809lGVXGL 7aVoSAYkGRkg3RUNKu1kIQnp8G+wbapy6Q+bpN6kR7vmryxVTEgN8HvF5/ZQEC3acSX0 jfRNnW9Vy/mnBsKGSF/qgbx3RJNHiCmrAxtIvEV0D66HZsTbdi2RMFCVI99KyT4Y/YEM HfUZDJPQspWNfVVXTpvM7Zgi6b00OWL4L+Wrg6gu6Ob7W+rVHeUQUf16izfrd6acnbnk q9uff/oa1LiZecx32ROD8j8s33ib2q9fSYZtTXt10r95nTc7RMaS9YCqnCIdcdqJwxCw Aodw== X-Forwarded-Encrypted: i=1; AJvYcCWqF0KtRfAUOhK7Tp98+0NeyWThCDuX89JH11w5np3pkH3VqJqED+auGo0tFhKnfi66xGgD7WhDvkC0fHg=@lists.ozlabs.org X-Gm-Message-State: AOJu0YwD+AkeKJ/0HKOQI6VIcI08U339ehyAP9k8KWge+OQ6ipI2llI3 w3pZC1pg7Y82Me4DnnsdOg76nHd3VVtt9PZ+8TsedsBrThOjHfMMt5zemyNcVqg= X-Google-Smtp-Source: AGHT+IHMsuvXLfTW+bLvG1ZAGccaibo4i2N0hBI/JcHNn1qd40DIOjpRRFBts/vAK3nn3l/ntjAfHA== X-Received: by 2002:a17:903:1210:b0:1fb:2ebc:d16b with SMTP id d9443c01a7336-204f9bb4194mr38041435ad.7.1724866201061; Wed, 28 Aug 2024 10:30:01 -0700 (PDT) Received: from ghost ([50.145.13.30]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20385581393sm101427625ad.102.2024.08.28.10.29.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2024 10:30:00 -0700 (PDT) Date: Wed, 28 Aug 2024 10:29:55 -0700 From: Charlie Jenkins To: Christophe Leroy Cc: Arnd Bergmann , Paul Walmsley , Palmer Dabbelt , Albert Ou , Catalin Marinas , Will Deacon , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Muchun Song , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Huacai Chen , WANG Xuerui , Russell King , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Andreas Larsson , Shuah Khan , Alexandre Ghiti , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 07/16] powerpc: mm: Support MAP_BELOW_HINT Message-ID: References: <20240827-patches-below_hint_mmap-v1-0-46ff2eb9022d@rivosinc.com> <20240827-patches-below_hint_mmap-v1-7-46ff2eb9022d@rivosinc.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Post: List-Subscribe: , , List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Aug 28, 2024 at 08:34:49AM +0200, Christophe Leroy wrote: > Hi Charlie, > > Le 28/08/2024 à 07:49, Charlie Jenkins a écrit : > > Add support for MAP_BELOW_HINT to arch_get_mmap_base() and > > arch_get_mmap_end(). > > > > Signed-off-by: Charlie Jenkins > > --- > > arch/powerpc/include/asm/task_size_64.h | 36 +++++++++++++++++++++++++++------ > > 1 file changed, 30 insertions(+), 6 deletions(-) > > > > diff --git a/arch/powerpc/include/asm/task_size_64.h b/arch/powerpc/include/asm/task_size_64.h > > index 239b363841aa..a37a5a81365d 100644 > > --- a/arch/powerpc/include/asm/task_size_64.h > > +++ b/arch/powerpc/include/asm/task_size_64.h > > @@ -72,12 +72,36 @@ > > #define STACK_TOP_MAX TASK_SIZE_USER64 > > #define STACK_TOP (is_32bit_task() ? STACK_TOP_USER32 : STACK_TOP_USER64) > > -#define arch_get_mmap_base(addr, len, base, flags) \ > > - (((addr) > DEFAULT_MAP_WINDOW) ? (base) + TASK_SIZE - DEFAULT_MAP_WINDOW : (base)) > > +#define arch_get_mmap_base(addr, len, base, flags) \ > > This macro looks quite big for a macro, can it be a static inline function > instead ? Same for the other macro below. > I had overlooked that possibility, I think that's a great solution, I will change that. > > +({ \ > > + unsigned long mmap_base; \ > > + typeof(flags) _flags = (flags); \ > > + typeof(addr) _addr = (addr); \ > > + typeof(base) _base = (base); \ > > + typeof(len) _len = (len); \ > > + unsigned long rnd_gap = DEFAULT_MAP_WINDOW - (_base); \ > > + if (_flags & MAP_BELOW_HINT && _addr != 0 && ((_addr + _len) > BIT(VA_BITS - 1)))\ > > + mmap_base = (_addr + _len) - rnd_gap; \ > > + else \ > > + mmap_end = ((_addr > DEFAULT_MAP_WINDOW) ? \ > > + _base + TASK_SIZE - DEFAULT_MAP_WINDOW : \ > > + _base); \ > > + mmap_end; \ > > mmap_end doesn't exist, did you mean mmap_base ? Oh whoops, thank you! - Charlie > > > +}) > > -#define arch_get_mmap_end(addr, len, flags) \ > > - (((addr) > DEFAULT_MAP_WINDOW) || \ > > - (((flags) & MAP_FIXED) && ((addr) + (len) > DEFAULT_MAP_WINDOW)) ? TASK_SIZE : \ > > - DEFAULT_MAP_WINDOW) > > +#define arch_get_mmap_end(addr, len, flags) \ > > +({ \ > > + unsigned long mmap_end; \ > > + typeof(flags) _flags = (flags); \ > > + typeof(addr) _addr = (addr); \ > > + typeof(len) _len = (len); \ > > + if (_flags & MAP_BELOW_HINT && _addr != 0 && ((_addr + _len) > BIT(VA_BITS - 1))) \ > > + mmap_end = (_addr + _len); \ > > + else \ > > + mmap_end = (((_addr) > DEFAULT_MAP_WINDOW) || \ > > + (((_flags) & MAP_FIXED) && ((_addr) + (_len) > DEFAULT_MAP_WINDOW))\ > > + ? TASK_SIZE : DEFAULT_MAP_WINDOW) \ > > + mmap_end; \ > > +}) > > #endif /* _ASM_POWERPC_TASK_SIZE_64_H */ > >