From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05960CF3973 for ; Fri, 20 Sep 2024 00:29:55 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4X8tZB1WXyz2y92; Fri, 20 Sep 2024 10:29:54 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=91.218.175.176 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1726741463; cv=none; b=m552lAsIbkaOw+7dT8GgFUUf32oTTpdWQw0R1GZkAZmY1cnlLV8MjInxJprJ+Z9jIEjtWXBXVgcamDl4C3VDv0v6KQXr3u+Adai3zQFwBDs/+tZ4EDvTLAAkcZMKQc25UaXo40UdkND56TGIPbuLA4Lw1jpXDs8APTLoDSnMGWVpWsUI6olEMhkajqhyuo2IJK2v69aTIDk7qz2x9T+QzvPm9scI12sVZK1Ipxb6yi5yKwDuWYbpIvPqMUbQsBNG4+s7bpVF+9WQG5kLDAAF4mLelGvohKl5Nkp9+2UmpnMf6eR0PrmpjPOxoQUFuX36fVscez699sdCfz8u78+y4g== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1726741463; c=relaxed/relaxed; bh=I1mckTS2FV38bbZ879rd+/BowKPTlDKekDspILq4S7U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L6yyORoKRpJJiXlXp18aIRfpPdQA/Vhv6EYrYqqH3XPlHW59vMNTl3XucLfYROY2FB2J+An7wYdPLQQmMuBI9cXXF2MZtfw4iRq2BxyVD89pyiIcPdREcMdKtulttM3kurjE91xjSNtmp02MM2Yu+1HvzG5rYAGef5zjy2xRmx1xfC6nzgugSIHacWPjfi9yKSI1cMm7yAF27kba05jqeGHbOXqK0N/uusGQ7f/ts0+YdzSiZ6u35EUPPxQ8ohVu28v62T8PZfcCThwj53hj9GzOCvelC/flv5XQ/dVNnLAIIv6P6q04CK1o2r68CzXN9xZS0jdQ/+5/dJoF8SUxrw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.dev; dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=D6x6BKht; dkim-atps=neutral; spf=pass (client-ip=91.218.175.176; helo=out-176.mta0.migadu.com; envelope-from=oliver.upton@linux.dev; receiver=lists.ozlabs.org) smtp.mailfrom=linux.dev Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=D6x6BKht; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.dev (client-ip=91.218.175.176; helo=out-176.mta0.migadu.com; envelope-from=oliver.upton@linux.dev; receiver=lists.ozlabs.org) X-Greylist: delayed 361 seconds by postgrey-1.37 at boromir; Thu, 19 Sep 2024 20:24:20 AEST Received: from out-176.mta0.migadu.com (out-176.mta0.migadu.com [91.218.175.176]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4X8WpX4jNxz2xtp for ; Thu, 19 Sep 2024 20:24:20 +1000 (AEST) Date: Thu, 19 Sep 2024 03:17:38 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1726741064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I1mckTS2FV38bbZ879rd+/BowKPTlDKekDspILq4S7U=; b=D6x6BKhtU1AsDKi/4KqvcONlUrTfddheLB6mjS/liWOZikXBBbl320OPz8mgGIKM4WllXD +wY9aYHdLlkmHh4egDXFCzDa+mmurZ3C2W/5Yn9b7oeoiOBTG25PlxVj4C73Kx3idnOFp+ Vxq68Xs1nMkSJWGZkP3uhgfHcFJ6DPg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Colton Lewis Cc: kvm@vger.kernel.org, Sean Christopherson , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Will Deacon , Russell King , Catalin Marinas , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org Subject: Re: [PATCH v3 0/5] Correct perf sampling with Guest VMs Message-ID: References: <20240912205133.4171576-1-coltonlewis@google.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Post: List-Subscribe: , , List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240912205133.4171576-1-coltonlewis@google.com> X-Migadu-Flow: FLOW_OUT On Thu, Sep 12, 2024 at 08:51:28PM +0000, Colton Lewis wrote: > v3: > * Clarify final commit message further > * Remove an unused variable in perf_arch_misc_flags() > > v2: > https://lore.kernel.org/kvm/20240911222433.3415301-1-coltonlewis@google.com/ > > v1: > https://lore.kernel.org/kvm/20240904204133.1442132-1-coltonlewis@google.com/ > > This series cleans up perf recording around guest events and improves > the accuracy of the resulting perf reports. Please fix the intermediate build issue, and also test that each patch in the series compiles. With that corrected, for the series: Reviewed-by: Oliver Upton A nice follow-up on the arm64 side would be to further constrain kvm_arch_pmi_in_guest() to return true iff we exited the guest due to an IRQ. -- Thanks, Oliver