From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: mpe@ellerman.id.au, npiggin@gmail.com,
christophe.leroy@csgroup.eu, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/vdso: allow r30 in vDSO code generation of getrandom
Date: Wed, 25 Sep 2024 20:38:43 +0200 [thread overview]
Message-ID: <ZvRYs-WYz2qHZjhy@zx2c4.com> (raw)
In-Reply-To: <20240925175021.1526936-2-Jason@zx2c4.com>
On Wed, Sep 25, 2024 at 07:50:22PM +0200, Jason A. Donenfeld wrote:
> For gettimeofday, -ffixed-r30 was passed to work around a bug in Go
> code, where the vDSO trampoline forgot to save and restore this register
> across function calls. But Go requires a different trampoline for every
> call, and there's no reason that new Go code needs to be broken and add
> more bugs. So remove -ffixed-r30 for getrandom.
Strangely, I am _unable to_ make the Go code not crash with this patch
applied. I'm not quite sure what I'm doing wrong yet, or if this points
to another issue.
next prev parent reply other threads:[~2024-09-25 18:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 17:50 [PATCH] powerpc/vdso: allow r30 in vDSO code generation of getrandom Jason A. Donenfeld
2024-09-25 18:38 ` Jason A. Donenfeld [this message]
2024-09-25 18:48 ` Christophe Leroy
2024-09-25 23:21 ` Jason A. Donenfeld
2024-09-30 11:36 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvRYs-WYz2qHZjhy@zx2c4.com \
--to=jason@zx2c4.com \
--cc=christophe.leroy@csgroup.eu \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox