From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00654CF259D for ; Mon, 14 Oct 2024 05:56:14 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4XRmgd2g3kz2yFP; Mon, 14 Oct 2024 16:56:13 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2607:7c80:54:3::133" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1728885373; cv=none; b=Urvnyl60UsrGlepF4KUicAqwJpaYZmgWqyXi+gL9DzFc3HRZovjbGFMB09DNpwMBXNZykYp9kAkT5zfxiZtudijIIroLEZMpSu5e1lVL8VfI1u1z9biHSCUVx0SNCg4PWYTHJN+/klbN20TajRb4D/vYryfNWi8/qVRZsJdTeAGkY/NXHQoSXT3AXMWkYr7xiKct3cuBD0edrMaVumDJW4kkG1olYYS0ck3YBX/BnFPMpamvo6pecb4sA4xlWgYWmJo+EimLno8Tc3NnBqjM7kd4sIZLjltlZ/d9iZu6xGqvM+mlB3hoL+KGroupXS70aU6353tSh3x7T/B/dS7O9w== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1728885373; c=relaxed/relaxed; bh=Go+Bj6RO5KoE/9AfXdF5E8AJBwbpjnqmhBNe3btI6Rc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZsKumzhEvcSvA2emcKdPQzrMCr9CjdfeZ4a7sRkcqX4ezkqYozC0kYlTDBHw/iSIcFXTG4jugTumEvHd5sCuYyK6zAqaDEnBa7T8cQfVwE6lbt7gfUhV6OmEgUmJFX+ppoqBllr8FazpAshF1t0Dy2H4rIRgwkG1Q2DHbBte+vD9y1Xflr35CCQs8JG3tB//t47bMaQZ9hb/lkQCi2cRyFmCq4Ij3Qb041OlUNpDSvbY12YQD4nMDM4Kllm+KtCFcbH4KTRZ7m8XFYtkVKGv4SiplTk6OwlANyaqIzmgZJlxfkP17T2RBW2prCi81XRuDxBDaTf4ebOAuCz7h4y0LQ== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=batv+f913630adc52fe272e7a+7722+infradead.org+hch@bombadil.srs.infradead.org; receiver=lists.ozlabs.org) smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=bombadil.srs.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=batv+f913630adc52fe272e7a+7722+infradead.org+hch@bombadil.srs.infradead.org; receiver=lists.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4XRmgT5n00z2yFK for ; Mon, 14 Oct 2024 16:56:04 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Go+Bj6RO5KoE/9AfXdF5E8AJBwbpjnqmhBNe3btI6Rc=; b=UPElqyPBVcONi79QDgqannuJ8k ekzP13+lCLTRhjd0RsBuUuriQn6L1+7+jerZ1u5Al3QyEt2FMS6WglOqiIYRCPC95h6PrTwqF1ts1 PWmrnzZCq2mL/K2dLXqaDd0RIfbpc0hidVHfW0hcI22NMksrAuiLCJAmBG9DiAs7alHiLyDNNsuur 7HBzQHoIIH7RZPA4xv39sBtQ8TSlScwbjH674t/7hgNk4DsM7Le91HXSmKrDHUWLH9r8jJFF0mMPK mItE7VNi3UiGgVL10orTJc1Q65Ko0/nDG04GKlm2B+fPRKXh4xsGm9A5xgah8WKUspiWy5w5SGuhw kNW8vO1A==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1t0E3B-00000003o4s-2PYe; Mon, 14 Oct 2024 05:55:25 +0000 Date: Sun, 13 Oct 2024 22:55:25 -0700 From: Christoph Hellwig To: Mike Rapoport Cc: Christoph Hellwig , Andrew Morton , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages Message-ID: References: <20241009180816.83591-1-rppt@kernel.org> <20241009180816.83591-8-rppt@kernel.org> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Post: List-Subscribe: , , List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Sun, Oct 13, 2024 at 11:43:41AM +0300, Mike Rapoport wrote: > > But why? That's pretty different from our normal style of arch hooks, > > and introduces an indirect call in a security sensitive area. > > Will change to __weak hook. Isn't the callback required when using the large ROX page? I.e. shouldn't it be an unconditional callback and not a weak override?