From: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
To: mpe@ellerman.id.au, npiggin@gmail.com,
christophe.leroy@csgroup.eu, naveen@kernel.org,
maddy@linux.ibm.com, arnd@arndb.de, chentao@kylinos.cn,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc: paulo.miguel.almeida.rodenas@gmail.com, linux-hardening@vger.kernel.com
Subject: [PATCH][next] powerpc/spufs: Replace snprintf() with the safer scnprintf() variant
Date: Fri, 18 Oct 2024 21:28:19 +1300 [thread overview]
Message-ID: <ZxIcI0QRFGZLCNRl@mail.google.com> (raw)
The C99 standard specifies that {v}snprintf() returns the length of the
data that *would have been* written if there were enough space. In some
cases, this misunderstanding led to buffer-overruns in the past. It's
generally considered better/safer to use the {v}scnprintf() variants in
their place.
While at it, fix some style issues pointed out by checkpatch.pl
Link: https://lwn.net/Articles/69419/
Link: https://github.com/KSPP/linux/issues/105
Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
---
arch/powerpc/platforms/cell/spufs/file.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/powerpc/platforms/cell/spufs/file.c b/arch/powerpc/platforms/cell/spufs/file.c
index d5a2c77bc908..f766821fe3bf 100644
--- a/arch/powerpc/platforms/cell/spufs/file.c
+++ b/arch/powerpc/platforms/cell/spufs/file.c
@@ -2320,13 +2320,13 @@ static int switch_log_sprint(struct spu_context *ctx, char *tbuf, int n)
p = ctx->switch_log->log + ctx->switch_log->tail % SWITCH_LOG_BUFSIZE;
- return snprintf(tbuf, n, "%llu.%09u %d %u %u %llu\n",
- (unsigned long long) p->tstamp.tv_sec,
- (unsigned int) p->tstamp.tv_nsec,
- p->spu_id,
- (unsigned int) p->type,
- (unsigned int) p->val,
- (unsigned long long) p->timebase);
+ return scnprintf(tbuf, n, "%llu.%09u %d %u %u %llu\n",
+ (unsigned long long)p->tstamp.tv_sec,
+ (unsigned int)p->tstamp.tv_nsec,
+ p->spu_id,
+ (unsigned int)p->type,
+ (unsigned int)p->val,
+ (unsigned long long)p->timebase);
}
static ssize_t spufs_switch_log_read(struct file *file, char __user *buf,
--
2.47.0
next reply other threads:[~2024-10-18 8:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 8:28 Paulo Miguel Almeida [this message]
2024-10-18 15:38 ` [PATCH][next] powerpc/spufs: Replace snprintf() with the safer scnprintf() variant Segher Boessenkool
2024-10-18 23:50 ` Paulo Miguel Almeida
2024-10-19 4:13 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxIcI0QRFGZLCNRl@mail.google.com \
--to=paulo.miguel.almeida.rodenas@gmail.com \
--cc=arnd@arndb.de \
--cc=chentao@kylinos.cn \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-hardening@vger.kernel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).