[PATCH] Fix Freescale high-speed USB host dependency

[PATCH] Fix Freescale high-speed USB host dependency

[Li Yang]

The high-speed USB SOC only exists on MPC834x family not MPC83xx family.

Signed-off-by: Li Yang <leoli@freescale.com>

---

 drivers/usb/host/ehci-hcd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c index 79f2d8b..3af1844 100644
--- a/drivers/usb/host/ehci-hcd.c
+++ b/drivers/usb/host/ehci-hcd.c
@@ -892,7 +892,7 @@ #include "ehci-pci.c"
 #define	EHCI_BUS_GLUED
 #endif
 
-#ifdef CONFIG_PPC_83xx
+#ifdef CONFIG_MPC834x
 #include "ehci-fsl.c"
 #define	EHCI_BUS_GLUED
 #endif

Re: [PATCH] Fix Freescale high-speed USB host dependency

[Kumar Gala]

Acked-by: Kumar Gala <galak@kernel.crashing.org>

On Jul 14, 2006, at 6:58 AM, Li Yang wrote:

> The high-speed USB SOC only exists on MPC834x family not MPC83xx  
> family.
>
> Signed-off-by: Li Yang <leoli@freescale.com>
>
> ---
>
>  drivers/usb/host/ehci-hcd.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci- 
> hcd.c index 79f2d8b..3af1844 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -892,7 +892,7 @@ #include "ehci-pci.c"
>  #define	EHCI_BUS_GLUED
>  #endif
>
> -#ifdef CONFIG_PPC_83xx
> +#ifdef CONFIG_MPC834x
>  #include "ehci-fsl.c"
>  #define	EHCI_BUS_GLUED
>  #endif
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

RE: [linux-usb-devel] [PATCH] Fix Freescale high-speed USB hostdependency

[Li Yang-r58472]

Another one in header file.

---
diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
index 679c1cd..8da2774 100644
--- a/drivers/usb/host/ehci.h
+++ b/drivers/usb/host/ehci.h
@@ -642,7 +642,7 @@ #endif

=20
/*----------------------------------------------------------------------
---*/

-#ifdef CONFIG_PPC_83xx
+#ifdef CONFIG_MPC834x
 /* Some Freescale processors have an erratum in which the TT
  * port number in the queue head was 0..N-1 instead of 1..N.
  */

> -----Original Message-----
> From: linux-usb-devel-bounces@lists.sourceforge.net
> [mailto:linux-usb-devel-bounces@lists.sourceforge.net] On Behalf Of
Kumar Gala
> Sent: Friday, July 14, 2006 9:52 PM
> To: Li Yang-r58472
> Cc: linuxppc-dev@ozlabs.org; gregkh@suse.de;
> linux-usb-devel@lists.sourceforge.net
> Subject: Re: [linux-usb-devel] [PATCH] Fix Freescale high-speed USB
hostdependency
>=20
> Acked-by: Kumar Gala <galak@kernel.crashing.org>
>=20
> On Jul 14, 2006, at 6:58 AM, Li Yang wrote:
>=20
> > The high-speed USB SOC only exists on MPC834x family not MPC83xx
> > family.
> >
> > Signed-off-by: Li Yang <leoli@freescale.com>
> >
> > ---
> >
> >  drivers/usb/host/ehci-hcd.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-
> > hcd.c index 79f2d8b..3af1844 100644
> > --- a/drivers/usb/host/ehci-hcd.c
> > +++ b/drivers/usb/host/ehci-hcd.c
> > @@ -892,7 +892,7 @@ #include "ehci-pci.c"
> >  #define	EHCI_BUS_GLUED
> >  #endif
> >
> > -#ifdef CONFIG_PPC_83xx
> > +#ifdef CONFIG_MPC834x
> >  #include "ehci-fsl.c"
> >  #define	EHCI_BUS_GLUED
> >  #endif

Re: [linux-usb-devel] [PATCH] Fix Freescale high-speed USB hostdependency

[Kumar Gala]

On Jul 20, 2006, at 6:42 AM, Li Yang-r58472 wrote:

> Another one in header file.
>
> ---
> diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
> index 679c1cd..8da2774 100644
> --- a/drivers/usb/host/ehci.h
> +++ b/drivers/usb/host/ehci.h
> @@ -642,7 +642,7 @@ #endif
>
>
> / 
> *--------------------------------------------------------------------- 
> -
> ---*/
>
> -#ifdef CONFIG_PPC_83xx
> +#ifdef CONFIG_MPC834x
>  /* Some Freescale processors have an erratum in which the TT
>   * port number in the queue head was 0..N-1 instead of 1..N.
>   */

Do we really want to make this change.  What harm is there in having  
the ehci support for MPC834x build on all 83xx processors?  I can't  
imagine we are going to config in support for ehci on anything that  
is MPC834x at this point and if you do, your device tree isn't going  
to have nodes in it so the drivers not going to bind against anything.

Finally, I got to believe Freescale's going to build some MPC83xx in  
the future with the high speed USB IP.

- kumar

>
>> -----Original Message-----
>> From: linux-usb-devel-bounces@lists.sourceforge.net
>> [mailto:linux-usb-devel-bounces@lists.sourceforge.net] On Behalf Of
> Kumar Gala
>> Sent: Friday, July 14, 2006 9:52 PM
>> To: Li Yang-r58472
>> Cc: linuxppc-dev@ozlabs.org; gregkh@suse.de;
>> linux-usb-devel@lists.sourceforge.net
>> Subject: Re: [linux-usb-devel] [PATCH] Fix Freescale high-speed USB
> hostdependency
>>
>> Acked-by: Kumar Gala <galak@kernel.crashing.org>
>>
>> On Jul 14, 2006, at 6:58 AM, Li Yang wrote:
>>
>>> The high-speed USB SOC only exists on MPC834x family not MPC83xx
>>> family.
>>>
>>> Signed-off-by: Li Yang <leoli@freescale.com>
>>>
>>> ---
>>>
>>>  drivers/usb/host/ehci-hcd.c |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-
>>> hcd.c index 79f2d8b..3af1844 100644
>>> --- a/drivers/usb/host/ehci-hcd.c
>>> +++ b/drivers/usb/host/ehci-hcd.c
>>> @@ -892,7 +892,7 @@ #include "ehci-pci.c"
>>>  #define	EHCI_BUS_GLUED
>>>  #endif
>>>
>>> -#ifdef CONFIG_PPC_83xx
>>> +#ifdef CONFIG_MPC834x
>>>  #include "ehci-fsl.c"
>>>  #define	EHCI_BUS_GLUED
>>>  #endif
>

Re: [linux-usb-devel] [PATCH] Fix Freescale high-speed USB hostdependency

[Li Yang]

On 7/20/06, Kumar Gala <galak@kernel.crashing.org> wrote:
>
> On Jul 20, 2006, at 6:42 AM, Li Yang-r58472 wrote:
>
> > Another one in header file.
> >
> > ---
> > diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
> > index 679c1cd..8da2774 100644
> > --- a/drivers/usb/host/ehci.h
> > +++ b/drivers/usb/host/ehci.h
> > @@ -642,7 +642,7 @@ #endif
> >
> >
> > /
> > *---------------------------------------------------------------------
> > -
> > ---*/
> >
> > -#ifdef CONFIG_PPC_83xx
> > +#ifdef CONFIG_MPC834x
> >  /* Some Freescale processors have an erratum in which the TT
> >   * port number in the queue head was 0..N-1 instead of 1..N.
> >   */
>
> Do we really want to make this change.  What harm is there in having
> the ehci support for MPC834x build on all 83xx processors?  I can't
> imagine we are going to config in support for ehci on anything that
> is MPC834x at this point and if you do, your device tree isn't going
> to have nodes in it so the drivers not going to bind against anything.
>

It's not very harmful.  But it will cause some misunderstanding.
There were already some guys trying to use the 834x USB driver on 836x
and 832x.  Anyway, it's a trivial patch.  Please apply if it doesn't
cause much trouble.
> Finally, I got to believe Freescale's going to build some MPC83xx in
> the future with the high speed USB IP.

I can't tell exactly.  But it's not likely to integrate this IP into a
chip with QE/CPM support.  As QE/CPM has already provided full speed
USB support, and the USB speed is not very important for Netcomm
processors.
>
> - kumar
>
> >
> >> -----Original Message-----
> >> From: linux-usb-devel-bounces@lists.sourceforge.net
> >> [mailto:linux-usb-devel-bounces@lists.sourceforge.net] On Behalf Of
> > Kumar Gala
> >> Sent: Friday, July 14, 2006 9:52 PM
> >> To: Li Yang-r58472
> >> Cc: linuxppc-dev@ozlabs.org; gregkh@suse.de;
> >> linux-usb-devel@lists.sourceforge.net
> >> Subject: Re: [linux-usb-devel] [PATCH] Fix Freescale high-speed USB
> > hostdependency
> >>
> >> Acked-by: Kumar Gala <galak@kernel.crashing.org>
> >>
> >> On Jul 14, 2006, at 6:58 AM, Li Yang wrote:
> >>
> >>> The high-speed USB SOC only exists on MPC834x family not MPC83xx
> >>> family.
> >>>
> >>> Signed-off-by: Li Yang <leoli@freescale.com>
> >>>
> >>> ---
> >>>
> >>>  drivers/usb/host/ehci-hcd.c |    2 +-
> >>>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>>
> >>> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-
> >>> hcd.c index 79f2d8b..3af1844 100644
> >>> --- a/drivers/usb/host/ehci-hcd.c
> >>> +++ b/drivers/usb/host/ehci-hcd.c
> >>> @@ -892,7 +892,7 @@ #include "ehci-pci.c"
> >>>  #define    EHCI_BUS_GLUED
> >>>  #endif
> >>>
> >>> -#ifdef CONFIG_PPC_83xx
> >>> +#ifdef CONFIG_MPC834x
> >>>  #include "ehci-fsl.c"
> >>>  #define    EHCI_BUS_GLUED
> >>>  #endif
> >
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>

Re: [linux-usb-devel] [PATCH] Fix Freescale high-speed USB hostdependency

[Kumar Gala]

On Jul 20, 2006, at 8:36 AM, Li Yang wrote:

> On 7/20/06, Kumar Gala <galak@kernel.crashing.org> wrote:
>>
>> On Jul 20, 2006, at 6:42 AM, Li Yang-r58472 wrote:
>>
>> > Another one in header file.
>> >
>> > ---
>> > diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
>> > index 679c1cd..8da2774 100644
>> > --- a/drivers/usb/host/ehci.h
>> > +++ b/drivers/usb/host/ehci.h
>> > @@ -642,7 +642,7 @@ #endif
>> >
>> >
>> > /
>> >  
>> *-------------------------------------------------------------------- 
>> -
>> > -
>> > ---*/
>> >
>> > -#ifdef CONFIG_PPC_83xx
>> > +#ifdef CONFIG_MPC834x
>> >  /* Some Freescale processors have an erratum in which the TT
>> >   * port number in the queue head was 0..N-1 instead of 1..N.
>> >   */
>>
>> Do we really want to make this change.  What harm is there in having
>> the ehci support for MPC834x build on all 83xx processors?  I can't
>> imagine we are going to config in support for ehci on anything that
>> is MPC834x at this point and if you do, your device tree isn't going
>> to have nodes in it so the drivers not going to bind against  
>> anything.
>>
>
> It's not very harmful.  But it will cause some misunderstanding.
> There were already some guys trying to use the 834x USB driver on 836x
> and 832x.  Anyway, it's a trivial patch.  Please apply if it doesn't
> cause much trouble.

Is that more because the QE drivers aren't in the kernel tree?

>> Finally, I got to believe Freescale's going to build some MPC83xx in
>> the future with the high speed USB IP.
>
> I can't tell exactly.  But it's not likely to integrate this IP into a
> chip with QE/CPM support.  As QE/CPM has already provided full speed
> USB support, and the USB speed is not very important for Netcomm
> processors.

True, but not all 83xx are Netcomm processors.

- k

Re: [linux-usb-devel] [PATCH] Fix Freescale high-speed USB hostdependency

[Li Yang]

On 7/20/06, Kumar Gala <galak@kernel.crashing.org> wrote:
>
> On Jul 20, 2006, at 8:36 AM, Li Yang wrote:
>
> > On 7/20/06, Kumar Gala <galak@kernel.crashing.org> wrote:
> >>
> >> On Jul 20, 2006, at 6:42 AM, Li Yang-r58472 wrote:
> >>
> >> > Another one in header file.
> >> >
> >> > ---
> >> > diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
> >> > index 679c1cd..8da2774 100644
> >> > --- a/drivers/usb/host/ehci.h
> >> > +++ b/drivers/usb/host/ehci.h
> >> > @@ -642,7 +642,7 @@ #endif
> >> >
> >> >
> >> > /
> >> >
> >> *--------------------------------------------------------------------
> >> -
> >> > -
> >> > ---*/
> >> >
> >> > -#ifdef CONFIG_PPC_83xx
> >> > +#ifdef CONFIG_MPC834x
> >> >  /* Some Freescale processors have an erratum in which the TT
> >> >   * port number in the queue head was 0..N-1 instead of 1..N.
> >> >   */
> >>
> >> Do we really want to make this change.  What harm is there in having
> >> the ehci support for MPC834x build on all 83xx processors?  I can't
> >> imagine we are going to config in support for ehci on anything that
> >> is MPC834x at this point and if you do, your device tree isn't going
> >> to have nodes in it so the drivers not going to bind against
> >> anything.
> >>
> >
> > It's not very harmful.  But it will cause some misunderstanding.
> > There were already some guys trying to use the 834x USB driver on 836x
> > and 832x.  Anyway, it's a trivial patch.  Please apply if it doesn't
> > cause much trouble.
>
> Is that more because the QE drivers aren't in the kernel tree?
>
> >> Finally, I got to believe Freescale's going to build some MPC83xx in
> >> the future with the high speed USB IP.
> >
> > I can't tell exactly.  But it's not likely to integrate this IP into a
> > chip with QE/CPM support.  As QE/CPM has already provided full speed
> > USB support, and the USB speed is not very important for Netcomm
> > processors.
>
> True, but not all 83xx are Netcomm processors.

83xx=PowerQUICC II Pro, IMHO.
I just give my 2 cents.  It's up to you to decide as you are the maintainer. :)
>
> - k
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>

Re: [linux-usb-devel] [PATCH] Fix Freescale high-speed USB hostdependency

[David Brownell]

On Thursday 20 July 2006 5:59 am, Kumar Gala wrote:

> >
> > -#ifdef CONFIG_PPC_83xx
> > +#ifdef CONFIG_MPC834x

So at the end of all that discussion, was there a USB patch to merge?
If so, I don't see one in my mail folder.

Re: [linux-usb-devel] [PATCH] Fix Freescale high-speed USB hostdependency

[Kumar Gala]

On Aug 1, 2006, at 10:38 AM, David Brownell wrote:

> On Thursday 20 July 2006 5:59 am, Kumar Gala wrote:
>
>>>
>>> -#ifdef CONFIG_PPC_83xx
>>> +#ifdef CONFIG_MPC834x
>
> So at the end of all that discussion, was there a USB patch to merge?
> If so, I don't see one in my mail folder.

Not on this side of things.  If we clean up the CONFIG_PPC stuff I'll  
push that through the PPC maintainer.  There was a patch for gadget  
support for the controller, but not sure if you handle that or not.

- k