* [PATCH] cxl: Fix possible null pointer dereference in read_handle()
@ 2024-07-09 13:17 Ma Ke
2024-07-09 13:32 ` Greg KH
2024-07-09 13:48 ` Markus Elfring
0 siblings, 2 replies; 3+ messages in thread
From: Ma Ke @ 2024-07-09 13:17 UTC (permalink / raw)
To: fbarrat, ajd, arnd, gregkh, manoj, mpe, clombard, imunsie
Cc: stable, linuxppc-dev, linux-kernel, Ma Ke
In read_handle() of_get_address() may return NULL which is later
dereferenced. Fix this bug by adding NULL check.
Cc: stable@vger.kernel.org
Fixes: 14baf4d9c739 ("cxl: Add guest-specific code")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
---
drivers/misc/cxl/of.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/cxl/of.c b/drivers/misc/cxl/of.c
index bcc005dff1c0..d8dbb3723951 100644
--- a/drivers/misc/cxl/of.c
+++ b/drivers/misc/cxl/of.c
@@ -58,7 +58,7 @@ static int read_handle(struct device_node *np, u64 *handle)
/* Get address and size of the node */
prop = of_get_address(np, 0, &size, NULL);
- if (size)
+ if (!prop || size)
return -EINVAL;
/* Helper to read a big number; size is in cells (not bytes) */
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] cxl: Fix possible null pointer dereference in read_handle()
2024-07-09 13:17 [PATCH] cxl: Fix possible null pointer dereference in read_handle() Ma Ke
@ 2024-07-09 13:32 ` Greg KH
2024-07-09 13:48 ` Markus Elfring
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2024-07-09 13:32 UTC (permalink / raw)
To: Ma Ke
Cc: ajd, arnd, linux-kernel, stable, manoj, imunsie, fbarrat,
linuxppc-dev, clombard
On Tue, Jul 09, 2024 at 09:17:54PM +0800, Ma Ke wrote:
> In read_handle() of_get_address() may return NULL which is later
> dereferenced. Fix this bug by adding NULL check.
>
> Cc: stable@vger.kernel.org
> Fixes: 14baf4d9c739 ("cxl: Add guest-specific code")
> Signed-off-by: Ma Ke <make24@iscas.ac.cn>
> ---
> drivers/misc/cxl/of.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/cxl/of.c b/drivers/misc/cxl/of.c
> index bcc005dff1c0..d8dbb3723951 100644
> --- a/drivers/misc/cxl/of.c
> +++ b/drivers/misc/cxl/of.c
> @@ -58,7 +58,7 @@ static int read_handle(struct device_node *np, u64 *handle)
>
> /* Get address and size of the node */
> prop = of_get_address(np, 0, &size, NULL);
> - if (size)
> + if (!prop || size)
> return -EINVAL;
How was this issue found?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] cxl: Fix possible null pointer dereference in read_handle()
2024-07-09 13:17 [PATCH] cxl: Fix possible null pointer dereference in read_handle() Ma Ke
2024-07-09 13:32 ` Greg KH
@ 2024-07-09 13:48 ` Markus Elfring
1 sibling, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2024-07-09 13:48 UTC (permalink / raw)
To: make24, linuxppc-dev, kernel-janitors
Cc: Wei Liu, Christophe Lombard, Arnd Bergmann, Greg Kroah-Hartman,
LKML, stable, Manoj N. Kumar, Ian Munsie, Frederic Barrat,
Andrew Donnellan
…
> Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Under which circumstances will this information be corrected anyhow?
The usage of mailing list addresses is probably undesirable for
the Developer's Certificate of Origin, isn't it?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc7#n398
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-09 13:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-09 13:17 [PATCH] cxl: Fix possible null pointer dereference in read_handle() Ma Ke
2024-07-09 13:32 ` Greg KH
2024-07-09 13:48 ` Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).