From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E446C4361B for ; Sun, 13 Dec 2020 19:41:11 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5FCE20754 for ; Sun, 13 Dec 2020 19:41:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5FCE20754 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4CvFJ36TtmzDqSd for ; Mon, 14 Dec 2020 06:41:07 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=infradead.org (client-ip=90.155.50.34; helo=casper.infradead.org; envelope-from=geoff@infradead.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=infradead.org Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4CvFFt1BBtzDqRN for ; Mon, 14 Dec 2020 06:39:14 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=gtkC2cwUyIZHi2THFuqJZjqPt1krJsPvyreKUidD7mw=; b=Ch83eRaVuMImRjym8HnQzBa5XQ dVYR4G4EuxcCPragNt7sSP0FkCy7XSei5yKmrQE90qh1M5Pi1XjPnaNKEchmnAQSmJwEpLWjcPcvB rdzVOHEihCHC95LRzGBF990z4UEUUoEDT8lgtYMEDsJlDJZEHvijvg/8k5I+Y3/Li6+F0301OPNuw /ABD5ONp0bVNbr+H+cMEaNCL09swp3D03xKk4HK04ES08EkdskHaf+C1jHXdEgUrDF0dz4rlxBp5q Mhv3zCy6EbT2AQyLC6sQLOIq9c6EAFOVHv0Yk6SEVVQyq2D6h+QFB5dFCo72UNduxHsvwg6l9ZJut z9lGfXJA==; Received: from [2602:306:c5a2:a380:9e7b:efff:fe40:2b26] by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1koXCT-0005tq-MO; Sun, 13 Dec 2020 19:38:33 +0000 Subject: Re: [PATCH] powerpc/ps3: use dma_mapping_error() To: =?UTF-8?Q?Vincent_Stehl=c3=a9?= , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20201213182622.23047-1-vincent.stehle@laposte.net> From: Geoff Levand Message-ID: Date: Sun, 13 Dec 2020 11:38:31 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201213182622.23047-1-vincent.stehle@laposte.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Geert Uytterhoeven Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 12/13/20 10:26 AM, Vincent Stehlé wrote: > The DMA address returned by dma_map_single() should be checked with > dma_mapping_error(). Fix the ps3stor_setup() function accordingly. > > Fixes: 80071802cb9c ("[POWERPC] PS3: Storage Driver Core") > Signed-off-by: Vincent Stehlé > Cc: Geoff Levand > Cc: Geert Uytterhoeven > --- > drivers/ps3/ps3stor_lib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks good. Thanks for submitting. Acked by: Geoff Levand