* [PATCH] powerpc: allow PPC_EARLY_DEBUG_CPM only when SERIAL_CPM=y
@ 2023-05-16 15:28 Randy Dunlap
2023-05-16 18:54 ` Pali Rohár
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2023-05-16 15:28 UTC (permalink / raw)
To: linux-kernel
Cc: linuxppc-dev, Randy Dunlap, Kumar Gala, Nicholas Piggin,
Scott Wood, Pali Rohár
In a randconfig with CONFIG_SERIAL_CPM=m and
CONFIG_PPC_EARLY_DEBUG_CPM=y, there is a build error:
ERROR: modpost: "udbg_putc" [drivers/tty/serial/cpm_uart/cpm_uart.ko] undefined!
Prevent the build error by allowing PPC_EARLY_DEBUG_CPM only when
SERIAL_CPM=y.
Fixes: c374e00e17f1 ("[POWERPC] Add early debug console for CPM serial ports.")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Scott Wood <scottwood@freescale.com>
Cc: Kumar Gala <galak@kernel.crashing.org>
Cc: "Pali Rohár" <pali@kernel.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: linuxppc-dev@lists.ozlabs.org
---
arch/powerpc/Kconfig.debug | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -- a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug
--- a/arch/powerpc/Kconfig.debug
+++ b/arch/powerpc/Kconfig.debug
@@ -240,7 +240,7 @@ config PPC_EARLY_DEBUG_40x
config PPC_EARLY_DEBUG_CPM
bool "Early serial debugging for Freescale CPM-based serial ports"
- depends on SERIAL_CPM
+ depends on SERIAL_CPM=y
help
Select this to enable early debugging for Freescale chips
using a CPM-based serial port. This assumes that the bootwrapper
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc: allow PPC_EARLY_DEBUG_CPM only when SERIAL_CPM=y
2023-05-16 15:28 [PATCH] powerpc: allow PPC_EARLY_DEBUG_CPM only when SERIAL_CPM=y Randy Dunlap
@ 2023-05-16 18:54 ` Pali Rohár
2023-06-10 3:11 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: Pali Rohár @ 2023-05-16 18:54 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, Kumar Gala, Nicholas Piggin, linuxppc-dev
On Tuesday 16 May 2023 08:28:54 Randy Dunlap wrote:
> In a randconfig with CONFIG_SERIAL_CPM=m and
> CONFIG_PPC_EARLY_DEBUG_CPM=y, there is a build error:
> ERROR: modpost: "udbg_putc" [drivers/tty/serial/cpm_uart/cpm_uart.ko] undefined!
>
> Prevent the build error by allowing PPC_EARLY_DEBUG_CPM only when
> SERIAL_CPM=y.
>
> Fixes: c374e00e17f1 ("[POWERPC] Add early debug console for CPM serial ports.")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Scott Wood <scottwood@freescale.com>
> Cc: Kumar Gala <galak@kernel.crashing.org>
> Cc: "Pali Rohár" <pali@kernel.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Nicholas Piggin <npiggin@gmail.com>
> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
> Cc: linuxppc-dev@lists.ozlabs.org
Looks good,
Reviewed-by: Pali Rohár <pali@kernel.org>
> ---
> arch/powerpc/Kconfig.debug | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -- a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug
> --- a/arch/powerpc/Kconfig.debug
> +++ b/arch/powerpc/Kconfig.debug
> @@ -240,7 +240,7 @@ config PPC_EARLY_DEBUG_40x
>
> config PPC_EARLY_DEBUG_CPM
> bool "Early serial debugging for Freescale CPM-based serial ports"
> - depends on SERIAL_CPM
> + depends on SERIAL_CPM=y
> help
> Select this to enable early debugging for Freescale chips
> using a CPM-based serial port. This assumes that the bootwrapper
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc: allow PPC_EARLY_DEBUG_CPM only when SERIAL_CPM=y
2023-05-16 18:54 ` Pali Rohár
@ 2023-06-10 3:11 ` Randy Dunlap
2023-07-01 5:46 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2023-06-10 3:11 UTC (permalink / raw)
To: Pali Rohár; +Cc: linux-kernel, Kumar Gala, Nicholas Piggin, linuxppc-dev
Hi--
On 5/16/23 11:54, Pali Rohár wrote:
> On Tuesday 16 May 2023 08:28:54 Randy Dunlap wrote:
>> In a randconfig with CONFIG_SERIAL_CPM=m and
>> CONFIG_PPC_EARLY_DEBUG_CPM=y, there is a build error:
>> ERROR: modpost: "udbg_putc" [drivers/tty/serial/cpm_uart/cpm_uart.ko] undefined!
>>
>> Prevent the build error by allowing PPC_EARLY_DEBUG_CPM only when
>> SERIAL_CPM=y.
>>
>> Fixes: c374e00e17f1 ("[POWERPC] Add early debug console for CPM serial ports.")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Scott Wood <scottwood@freescale.com>
>> Cc: Kumar Gala <galak@kernel.crashing.org>
>> Cc: "Pali Rohár" <pali@kernel.org>
>> Cc: Michael Ellerman <mpe@ellerman.id.au>
>> Cc: Nicholas Piggin <npiggin@gmail.com>
>> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
>> Cc: linuxppc-dev@lists.ozlabs.org
>
> Looks good,
>
> Reviewed-by: Pali Rohár <pali@kernel.org>
I'm still seeing this build error in linux-next even with other (PPC) CPM
patches applied.
>
>> ---
>> arch/powerpc/Kconfig.debug | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff -- a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug
>> --- a/arch/powerpc/Kconfig.debug
>> +++ b/arch/powerpc/Kconfig.debug
>> @@ -240,7 +240,7 @@ config PPC_EARLY_DEBUG_40x
>>
>> config PPC_EARLY_DEBUG_CPM
>> bool "Early serial debugging for Freescale CPM-based serial ports"
>> - depends on SERIAL_CPM
>> + depends on SERIAL_CPM=y
>> help
>> Select this to enable early debugging for Freescale chips
>> using a CPM-based serial port. This assumes that the bootwrapper
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc: allow PPC_EARLY_DEBUG_CPM only when SERIAL_CPM=y
2023-06-10 3:11 ` Randy Dunlap
@ 2023-07-01 5:46 ` Randy Dunlap
2023-07-01 6:30 ` Christophe Leroy
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2023-07-01 5:46 UTC (permalink / raw)
To: Pali Rohár; +Cc: linux-kernel, Kumar Gala, Nicholas Piggin, linuxppc-dev
On 6/9/23 20:11, Randy Dunlap wrote:
> Hi--
>
> On 5/16/23 11:54, Pali Rohár wrote:
>> On Tuesday 16 May 2023 08:28:54 Randy Dunlap wrote:
>>> In a randconfig with CONFIG_SERIAL_CPM=m and
>>> CONFIG_PPC_EARLY_DEBUG_CPM=y, there is a build error:
>>> ERROR: modpost: "udbg_putc" [drivers/tty/serial/cpm_uart/cpm_uart.ko] undefined!
>>>
>>> Prevent the build error by allowing PPC_EARLY_DEBUG_CPM only when
>>> SERIAL_CPM=y.
>>>
>>> Fixes: c374e00e17f1 ("[POWERPC] Add early debug console for CPM serial ports.")
>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>> Cc: Scott Wood <scottwood@freescale.com>
>>> Cc: Kumar Gala <galak@kernel.crashing.org>
>>> Cc: "Pali Rohár" <pali@kernel.org>
>>> Cc: Michael Ellerman <mpe@ellerman.id.au>
>>> Cc: Nicholas Piggin <npiggin@gmail.com>
>>> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
>>> Cc: linuxppc-dev@lists.ozlabs.org
>>
>> Looks good,
>>
>> Reviewed-by: Pali Rohár <pali@kernel.org>
>
> I'm still seeing this build error in linux-next even with other (PPC) CPM
> patches applied.
>
Patchwork shows status as Superseded:
http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20230516152854.22465-1-rdunlap@infradead.org/
but I don't understand why or by what.
I'm going to resubmit the patch now.
>>
>>> ---
>>> arch/powerpc/Kconfig.debug | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff -- a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug
>>> --- a/arch/powerpc/Kconfig.debug
>>> +++ b/arch/powerpc/Kconfig.debug
>>> @@ -240,7 +240,7 @@ config PPC_EARLY_DEBUG_40x
>>>
>>> config PPC_EARLY_DEBUG_CPM
>>> bool "Early serial debugging for Freescale CPM-based serial ports"
>>> - depends on SERIAL_CPM
>>> + depends on SERIAL_CPM=y
>>> help
>>> Select this to enable early debugging for Freescale chips
>>> using a CPM-based serial port. This assumes that the bootwrapper
>
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc: allow PPC_EARLY_DEBUG_CPM only when SERIAL_CPM=y
2023-07-01 5:46 ` Randy Dunlap
@ 2023-07-01 6:30 ` Christophe Leroy
0 siblings, 0 replies; 5+ messages in thread
From: Christophe Leroy @ 2023-07-01 6:30 UTC (permalink / raw)
To: Randy Dunlap, Pali Rohár
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Nicholas Piggin, Kumar Gala
Le 01/07/2023 à 07:46, Randy Dunlap a écrit :
>
>
> On 6/9/23 20:11, Randy Dunlap wrote:
>> Hi--
>>
>> On 5/16/23 11:54, Pali Rohár wrote:
>>> On Tuesday 16 May 2023 08:28:54 Randy Dunlap wrote:
>>>> In a randconfig with CONFIG_SERIAL_CPM=m and
>>>> CONFIG_PPC_EARLY_DEBUG_CPM=y, there is a build error:
>>>> ERROR: modpost: "udbg_putc" [drivers/tty/serial/cpm_uart/cpm_uart.ko] undefined!
>>>>
>>>> Prevent the build error by allowing PPC_EARLY_DEBUG_CPM only when
>>>> SERIAL_CPM=y.
>>>>
>>>> Fixes: c374e00e17f1 ("[POWERPC] Add early debug console for CPM serial ports.")
>>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>>> Cc: Scott Wood <scottwood@freescale.com>
>>>> Cc: Kumar Gala <galak@kernel.crashing.org>
>>>> Cc: "Pali Rohár" <pali@kernel.org>
>>>> Cc: Michael Ellerman <mpe@ellerman.id.au>
>>>> Cc: Nicholas Piggin <npiggin@gmail.com>
>>>> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
>>>> Cc: linuxppc-dev@lists.ozlabs.org
>>>
>>> Looks good,
>>>
>>> Reviewed-by: Pali Rohár <pali@kernel.org>
>>
>> I'm still seeing this build error in linux-next even with other (PPC) CPM
>> patches applied.
>>
>
> Patchwork shows status as Superseded:
>
> http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20230516152854.22465-1-rdunlap@infradead.org/
>
> but I don't understand why or by what.
Neither do I. I must have made a mistake but I can't remember.
>
> I'm going to resubmit the patch now.
Fine, then the previous is really superseeded now.
Christophe
>
>
>>>
>>>> ---
>>>> arch/powerpc/Kconfig.debug | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff -- a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug
>>>> --- a/arch/powerpc/Kconfig.debug
>>>> +++ b/arch/powerpc/Kconfig.debug
>>>> @@ -240,7 +240,7 @@ config PPC_EARLY_DEBUG_40x
>>>>
>>>> config PPC_EARLY_DEBUG_CPM
>>>> bool "Early serial debugging for Freescale CPM-based serial ports"
>>>> - depends on SERIAL_CPM
>>>> + depends on SERIAL_CPM=y
>>>> help
>>>> Select this to enable early debugging for Freescale chips
>>>> using a CPM-based serial port. This assumes that the bootwrapper
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-07-01 6:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-16 15:28 [PATCH] powerpc: allow PPC_EARLY_DEBUG_CPM only when SERIAL_CPM=y Randy Dunlap
2023-05-16 18:54 ` Pali Rohár
2023-06-10 3:11 ` Randy Dunlap
2023-07-01 5:46 ` Randy Dunlap
2023-07-01 6:30 ` Christophe Leroy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).