From: Segher Boessenkool <segher@kernel.crashing.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [RFC/PATCH 4/4] Add support for MSI on Axon-based Cell systems
Date: Fri, 8 Jun 2007 22:16:48 +0200 [thread overview]
Message-ID: <a2b3134aaf411c43fabdb6bba233f91a@kernel.crashing.org> (raw)
In-Reply-To: <200706082206.55380.arnd@arndb.de>
> If you do
>
> for_each_compatible_node(node, NULL, "foo") {
> do_something(node);
> }
>
> then the reference count is held just as long as the do_something()
> function is run,
Yeah. so (like we discussed on irc) the of_node_get() in
the code under discussion should really be done inside the
axon_msi_setup_one() function.
> and if you do
>
> for_each_compatible_node(node, NULL, "foo")
> if (conditional_func(node))
> break;
>
> then the node variable will have the reference count.
Yes. This is bad form though, "for_each" means for
_each_, open coding the loop would be clearer IMHO.
Segher
next prev parent reply other threads:[~2007-06-08 20:16 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-04 12:59 [PATCH 1/4] Split virq setup logic out into irq_setup_virq() Michael Ellerman
2007-06-04 13:00 ` [PATCH 2/4] Add irq_create_direct_mapping() Michael Ellerman
2007-06-04 22:44 ` Benjamin Herrenschmidt
2007-06-04 13:00 ` [PATCH 3/4] Add for_each_compatible_node() Michael Ellerman
2007-06-04 22:44 ` Benjamin Herrenschmidt
2007-06-04 13:00 ` [RFC/PATCH 4/4] Add support for MSI on Axon-based Cell systems Michael Ellerman
2007-06-04 17:09 ` Arnd Bergmann
2007-06-04 17:12 ` Arnd Bergmann
2007-06-08 2:53 ` Michael Ellerman
2007-06-08 8:47 ` Segher Boessenkool
2007-06-08 19:26 ` Arnd Bergmann
2007-06-08 19:36 ` Segher Boessenkool
2007-06-08 19:59 ` Segher Boessenkool
2007-06-08 20:06 ` Arnd Bergmann
2007-06-08 20:16 ` Segher Boessenkool [this message]
2007-06-12 2:32 ` Michael Ellerman
2007-06-08 20:01 ` Arnd Bergmann
2007-06-08 20:06 ` Segher Boessenkool
2007-06-12 2:30 ` Michael Ellerman
2007-06-04 22:45 ` Benjamin Herrenschmidt
2007-06-05 7:00 ` Jean-Christophe Dubois
2007-06-05 9:16 ` Arnd Bergmann
2007-06-05 9:29 ` Jean-Christophe Dubois
2007-06-05 9:30 ` Arnd Bergmann
2007-06-07 7:58 ` Michael Ellerman
2007-06-07 8:10 ` Jean-Christophe Dubois
2007-06-07 11:55 ` Benjamin Herrenschmidt
2007-06-07 12:00 ` Jean-Christophe Dubois
2007-06-05 14:12 ` Milton Miller
2007-06-06 5:19 ` Michael Ellerman
2007-06-04 22:43 ` [PATCH 1/4] Split virq setup logic out into irq_setup_virq() Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2b3134aaf411c43fabdb6bba233f91a@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=arnd@arndb.de \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).