From: "Kalle Pokki" <kalle.pokki@iki.fi>
To: linuxppc-embedded@ozlabs.org
Subject: 82xx PCI setup ioremapping twice
Date: Wed, 2 Aug 2006 10:10:46 +0300 [thread overview]
Message-ID: <a425f86c0608020010q5b1c07d3s537a284455801d0b@mail.gmail.com> (raw)
Hi,
In pq2_find_bridges(), there is a call to setup_m8260_indirect_pci(),
which ioremaps the configuration address and data registers. The call
uses the cpm2_immr pointer, which however is already ioremapped by
cpm2_reset(). ioremapping these addresses twice seems to always crash
my board, and I need to e.g.
Index: linux-2.6.15.4/arch/ppc/syslib/m82xx_pci.c
===================================================================
--- linux-2.6.15.4.orig/arch/ppc/syslib/m82xx_pci.c 2006-08-02
09:45:54.000000000 +0300
+++ linux-2.6.15.4/arch/ppc/syslib/m82xx_pci.c 2006-08-02
09:46:32.000000000 +0300
@@ -324,7 +324,7 @@
hose->set_cfg_type = 1;
#endif
- setup_m8260_indirect_pci(hose,
+ setup_indirect_pci_nomap(hose,
(unsigned long)&cpm2_immr->im_pci.pci_cfg_addr,
(unsigned
long)&cpm2_immr->im_pci.pci_cfg_data);
or use the physical addresses in the original function call.
Should ioremap() code check for these double mappings? There seems to
be some attempts to do that. I remember the PCI initialisation wasn't
a problem some time before with an earlier kernel version, a different
8248 board, and internal memory at 0xf0000000.
My internal memory is at physical address 0xff000000.
Linux kernel version is 2.6.15.4.
The board is a custom 8247.
reply other threads:[~2006-08-02 7:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a425f86c0608020010q5b1c07d3s537a284455801d0b@mail.gmail.com \
--to=kalle.pokki@iki.fi \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).