From: "Kalle Pokki" <kalle.pokki@iki.fi>
To: "Laurent Pinchart" <laurent.pinchart@tbox.biz>
Cc: Boris Shteinbock <boris@fabiotec.com>, linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH] CPM_UART: Fix non-console transmit
Date: Tue, 31 Oct 2006 13:52:03 +0200 [thread overview]
Message-ID: <a425f86c0610310352w1cdf7e20l438b098f109bebde@mail.gmail.com> (raw)
In-Reply-To: <200610311124.46698.laurent.pinchart@tbox.biz>
On 10/31/06, Laurent Pinchart <laurent.pinchart@tbox.biz> wrote:
> Ditto. Your patch fixed my problems. I'd like to see a fix (either this one or
> another one, there are different solutions) pushed upstream soon, as the
> problem is quite serious. I'm quite amazed nobody had ever reported it
> before.
I think cpm_uart_startup() is the right place to enable both
transmitter and receiver, since they are disabled in the corresponding
shutdown() function. Or actually, one might be just fine with never
disabling the hardware at all. I can't see any reason other than power
consumption that they are disabled by the shutdown() function.
It seems the reason of not enabling the transmitter at startup() is
that the serial core specification only states that reception should
be enabled with that function call. However enabling also the
transmitter does not by itself initiate any transmissions, so it
should be just fine. It just makes the hardware ready to transmit.
next prev parent reply other threads:[~2006-10-31 11:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-19 16:05 [PATCH] CPM_UART: Fix non-console transmit Boris Shteinbock
2006-10-19 19:07 ` Kalle Pokki
2006-10-31 10:24 ` Laurent Pinchart
2006-10-31 11:52 ` Kalle Pokki [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-10-19 12:52 Kalle Pokki
2006-10-31 15:08 ` Vitaly Bordug
2006-11-01 3:35 ` Paul Mackerras
2006-11-01 7:52 ` Kalle Pokki
2006-10-19 12:25 kalle.pokki
2006-10-19 19:28 ` Vitaly Bordug
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a425f86c0610310352w1cdf7e20l438b098f109bebde@mail.gmail.com \
--to=kalle.pokki@iki.fi \
--cc=boris@fabiotec.com \
--cc=laurent.pinchart@tbox.biz \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).